From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD094265CDD for ; Thu, 16 Jul 2026 20:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232966; cv=none; b=QMxv9+/R9hI0odlQJoNdJeBc5fGu9WHvEvVmr/+DVR5u7MWY3YCvgqH0pF/Gmw29YkqfcBq9du/wlJyXD+6oYsO9q4ZRlIA9PFx0kFc/vr9EchQAgPvsxZzdkDCvLOha6AGBNyh+uoXaUe9XVG7/au9H4COcGB/WB6rGYIYRITQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232966; c=relaxed/simple; bh=e4d49gtt0VA6EJ79AsY3IVsSMq+vGF/Qot02h5uy8Ac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hPQk7i7gfhJuQmVomCchBbawdIv+mkMkhng3jGUW7v4/0n7REbWsDWYasvNLjIkUCFMgohEWEcsAdaqIiGqroehP4kFqZuOdf19b1nfo448v/x3iFO09wOtf3KbQs/jf6mnVwwFfmup6q1sd4tSS2jID0U1V01OHCJykBBX4P+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jUdnP2LP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gp1h347A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jUdnP2LP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gp1h347A" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GJoY853606549 for ; Thu, 16 Jul 2026 20:16:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+pCiq/Qy0Lo ydinUbSokabUuk5OYFJlIyBFzOoKUkG4=; b=jUdnP2LP1nJy0NY7V2mjhocw1N+ IvWULgS3auzaJf7W3Jg6GH5SxYlMv4rN1YMapHvnbQYLtKhAMfr7T3govXuhoBu4 fl0sBEl5bWHYkP//iiwsAUGlcgWcUIaBG6MQccx6ng06DLzK7BIX/B3aCXiyqh44 k8RiGViI6QjYoQtJKmYlXZY653C/2BY61ega2lUzfuUcQztqXgBZUR5QDEyHQC3U DTj0AkyAQahs0ZYr2avxnKVyn3NBTsUGwkw5wjPj6r4yLNY+L6HLooXUDzyNIq7a GRRMrI5jGpIyLnyn6wi9yJQiPgj6tJ1mNa7pvL3UoKTxb5d9+vIXRSBWTXA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff1we974c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 20:16:03 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cc88e22f92so142908295ad.1 for ; Thu, 16 Jul 2026 13:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784232962; x=1784837762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+pCiq/Qy0LoydinUbSokabUuk5OYFJlIyBFzOoKUkG4=; b=Gp1h347AdlemURooLwC80OBRAKrZNsE4+NRzlg4rkqeEtj3QmlOz1APZQzbgPaVDYY Y/X+Gj27hgeFsEyZ+pTleUodunTgcneKNwdsRc/JUkL4+WxxaNKfWvLzWDDmtpxtKA0n QMPnWMMLqmIHXspjw1w/dzMqEA0OP9EyIcTPfgBdjM1oa/3XHRnihfMXdodJSP6JwGlc lM8K1ujP604cL+asVwSSzQEUwUw5nLpSlTY1OsoMJhnW69GdwyGV33YnlF7IeU/DOOq1 UqFr4zbmd/unH3bCqfV8SshkyJQF1CvBYqrN4foPcA5umk6K3VZViDjUgXe8KPC1ZpIw DEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784232962; x=1784837762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+pCiq/Qy0LoydinUbSokabUuk5OYFJlIyBFzOoKUkG4=; b=jqYwxnIyc9f/aDtuKd4/ztOvxFG5AwSEbvaGVJetYrk74Z4iKrATLQ6WXaZg3yB6IX H7lr6vWqtSydxMp4PNUAg0r+UkCtf34B/JHEQo7kYR7uZLV1hZHIaQe0dyR5dMphDNEB mVcL1hNSp/LtCDYrbZ2GFZDTNoIji7McRV0FQhvKGFuPnxLVZHHbX+Lm0WDD4t8w3Y4U 8MITLIn8FnW+v3pQIJRiAss8v0MPTuv6W4oEeqgICmiz/7lgJC82kUtXmUagnjr7AUMl u+CY8ltP0HJXPqN7VycPVojzYAegH4kWBuJfi0u3qF1CuRf7B5J/tbTC9SqkiQscSc2U i9NQ== X-Forwarded-Encrypted: i=1; AHgh+RrYdejpaiuk5CkNiiXAv3WCLrXAsnVmbL9cqMay0i2ACAXXTvwyk8mWcmcxzjVWygKzSUUz0ERC4Vpv5RQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxRSDoMVofojNUWA7D9ZLbaWqDVCQ/wQUM3S5aEhm6CgsPMt2+l 0fqf3OpNbjloi02nLEcIpVMO9z3YiBryrfCzT0suHqbDTk+bn+Ri3U1bz8T43/IXpBQRThyb9w7 3oflPKxC3ybKnx+hjYlUtCwux7PDqj/6MUJpQuaPrEbk95CX+FjYyub1PXHxaIWQgyNo= X-Gm-Gg: AfdE7cly6i5dVTTsU+VL/ewJvGUc1ZzACaVkymRes/MXE6X4GWwtJzzMxigCJwBn13Q 9BW7A42fcGtyxf9iAeYo3Xs0Jiz88DkCYSBKxa1hF7xwUuTXmycJHS0ixLBNQ715JzrkIHuk/tQ 0VT21IMkqyphNFsm+cTWVDcCaShSpfut6On7NRqve/j5nr35xkeIKciM9xIKHNDra4wxNc3wrtG VC35YBdur7I3339cZ072lT2e3ckNuxIYrEIh69ZQ8UT8qdY9SKTRHy3Ckm9fEZ87LnWJJ5ibp7A v1DO9PpEgWClIHXeilR9KxpKAY2ueu9eWL6Jbp+Qs9UCV8g6s20W71JtK4N9xnedsLaJISJ135+ 9b4a/tqOTC2OZ5ampuX11QrNCX9iFgNCJm6NukjK/wvFmFrQ= X-Received: by 2002:a17:903:2ec5:b0:2ca:17e2:2acc with SMTP id d9443c01a7336-2cf03cef19amr92452515ad.21.1784232962525; Thu, 16 Jul 2026 13:16:02 -0700 (PDT) X-Received: by 2002:a17:903:2ec5:b0:2ca:17e2:2acc with SMTP id d9443c01a7336-2cf03cef19amr92452135ad.21.1784232961998; Thu, 16 Jul 2026 13:16:01 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf105b244asm25206495ad.61.2026.07.16.13.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:16:01 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 09/10] drm/msm: Fix per-process-pgtables check Date: Thu, 16 Jul 2026 13:15:32 -0700 Message-ID: <20260716201538.365824-10-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> References: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfXz2HubilzbXa6 sNC8YS06J4+WsBMBpeOorhPX2M78f3+XKki8ry6dJDOip/2zsmOLJWrOsvvjQF5KQHxhzUqDtfY qG6TTQrI1F5zhWmCTO7zDkFTkxhEzstSXFzbo0ISCF5+f8iM3BDtcdsP4iLsPWXKX5V7ZzQcAhK d8K+2rx/Pq9s1O71Efj8nBMropnaVH9zDsWD+JniFxspGRouj8KPdHM8R3Z8XZz+vKpNk78F89m 4w0VKOGHGopXt1L8BEdsm8cPtsBXdy4L5QIlhJtxMsz7wmlgFjy7KTUp3/FsPx58OLTmzxetCY8 tDB4MQ0M/1TaKlyPDyPF9cfy+mt1frdgqq/NvO4AduLlcpEVtaafaLVj4CF3KKJd3Tt8Q/ptktq DT0xzKoFgLdivs7L6SGxumL0GW/hOdOIGyBPv4Pf3FsOxKMdSr1LKz+cY++vrGwJ+PPEyGJ2LtN QLZQ5DEzHCkXPNEa26g== X-Authority-Analysis: v=2.4 cv=JJ8LdcKb c=1 sm=1 tr=0 ts=6a593c03 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vtH2vi951kckHO5NeAIA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfX6Tjwf+3Ds4lJ L13+Ff2tPmW4fJKs/ReXA++ygg4Tfn6+ApPIDy3kTjcARb+KYTudx49QakGo+G3HXONdE3cguWj AQPngcGau0gACXNlZjg1RarawxmhTBM= X-Proofpoint-ORIG-GUID: A1VsrV3hgEO5lNXWo-9eWU26qsO54gEg X-Proofpoint-GUID: A1VsrV3hgEO5lNXWo-9eWU26qsO54gEg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_07,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160206 ctx->vm should not be inialized yet (or if it has, an error is returned immediately following this check), so this isn't a valid way to check for per-process-pgtable support. Instead just check if create_private_vm() is supported. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 84101e534ebe..3370cd44382f 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -513,7 +513,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, guard(rwsem_read)(&ctx->ctxlock); /* We can only support VM_BIND with per-process pgtables: */ - if (ctx->vm == gpu->vm) + if (!gpu->funcs->create_private_vm) return UERR(EINVAL, drm, "requires per-process pgtables"); /* -- 2.55.0