From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8EB373BF1 for ; Thu, 16 Jul 2026 20:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232968; cv=none; b=EAQFhex7F1LS5JQQSzGNtpFoxxTtKVnEC1e2fW2j/Gw+odrxsKxd0a1yXW8VKUAcCgR4WwWEqU4sTl3J3yGVQ/OoLnIfW/pJRywwoRoWqaNK+HGE2cDvoCRO7wBgqQlZ0cmrf6xoSiN5BpWeafxGaUMDG/+2wkRkRGWhXLiv7OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232968; c=relaxed/simple; bh=KuRE2G+9WZSgtg+s9COPO+3ULtlKav3rewHMFppxllY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m2mrRck5sy1Up8ZB5agJUlL3juuPI8RJjfQRaaS3aCruEeTlIEaVrEpJr79AxCATsA5Ag0bPGJQBPhMXLjid4PqXOCTCA0wtoppZ8WPvI1c5D+mwmD6z/DEf7QP1Cmy6KFA5gMNem+tHxt2rcQn/0Gs52dUiZO25Wh0VAIjTJeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mxhsdYpU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dhLN2Y/G; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mxhsdYpU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dhLN2Y/G" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GJoY4r3577081 for ; Thu, 16 Jul 2026 20:16:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=R5rQRmby/aI qaDxi3lDE9FH/pFFSKzh2fmPcewxXgX4=; b=mxhsdYpUIkz1c0vF+NQrAtW2Q+h eXErsuuxIrCsGdLYDqKAfC9GgLmNQcKKmQFwU5gZC5qiDflCtp6elpKFDz3fPFNG N2oSRhGUDongA+fwF4RF9GGuX4FlN9jnGU3MnuWj+/lku9+1g5Wg/+rXUn0GDknr F7ffst7sZvWyAWAkUONO++fYNvogB+dnm3LfecRSjLItQ1Y5eCOAm21Za35qHVDH 3YlpynzIxgXv0KtYxSWwq0n8gvB+ZPmuT3L1seui86mhscc0HpokoejTjPEjie6f 9C20+X+jxYiN+EEHeXBiy1uobPSPT27XB1z3G/A+xIy504IGs6JSU9HWMHg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff3u8gks0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 20:16:06 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8487eb67173so11088272b3a.2 for ; Thu, 16 Jul 2026 13:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784232965; x=1784837765; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R5rQRmby/aIqaDxi3lDE9FH/pFFSKzh2fmPcewxXgX4=; b=dhLN2Y/GIsvL+2BUtEXs6aH9RODYIozK2+4Z00ddq6IGAIcGF5g9uII3iBYOYWGl5B fnu/yl07sZ4P7Kx6mwUV7RCvXU8hD+aZsq1QTzCneCBjuy6HsLI57UKLHEzKTilsllAG hHj/xJ26U5XDQAxayP/PIs+8MSnppvkSkSYDJTO7dAw+itO+Hld2q+IF7fVaVvxiCvUJ Sza7BoVX2zhStf1k1yUnkXdLH8fRdhmWo5UIJFh6wNzS75uP2S1/eF5ykQQlMHRr5J5T czzk7jHXUA5aEbk6M7PqzC3Adraz2d9PUKwZPpwEh4vjgOG+X34aW/tHXxbVWQ82YeV3 SIOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784232965; x=1784837765; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=R5rQRmby/aIqaDxi3lDE9FH/pFFSKzh2fmPcewxXgX4=; b=aN8Iej/oRP0J4GAcS8oJaS5WeHfapCePTFRRCfVRfgWH4+fzUWJGRyTt2hEEyzQOIM DtdQjNWxaY+pwboL0XKxTq8N/Gi0XEEBm5kI2DcTbRRJ7kJPZQ8I1jGwP0OODORdqXrr jdOoFKYdXHvH/ZdgdZvvE3g0M/Ngm4d4nP4FOGyiJ6O6LG6FB+odUmHr0AGwcED6OojV 5AzDXVnzpAN8Cr7IRwnCWkfbICdi6F5m5bR2DajD+XLc3ZyHRFdJM8TI+4Bz9HWqpnsu 2F8I+6814mtoknyoeS2rgLMglSWrLlVRlRfr2bR9CygImsBcgWMOKSiuAjkBR45iJvkP zeDQ== X-Forwarded-Encrypted: i=1; AHgh+Rogl1nPnmmOntPcDEEWQkOjFEeuwemk32it2V7VLtkGVuU6xMttYlZPRqc5dn44X4d2l3pMbW0uo1PyFNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3YCVqU7xU2qObbwnBXOUtrDMG8rSrKNyQotrz8eEMEpDCR8hk sO85ikYQa1q+jgSrnnUNM+Y6aF2FXF3RN2UoHAGTw76zfe2keJJWFmPkJ/ClxMXgteqpvg943gY T5PKeM4IR0Z0+aambqEzXmdYDUklqL+KK1O55R82Otq0ovG+AO9uTSgSm9zJ8P1ZIWRs= X-Gm-Gg: AfdE7cnoVQ1+NTk46FJphSbxtowSBtHfPgqvByWFR6v4FcqEQ+PcdVpnvhG/6ci9PlF xnD78wQG0RIfg2oMZutQXOklnKG/v0Juck/oB+T4ZlQBJlD43KC2QIT7ET5jSWlG2BUIeCzOhRP kyQCGBtIkWaM0KWvAgDWoZZf8gTW5dy3xx31vhfG6wZtI/bh8oCJ83EuT8FIwga/K1QdRwJWwJ4 Bwows0r6fmsTxKNuRkt5/3xxHOi7A+g2LJ7s8+5WvraGoGbZoD7KKDc0+LxkVqezJzUvtC+CKjW +FKOx78b7sW+mUOfn22TYOZIhJGu8y9TxrjhUUKfLSwJjSRA5k0d8oKt/jf+g9e4c4v//ehffjq KN7wHe8JmzHKhRCdOskd79iaC6XO/pP7sS704YqEWwiZzt5E= X-Received: by 2002:a05:6a00:4484:b0:847:9367:e054 with SMTP id d2e1a72fcca58-84a5162fac2mr11522945b3a.57.1784232965215; Thu, 16 Jul 2026 13:16:05 -0700 (PDT) X-Received: by 2002:a05:6a00:4484:b0:847:9367:e054 with SMTP id d2e1a72fcca58-84a5162fac2mr11522902b3a.57.1784232964749; Thu, 16 Jul 2026 13:16:04 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f2389f8sm5296283b3a.4.2026.07.16.13.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:16:03 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 10/10] drm/msm: Remove invalid overflow check Date: Thu, 16 Jul 2026 13:15:33 -0700 Message-ID: <20260716201538.365824-11-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> References: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 2mTEYmJEDTV0wSnbVxwGS5xBiPdnVMYn X-Proofpoint-ORIG-GUID: 2mTEYmJEDTV0wSnbVxwGS5xBiPdnVMYn X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfX0hMsM0SKaphr PAP5hLggUfIMb+P3iRnR4uTRB0+aJUrOEqoTHDUSSMnTWwCx/J4SuYut8W3I0aTPLs/vu3t9Q+X wUhwIZe/54ePpTMVEQzFy0TLtUR70yY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfX+aMtuMr8GZi6 fcwae/UEoSuow5BdXwShttr8I2So8J9rsQHRdFJjHx1EvuoXCecBb7RVUQc95As4aar+Hi6VAs+ ci1NTh677EleGUYEvvf3Zc6BuAmNN75dpIhmYL+7/GruQAlO1YWpHwULyYXOuW1MyzXhi9NVkK6 xDDsshgzRa4VaSm1bUsJoX9xXe+iKrKLe+nldofymM8FKyLVDtIQe9IL0j9CkjUFzu4HRHHsqh1 2tea0CS67BD87cJYS/RDZWB+c5VrEDhiAtTFcf8EfMjNz7dbjWRJkh+1kA/mvsO44aG36gyKF10 4BKISSZnQX35YQcz4UJL481T1U2N38SRrFBhFHV+h8cWZxUNro9mU3x5jA9dYFsdE4ZLap4lQiK Ud/hSIoSIQy/bNb231HYnRI1Ki+Cs0eDqZoxPvEwLIYaOYaWQ44kKMEN2YeoB/OQOHXY0tYeyj8 aHlxDz5/g85fnSmf0WQ== X-Authority-Analysis: v=2.4 cv=TL11jVla c=1 sm=1 tr=0 ts=6a593c06 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=0g9OVxrcTuodNeR8YWUA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_07,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160206 On overflow struct_size() would return SIZE_MAX. But kzalloc() (and friends) check this already, so we can just remove the check. Reported-by: Sashiko Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index ab33d499a0e8..ddd52142c1cf 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -36,15 +36,11 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev, { static atomic_t ident = ATOMIC_INIT(0); struct msm_gem_submit *submit; - uint64_t sz; + size_t sz; int ret; sz = struct_size(submit, bos, nr_bos) + ((u64)nr_cmds * sizeof(submit->cmd[0])); - - if (sz > SIZE_MAX) - return ERR_PTR(-ENOMEM); - submit = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN); if (!submit) return ERR_PTR(-ENOMEM); -- 2.55.0