From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88324372EF7 for ; Thu, 16 Jul 2026 20:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232965; cv=none; b=mf1dGTDToBgOVUHGQJT9JKPzSFyq3ZXTiEpjPwMcdUx5w/sp4wlgg4Qcu2RrLua/bGk0bQ0qI4YZAqUN4eMYlNkw78pkmF20P5bh6ADnNJsVHIJiJZB3Ei9KyWB/UwHrIXsgFo2IV7f6EpTysjBWykM0N540lmtNpXd6vG33GhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232965; c=relaxed/simple; bh=plPG4Pa//cZWcSBZyuDX/H43p72/a2X/5oHyz9R8Qs0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SrgiCjyV5Qjkd13J5h0aYqch7LIVz261QMkcwi+/zUNIGR/8hWeH/hqVRJG0VoT0rILdSGbm8lTIoYXGvBkoFWb8FtQU3gSmUytoGegc57wcvCro5/ltg5HiulM82gySoc8DaTlnAaTVLoReON4WJKQ8vo0XwjfXdlw1p5OMcUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BOba50vT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QYT9SMV3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BOba50vT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QYT9SMV3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GJoWBU3841500 for ; Thu, 16 Jul 2026 20:16:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=WnSM4lxQZEs mTxwUeMg+vWDIzmfUTyWcy5ySJC3KBaU=; b=BOba50vTP5/8GNhmwJ5nFp+W5O8 8wEng31bEDk4F2kmXZ/ez6WW5b8LWVc4xRonLY60iIl5tpEyrKLcyqpcbEL5h//O z73bUO4jZUsEZMokqSQ+7kT6o1BSV4Tq1wuXFysNN+Sl4PHESnWK2QYg0Mgfgx0c 9s5sU42PleRa4z+JRMcl6znNEsZnZy1hWacgPrnP7mNWrDgxwtHFti3vliMD5VKg rpxD32jNNWn+XcoMim/DxwGnfpIvUq3LzdBVYbCEHwjHETljqdSTkN+/MchoPLOR As1pdTCqtI5nnX0Pfhkq+Vn36HpxMzzPA4cIvvEtHqz2C4dNIB+lDzoAcMA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff3u80kh0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 20:15:59 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88da04b719so3433144a12.2 for ; Thu, 16 Jul 2026 13:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784232959; x=1784837759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WnSM4lxQZEsmTxwUeMg+vWDIzmfUTyWcy5ySJC3KBaU=; b=QYT9SMV3FRjfaJSAJ0t3SAGYRcx7/fXi+vprWz+fZwkugaHNUpKNrkNhn1MHvge7cP wjhHvzOS8iTUXgyXBS0mbmiWEgjoQV6UzIPuBSlDkX6ESHN9LBOE6ytvm4W8iyYT9Cus usSalWMsD0PBNKzMLsL5dsyWlAilpDo4W4Bz23PXcT7hk8pP3CbtCzUrjdUPqgviM3I2 o7kFiPHG4w1nZVZiVWOXUfa5uHENXe2vAeBUQecrGjyjv+QhE46tpQqKiteeAA95Ws0Y s1yruKvugGhSSUHh2nEE9EG2vRrMfYfpzOO0crSKaS3ZLX/PlbPY70WSh7c/bbf9fiAj BDcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784232959; x=1784837759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WnSM4lxQZEsmTxwUeMg+vWDIzmfUTyWcy5ySJC3KBaU=; b=YreoSZskH43puY7rz5zsC1FQ3HlanE4E8+WyiZNXYUQomoI18LL/WRy7RYytbrU2ZA 7imHbMk5jdCWw2L8CISonDx7ZWgbwF6EAynVJTCxuGODUvTuNYdhwoxa2himnzFyR5oU mfPyT3WSQbTVYAFEjotPt9LdlS8V1UBT5UDg9afHHc3J0bgNc5zi88DsETviXeBsNnTF e2Mue35BUbi2d4/8yzD0wwH2akfuqcsB2V2JZ2OlWeD5phbJfaWndoM81LOXQWvdqv4C Aa6GDuvY9HoKTinlV81Q7zAoW/6ZMCOqjgiuSNAK/kBv/jyI2QZ8HqLiOCr+wzTdFI8n xxow== X-Forwarded-Encrypted: i=1; AHgh+Rq+C7v2q8kIm/GrajkNZWIDCPhxqwQDrUjI5poCGBj4BLnxQA0KDEnbXUAyD2wZ9IP8Ubm0G23G1epSZic=@vger.kernel.org X-Gm-Message-State: AOJu0YxpOHLMjjuYYir9N3jBEgXMX/d3QGr1x65w833vSYfdxK4pMovJ 5jyTnO1vT7+jwJ4gmpeMu99PdPEjTb6Ui+V8/yST8u1xZN1MwEqJCPzam76SZC0BLbkAlN/U4Pe Ru5GTnU6KntNG8JoLdfWCDZoMw+TCqcxWdfO4GsFKPnkAM1sk7D/igSiBeAJdK/MLOLM= X-Gm-Gg: AfdE7ckTPuHuJdU2IblUgQLHxGnhpUeWvAxCDVVij243rDtDRG9neTeA+Wtd5ZR2Ufw aTcHteswgDSborD+QOGpmZFIV7abRcgFbzbkg9K6RppWs/KvFU83qgW0rBv6W1kkvnGS+qKN64T W9k9B+zZeDnaaXdtGmJiB2do+hxrlMtvq+QaDiJ+WJPJ+0z2R5ttHgSPYSzd28p5mhNMIy9uO50 EkiK8bBttrEmCcFomy2IK25Ps01GctM/ThNKBV/C2CugLC5h6o2qjYjq05ayW7q0KRu4Tu9qZ3+ ZHL5l0kwRPwZHa0eprByI0JLTz3Om3R0kBaYQ4X0o8Pja7UKCyrZGtli6lIqf2yq6M9QlsORB6m ilzPI63o5rPMI9/eMayquJ6rpKP6iY8pK4/VJ6PIp61GYoog= X-Received: by 2002:a05:6a20:ae2f:b0:3c3:7481:7a03 with SMTP id adf61e73a8af0-3c3a5cf5b48mr670981637.34.1784232959072; Thu, 16 Jul 2026 13:15:59 -0700 (PDT) X-Received: by 2002:a05:6a20:ae2f:b0:3c3:7481:7a03 with SMTP id adf61e73a8af0-3c3a5cf5b48mr670951637.34.1784232958595; Thu, 16 Jul 2026 13:15:58 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb258ff4402sm2291627a12.25.2026.07.16.13.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 13:15:58 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Akhil P Oommen , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 07/10] drm/msm: Don't fallback to shared VM for VM_BIND Date: Thu, 16 Jul 2026 13:15:30 -0700 Message-ID: <20260716201538.365824-8-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> References: <20260716201538.365824-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfXwNlJ1jjocsSK Rpbt27plnPnNYJnwqvIRo74x2yTaMZ0osfUFUoZdeQaE8w4WyrEuz3DlUuc34hsqzWh5fSkAS3K qdlxKkpS3EuWiFc3EZshIU5lNkEKZwbSJhlZCzX7o/5zyzKE5DWMLtuOlMz7xC60ov58hsdW0+N 95Lx+OGeZnGFJjkFlJb8fyCJJY5bKWa+2eVzDwLQQ/a3p2KXT5fhAegJlWmJCCNSkGjznNZPcJA l26OnqwxtEkzKpxPtHku6/GK1wEYXzb39l7oWLm+OVUWcdiR+/v6VHhuVpZq6DRPneR5zZXaUWu 7GFs9KbPTt6AU1uMhofktq9gHr3+EWWv9HLFqqQ7NpcmDqFRwCD7MUfuboMFTungZtzU+bd+hZp eNo6cgUFyuvayWk6uaNs3Xx17Iq2/qgijm5t/Y33v9cIL1Nr5kLIh5ZgEWvlqQaY5E2LZ6TYgFL ase3qsv7ElXtR3/ANXQ== X-Proofpoint-ORIG-GUID: 0hsyn2pJi54AyqEiG-Z-DHIjz3ZVml3v X-Proofpoint-GUID: 0hsyn2pJi54AyqEiG-Z-DHIjz3ZVml3v X-Authority-Analysis: v=2.4 cv=VMvtWdPX c=1 sm=1 tr=0 ts=6a593bff cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=isCY8TonHXl0-fnU9HAA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDIwNiBTYWx0ZWRfX9o8oY8F3PpfG oWaBHrjnLh4cwvrANvbx/ErccF4XFVl/OIoSEeQijxM6gT++mvAby1kyzFbf1kwGK4q85ZH+qN8 mWliDj7gx72Ff7bGFngIhdjlEcP1Pcw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_07,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160206 If the user wants a userspace managed VM (EN_VM_BIND) don't silently fall back to shared VM. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 52ff72d8e17a..73d99bde26f1 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -234,7 +234,8 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx if (!ctx->vm) { vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - smp_store_release(&ctx->vm, vm); + if (!IS_ERR_OR_NULL(vm)) + smp_store_release(&ctx->vm, vm); } return ctx->vm; diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 18ed00e5f143..d02c37380414 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -875,7 +875,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct task_struct *task, to_msm_vm(vm)->pid = get_pid(task_pid(task)); } - if (IS_ERR_OR_NULL(vm)) + if (IS_ERR_OR_NULL(vm) && !kernel_managed) vm = drm_gpuvm_get(gpu->vm); return vm; -- 2.55.0