From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2CE342A14B for ; Fri, 17 Jul 2026 14:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784298038; cv=none; b=EBXmV/CkTebGaqGBszx7UckBQ5TKCJtTyI7pzKQEv61m2Rsm0Qkb7pa30cQe+99LLgFUcarX4lJ2fsvQ9BukN1imoMeI0Oyrmx2s5MWid5PBjMnQCvVsz+qcchoxfey0IkGrqxFuqkLFtVzwLuQB9G3j/xw0u2a15tt9Ra24NkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784298038; c=relaxed/simple; bh=gb4COGp5aKgcSUnq7654arLk2Ih1nEmaKpGQrdvjYOQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EeGWrnoT1+UHy3lZRKzeUKILR/nqgzCzzUaC/vcoGxZl0hlMjaM9tOHXNeB+Eaq7D729fJJvk6RPhTKgkW5V0d0FNsz0NbweRSM6BwEGayKxiJUuBBl8GJvHOvfmPXB/VDd4J5DSPKyFJNb1/2NgxUpGLGRQJjlVvsi8E7eXDIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=e7iTRbca; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RV0C6nJ3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="e7iTRbca"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RV0C6nJ3" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE7xYh1973939 for ; Fri, 17 Jul 2026 14:20:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zZ2RGRSj9aWPELXvCs6Sbk4RcyjB5HAKGztUWudcD+Y=; b=e7iTRbcaH9HXTwLD hRzvY0sRtaxy6kn5AUAYDkPB28qxq27oZYbhe3vF7AePs+WDfO5zbheS/10U8e/2 kc4bmirHFMb3F6EENU1Z+BfGMTCDT2SAvSm/XHAMX8AYtmOr9wXL76cbPt5DKLYU mdnuLJZLo6FVwqGPUqbJOKcRV3QaWvl2Cu//3aNgxaFeRzLXc2MKCdqnbJIZ6EPX cXNDfWA5RY5p63lMJXpFWN6qtph9CoyAWvFHv0Dt91bhBnXnlji3N+TLDbPHbL3J /JIFfc6El6o1o0sT7nad8wCck+gqBGqpP2SKqApJUvXWAbicW3m2OlifnLOWgqy0 d3KH+g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff2f2vk9u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 14:20:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51bff5c7035so22067981cf.2 for ; Fri, 17 Jul 2026 07:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784298031; x=1784902831; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zZ2RGRSj9aWPELXvCs6Sbk4RcyjB5HAKGztUWudcD+Y=; b=RV0C6nJ3QPXW0Cc2nv06If2I7cLwxlDVYxY8Ask2Grk1H2b1as0jZWLAEOpDW0whZ+ EttRjXw5HS29+8B7YGKkXoKiDpQFLH7fDGG3tZOsh/Ht7l2wwvFfwlyg9DaeARh+7xc5 kuYOVo0LAO/ZOOZ3PMJfPkg6pmxvGW8m8iq25mWapmPDaPDRBzxwePaoH/e9wGLJkKFz RnLDOzC4+hD1jgAmA7lCsiKzTJPh++EL8gcy7Q3b4Q+TuVnvXDiGgVeIF14xZJECymvx 7xeSJp7VOvqvEL6zDq0VwAGDimpDh2gSxwNv06qAUsBEMGQrRAKjuFFWNKWHWwxbzdrZ wp9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784298031; x=1784902831; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zZ2RGRSj9aWPELXvCs6Sbk4RcyjB5HAKGztUWudcD+Y=; b=mb3pyY78jSXLeZO2uZvo9BmvfZLTRfeq60+ilLxDIP1tL3SfbKf+ILtzMuzffn3lKL xUeaJpcVvjAmXPQbx6kQEykMxiWZHf97bVkweBOi4j20QvoncsEybhWThsf1U/mSnWKa WPu7g2ekhsf9rptRy5U0pN1v7DXrR0bGQe9MqA0XlopQAoDG9G/29rpTPG/z6ekf3RgZ NYD73gbYIz47tGIR9xikRhz9/iDL/EciXihf1zVPr4hp4/zDMUCG/X5f9Fn0kjVzF2bf lM3n+Yaxq4Ctq9RQESWOFRKFIFfkP10R1D6/YNWpdwtChTDBlncWzIgAvfmGotNqx01+ 87Sw== X-Forwarded-Encrypted: i=1; AHgh+RowqMy4sBHLZLLpx45X/jK/a7jeQ7Q4g7D/y3/IhA1Y2Fk+2J02OR565MVrQEv3fIs9BveJUlmVGFE+wTE=@vger.kernel.org X-Gm-Message-State: AOJu0YysXjPsL+sZZzU4BJtvLaSqqr4RK4l7y8V9snYkUF4M9Lh6qI0g bBjoQyBCyASJMJDa9zbypa3aOgRS5H4OFw9XmdBqaTMc0uEm7ZISKUVQ6jwLd4j0iRzEkt9EA69 4ScNodXXa5AKN8Q/qBLaT5W/lezLUTM2Z5p0xbcDAP1iurEZw/lb10L/kReTGjyiooF4= X-Gm-Gg: AfdE7ck8tP8ld2xvJM3J3y/HkS/4YGfD4Kl+SRDDR4AacgYP4LPGHCQBEsuiexgMsWH EEfcpOASUbfTAibCjSZnILZfXRhy/i2qqIGQNQX6ssrIE7p4smOgLHopMf1D6I4TYr8+HIcY2w0 G51bWsh6luwd+LzYJntkaf/E/mxQhoJkahbI1653eZUhLjvF+yWX2KEOILvPJ9DdpMrz1WRJ6ek y0c/GPjSoMJMMFk9N1a4DlFEGPTI8tssTHRZUvO5CqHZ9ppx2QxKfDzXwJik3AkyoIA7q/oQ689 5nxkdspeYXe55CwBuwk608r2CKZw9Cbt7rSlwtXZ7eJ7AfZ5QdgDinLrhZWkjWKwOQhuQcVI5F9 bWxugge1TlJQ82GbwHW1WD+Vrd6vlVon4rQRHp6In+77pM1uC3YQpM3QZFCQMniwa3zKgUqnve2 lR/YI/MmJwCJDXGMq2SZzw9RTJXODIjrosrkF+GAqhJc5lev0RHdI= X-Received: by 2002:a05:622a:251b:b0:51c:7b12:5fd8 with SMTP id d75a77b69052e-5213d3b8efbmr27897761cf.84.1784298030842; Fri, 17 Jul 2026 07:20:30 -0700 (PDT) X-Received: by 2002:a05:622a:251b:b0:51c:7b12:5fd8 with SMTP id d75a77b69052e-5213d3b8efbmr27897101cf.84.1784298030230; Fri, 17 Jul 2026 07:20:30 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:751c:d61c:c91:60dd]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1740bf91bdsm79085966b.63.2026.07.17.07.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 07:20:29 -0700 (PDT) From: Loic Poulain Date: Fri, 17 Jul 2026 16:20:23 +0200 Subject: [PATCH 4/4] media: qcom: camss: Report hardware version via media controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260717-camss-version-v1-4-7ed71fea95e8@oss.qualcomm.com> References: <20260717-camss-version-v1-0-7ed71fea95e8@oss.qualcomm.com> In-Reply-To: <20260717-camss-version-v1-0-7ed71fea95e8@oss.qualcomm.com> To: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: uX3TTsMoDXubr0KWhrEIBIz7pCERXeUT X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE0NiBTYWx0ZWRfX9qg0TMPIob34 3lO8TsZZm44yXkzUYFsT4IkSK/Nu+G6xvTerWbWzTNUlv0BJT2/o2umoGD6sb6fqZjD8KVfFGJw 5yOm9tImc8e+UxxvVmgcoc9CE7RqeyE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE0NiBTYWx0ZWRfXwQO7BZcSivDS ANcnjHGFe+mRq5jIfZiJAn1xq8/G1Frr4KG2umsexeSNPV4MBLefDzNvaqdlk3ZJORh7o3ZkrZg SlFw8XuZcQj2SmivbHu/oEZ51Vc/LGksGX2XLerETJzFMfeKYbPULJikvFiJFv7R0SlRS3rynhH 3PPMA5zA7McwTcax0+UqIlrq8tiRDOd3MNTke7CYDV4DE4V0KEWc9ViXal/PAuIqautW7F7jG5k eZ0bVwmHHtsfJBWCi+FY4AabIQtg2Vr2oiXh+bzmWoljm7Jv7fd4JdWVbrTiNmq0Lw3mWeDWn/B cLAPdiL9E/HFkTK2lq9zyjXEK1XgI6ei4U6RfQcgxxe1sFUc1VkEf7yV61/kWSPJLNlArQu8gmF /SO0AGKMytiPO+6LS0H9ovHjDS6XrBfEmNkl0AJonq/DKNA/IvqIAFy1L9yGbLGGtC1j3Y1ajti yOziff1mZC8zO6BGFwA== X-Authority-Analysis: v=2.4 cv=NcTWEWD4 c=1 sm=1 tr=0 ts=6a5a3a2f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=_VBxEyf9HguAcaXgWQEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: uX3TTsMoDXubr0KWhrEIBIz7pCERXeUT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170146 Populate media_dev.hw_revision with the top-level CAMSS hardware version so that user space can query the exact hardware variant through the media controller (e.g. via media-ctl or MEDIA_IOC_DEVICE_INFO). This can help identify the platform variant and adapt behaviour accordingly, for example allowing libcamera to apply quirks or enable features that cannot be discovered through standard V4L2 or media-controller APIs. The version register is exposed by some platforms through the top-level "top" reg region (offset 0). When present, map it and read the version once at probe. This is a no-op on platforms not mapping the region (yet). Reported media info on Agatti/CM2290 (Spectra 520): Media Driver Info: Driver name : qcom-camss Model : Qualcomm Camera Subsystem Bus info : platform:5c11000.camss Hardware revision: 0x00050200 (328192) Signed-off-by: Loic Poulain --- drivers/media/platform/qcom/camss/camss.c | 34 +++++++++++++++++++++++++++++++ drivers/media/platform/qcom/camss/camss.h | 1 + 2 files changed, 35 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 1e97b0b7ec463f1fa2615704d09ce465a8964176..2caa253fc4ad48f7f04580417d15553a710cbc6f 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -33,6 +33,9 @@ #define CAMSS_CLOCK_MARGIN_NUMERATOR 105 #define CAMSS_CLOCK_MARGIN_DENOMINATOR 100 +/* Top-level CAMSS version register */ +#define CAMSS_HW_VERSION 0x0 + static const struct parent_dev_ops vfe_parent_dev_ops; static const struct camss_subdev_resources csiphy_res_8x16[] = { @@ -4677,6 +4680,25 @@ void camss_pm_domain_off(struct camss *camss, int id) } } +static void camss_read_version(struct camss *camss) +{ + u32 hw_version; + + if (!camss->top_base || !camss->res->pm_clks[0]) + return; + + if (pm_runtime_resume_and_get(camss->dev)) + return; + + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION); + + pm_runtime_put_sync(camss->dev); + + dev_dbg(camss->dev, "CAMSS HW Version = 0x%08x\n", hw_version); + + camss->media_dev.hw_revision = hw_version; +} + static int vfe_parent_dev_ops_get(struct camss *camss, int id) { int ret = -EINVAL; @@ -4866,6 +4888,16 @@ static int camss_init_subdevices(struct camss *camss) camss->csid_wrapper_base = base; } + /* Optional top register for hardware version info */ + if (platform_get_resource_byname(pdev, IORESOURCE_MEM, "top")) { + void __iomem *base; + + base = devm_platform_ioremap_resource_byname(pdev, "top"); + if (IS_ERR(base)) + return PTR_ERR(base); + camss->top_base = base; + } + for (i = 0; i < camss->res->csid_num; i++) { ret = msm_csid_subdev_init(camss, &camss->csid[i], &res->csid_res[i], i); @@ -5454,6 +5486,8 @@ static int camss_probe(struct platform_device *pdev) if (ret) goto err_v4l2_device_unregister; + camss_read_version(camss); + ret = camss_parse_ports(camss); if (ret < 0) goto err_v4l2_device_unregister; diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h index fe5fe25d5f18d8a3ce35b48077a975f1453c341f..cce79e56f58c8bdc0097f4a1702df22c4248f2fa 100644 --- a/drivers/media/platform/qcom/camss/camss.h +++ b/drivers/media/platform/qcom/camss/camss.h @@ -133,6 +133,7 @@ struct camss { struct ispif_device *ispif; struct vfe_device *vfe; void __iomem *csid_wrapper_base; + void __iomem *top_base; atomic_t ref_count; int genpd_num; struct device *genpd; -- 2.34.1