From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570442F8EA5 for ; Fri, 17 Jul 2026 06:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271186; cv=none; b=L8VY3b1kVuDadVQhLsK6+tBzGa5z6MTyof/mQLGaJKV3LyI4RpLJHEmtyTMmzc8B3K68NCf6taLAqt6+U2P/loURr0/QKCygh1CNDiNjwGG3UyjWo6DnTF6HOlzLWrbXcXpTjhEC9lNbn34iQDmBauwiSWKORLdrf9ZELEoAyqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271186; c=relaxed/simple; bh=8yDreBcOj3amPa4T0grkPkrCECgxqVZrLGhBuaQKcWw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kPjhkt81oN36hOEcA+TT8q3CYuSIugutdGoEYu5AEuGxifwgHwMAIA9WTXqeRufoUfv63jWnEKEvCzxCUbPIYnTgCcrJCoaZUivFYV80NkPWTSOu9VCp+3Ps8CgB/tjpj8wUlEuWX/S89L9Lb88pDepAkdk5iC8b6JOBCxBTUFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bdnWq8/+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RTpvwMe+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bdnWq8/+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RTpvwMe+" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H6cQNT951334 for ; Fri, 17 Jul 2026 06:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nIDFE1Mlp6vbWKr73A4oR8KBX0Rql8MWvOli6US77bw=; b=bdnWq8/+jSH8his8 XucfSc7T6PIwiEplcLi/mmhSFCrSlnDoufv0sjmlzVcMnhFVMpwzvDCF53GZB05h /So0ox8NKDZy6V8Lrzu+4DfHUx+cI4W51Y7L0OngCvTgaf5CyaLBaNFmqe/NJXkq USmnY1pvA8BM9669dIFm1E1a8T9maAKgMUfx2M1PbUH35+m7Rygz8JCqdsVgkPDy bmSCjpm6JBPa0cW1Pns7wm1r/cm8ILlahlXpmW96+qRCprBiG3VtkX6TCl/RNvSc v+1IvkeIG3bN4vrG/LLopIUGa3YRKkIhx1jtO5CSZAsx1aHE4gnC1yjfC/vMVZ15 aSk0qw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff2f2ty00-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 06:53:03 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8486c3411c8so10276555b3a.2 for ; Thu, 16 Jul 2026 23:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784271182; x=1784875982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nIDFE1Mlp6vbWKr73A4oR8KBX0Rql8MWvOli6US77bw=; b=RTpvwMe+gT6lLPGAep+CE/yFgkfUl/VeVQnXWqHek4U2xab3yj81/H3op5WqlqgzJv 3aeG4aNqCZuem33cIopnbjo+s8hHNZDE0Z3CwqjxyoXtFYeVuUjr77HsmFGoGJ6oaNuH 6EfFK48EN0TMb4lxna9cqLRnvnmCqV+GVEEiD23r01GUiLSIAk4vDYTBzyJdnwi4XOIY comoElWTOAB3xr8R5GXvQNxjOP6iVK2X2+Qi+sz138HOc49BYy8oIUjOSyZuHW8dvunz prvWXCEYCGQ7b/txCXMjEArdVnA1LvihrajRvhzUcbROYvSSmNRKbSGJRSJJxCcqlDrp Gp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784271182; x=1784875982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nIDFE1Mlp6vbWKr73A4oR8KBX0Rql8MWvOli6US77bw=; b=esi5LVq+AJKoQuBuuZ8RWadCKboRx6efP5cJdJmq3o2c00XGOMN3xHbarQzDcj2I83 hn/nT/ghpcZMGJY+YEXJUVcAGaoZY35ujAAFkb1a8XXIKO3Nf2nO+gQxwuLHZp8ABJAR r0lADHUYbjnpfKx2PQ3GNJkDdOpya7mq2MtXwwZH3NSVxD5tc4L/wsXEULlWqi55BJla Cwmt9Wp0dpU4HtAao+27Id7zvyLcfecIt8JVR6gHi062GPZEo71O6E9mJlunO849qg7w 0uWQWgiooo1odhGLQIBdcwasbLYUaGSyRYiMVF3B3x1LaAhldWqbeWQu/mKD8AKMkumj 2YbQ== X-Forwarded-Encrypted: i=1; AHgh+RoaJ01Kh2fgGnxZS6ihNhGYWgjjfJWQF9mSQyJKCI7yk+xwxfGAjCloQkVG6kAUhYyMwJ1rNmh61226GNU=@vger.kernel.org X-Gm-Message-State: AOJu0YyJsl0LKCK24k1ApOdptCe4usvO7CvQwdEk1dPcL9eJ+A4NfIJP TOEAHtG+TFUvRQrRrJHZLfX6dPmpKt/ZGEdQg5yj13xmu0iNX2M+mgFkYN2NcUOz99oQx4C12KY PrA/4SiEcWy1AUOmm1defF6wt+ELvtnW0WwEgB+0S+btbzDVaac1Gr/71WjhLErVWgts= X-Gm-Gg: AfdE7cnXJK77fR/qKDELVPhEvWpxUzxCZ2a/XJbVv4H8yza1WhhFygyixuqPg5WuDyR wWpLGBHnvJh/mhTRyyWONPrSYPClxh0RsmPWFPPUGnpC2pjJvI795vdYVw8kpCX3eBpzEca2Gft zi391uAhcvtwbds7Dp0aT527MOr2Jc7GqO2JDki4cehYrmP8Pm6v2/GQG59wFQD4mm4G3nEgbaV iau9rNme2nWvwEYWO09r7QhYx7DZpODWmzHhOC/1ZVvGgJfuiIB4EtmIVMkNm7Sd+xAMpQ3PTFJ uTVC/5O+rTpdh3zXitI2P1lPQ7LU2BvCssCNzMOreRrqT4Fbp1URYTJtF7jM74G8qxlAfn93M+u KfsM5tMXhieWwfZ6LOHt/hWLkl5fyd2Q= X-Received: by 2002:a05:6a00:2f97:b0:847:8704:1c48 with SMTP id d2e1a72fcca58-84c292ac4d3mr870304b3a.20.1784271182058; Thu, 16 Jul 2026 23:53:02 -0700 (PDT) X-Received: by 2002:a05:6a00:2f97:b0:847:8704:1c48 with SMTP id d2e1a72fcca58-84c292ac4d3mr870174b3a.20.1784271178004; Thu, 16 Jul 2026 23:52:58 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2adc3466sm437651b3a.15.2026.07.16.23.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 23:52:57 -0700 (PDT) From: Sachin Kumar Garg Date: Fri, 17 Jul 2026 12:21:45 +0530 Subject: [PATCH v2 2/2] media: iris: add support for multi_slice in iris encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260717-iris_multi_slice-v2-2-9550b1feb39b@oss.qualcomm.com> References: <20260717-iris_multi_slice-v2-0-9550b1feb39b@oss.qualcomm.com> In-Reply-To: <20260717-iris_multi_slice-v2-0-9550b1feb39b@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784271167; l=11814; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=8yDreBcOj3amPa4T0grkPkrCECgxqVZrLGhBuaQKcWw=; b=LL5LIVcfHYfnWkxStiyNjmd5dpFL6XKCL9D+oXNhFDSflAG29nEMqGSQwK6LYtsqmzmjNU+MA /cwxh3ugnwuDKG3D/xO8mtP3lxvMOEDTTOlTqMoaz09bbM0dLuYtqBn X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: 7H216Kup4kkOvEmHAhhJZ6vEurh3frYu X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDA2NyBTYWx0ZWRfXyJPdg2skCmL0 m698xU3oJ8uBzlZEycH3KDeO1L8FBqpi7zkDwxQBG0zLhVnbQsHuDdEnsCu8dCYVPhQHymGBZCd /hopyoo5EBOkFkNKvP+rl+/tdpfnbnI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDA2NyBTYWx0ZWRfX3wTvhrbod7qW br+LP2A7MizItc7wuvPM5dt9w0Q45GOa+GVCfwq87Yaj5zJYXDTG8f3vaRU/6kFxr6oeb/w5Za5 y1FWi6TCMoOc+7YKPq0LlG7dFpUzXfK7HTEDbm4iPQ8dECKXHWix1O+dWgw5vQOl4ACFyEESKtP anvob3f+AM+0/QW9rXE8IRDF+fZdF2X1GNrxLbTmDccnzfGOF0YKuIjQ7+xUkxI2TtPYf1xgQfY cTunCw9toql199Kpbk2xK1W/uMo6JTaet/sNyEvSDlUebSff0iP/SaO7sh02KynCx9Z3X4DNjvC m970+2tiLWplleX4/IVJ2/lYaECs1DAgx+jpJpFe06VdA3gBqK4o+Yeq2lq8M2wXODkqDLN6GL6 /nkM6yZNFsQSwNyG6mH0TaLnx2/csWBiUrTmF2yC0d6CZaXNhDbJ0rX2OHcUsKtDB4nMS+8eUCl 2dm85scBpTtIkL6vHqQ== X-Authority-Analysis: v=2.4 cv=NcTWEWD4 c=1 sm=1 tr=0 ts=6a59d14f cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=57x6y-xoAtUlfagzgEwA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: 7H216Kup4kkOvEmHAhhJZ6vEurh3frYu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170067 Add multi-slice encoding support with MAX_MB and MAX_BYTES modes. Clients can enable slice mode using V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control and configure slice size via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB or V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES controls. Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 81 ++++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 33 ++++++++- .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 12 ++++ .../platform/qcom/iris/iris_platform_qcs8300.h | 9 +++ .../platform/qcom/iris/iris_platform_sm8550.h | 9 +++ .../media/platform/qcom/iris/iris_platform_vpu2.c | 9 +++ 8 files changed, 155 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 6c4eed62d7e3..3f8b869ab87d 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -154,6 +154,12 @@ static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id) return LAYER4_BITRATE_HEVC; case V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR: return LAYER5_BITRATE_HEVC; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE: + return SLICE_MODE; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES: + return SLICE_MAX_BYTES; + case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB: + return SLICE_MAX_MB; default: return INST_FW_CAP_MAX; } @@ -297,6 +303,12 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id) return V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_BR; case LAYER5_BITRATE_HEVC: return V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_BR; + case SLICE_MODE: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE; + case SLICE_MAX_BYTES: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES; + case SLICE_MAX_MB: + return V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB; default: return 0; } @@ -1480,6 +1492,75 @@ int iris_set_layer_bitrate(struct iris_inst *inst, enum platform_inst_fw_cap_typ &bitrate, sizeof(u32)); } +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) +{ + const struct iris_hfi_session_ops *hfi_ops = inst->hfi_session_ops; + struct platform_inst_caps *caps = inst->core->iris_platform_data->inst_caps; + u32 slice_mode = inst->fw_caps[SLICE_MODE].value; + u32 bitrate = inst->fw_caps[BITRATE].value; + u32 rc_type = inst->fw_caps[BITRATE_MODE].value; + u32 fps = inst->frame_rate; + u32 output_width = inst->fmt_dst->fmt.pix_mp.width; + u32 output_height = inst->fmt_dst->fmt.pix_mp.height; + u32 mbpf = NUM_MBS_PER_FRAME(output_height, output_width); + u32 max_width, max_height, min_width, min_height; + u32 max_avg_slicesize, hfi_value, hfi_id; + + if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) { + dev_dbg(inst->core->dev, "slice mode is: %u, ignore setting to fw\n", slice_mode); + return 0; + } + if (!fps) { + dev_err(inst->core->dev, "Invalid frame rate %d\n", fps); + return -EINVAL; + } + if (fps > caps->max_slice_frame_rate || + (rc_type != HFI_RC_OFF && rc_type != HFI_RC_CBR_CFR && + rc_type != HFI_RC_CBR_VFR && rc_type != HFI_RC_VBR_CFR)) { + dev_err(inst->core->dev, "slice unsupported, fps: %u, rc_type: %#x\n", + fps, rc_type); + return -EINVAL; + } + + max_width = (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) ? + caps->max_mb_slice_width : caps->max_bytes_slice_width; + max_height = (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) ? + caps->max_mb_slice_height : caps->max_bytes_slice_height; + min_width = (inst->codec == V4L2_PIX_FMT_HEVC) ? + caps->min_hevc_slice_width : caps->min_avc_slice_width; + min_height = caps->min_slice_height; + + if (output_width < min_width || output_height < min_height || + output_width > max_width || output_height > max_height) { + dev_err(inst->core->dev, "slice unsupported, codec: %#x wxh: [%dx%d]\n", + inst->codec, output_width, output_height); + return -EINVAL; + } + + if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) { + hfi_value = inst->fw_caps[SLICE_MAX_MB].value; + hfi_value = max(hfi_value, mbpf / caps->max_slices_per_frame); + if (inst->codec == V4L2_PIX_FMT_HEVC) + hfi_value = (hfi_value + 3) / 4; + hfi_id = inst->fw_caps[SLICE_MAX_MB].hfi_id; + } else if (slice_mode == V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES) { + hfi_value = inst->fw_caps[SLICE_MAX_BYTES].value; + if (rc_type != HFI_RC_OFF) { + max_avg_slicesize = ((bitrate / fps) / 8) / caps->max_slices_per_frame; + hfi_value = max(hfi_value, max_avg_slicesize); + } + hfi_id = inst->fw_caps[SLICE_MAX_BYTES].hfi_id; + } else { + return -EINVAL; + } + + return hfi_ops->session_set_property(inst, hfi_id, + HFI_HOST_FLAGS_NONE, + iris_get_port_info(inst, cap_id), + HFI_PAYLOAD_U32, + &hfi_value, sizeof(u32)); +} + int iris_set_properties(struct iris_inst *inst, u32 plane) { const struct iris_hfi_session_ops *hfi_ops = inst->hfi_session_ops; diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.h b/drivers/media/platform/qcom/iris/iris_ctrls.h index 3c462ec9190b..5a73c7c49d36 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.h +++ b/drivers/media/platform/qcom/iris/iris_ctrls.h @@ -47,6 +47,7 @@ int iris_set_layer_type(struct iris_inst *inst, enum platform_inst_fw_cap_type c int iris_set_layer_count_gen1(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_layer_count_gen2(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_layer_bitrate(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); +int iris_set_slice_count(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id); int iris_set_properties(struct iris_inst *inst, u32 plane); #endif diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c index acc0ed8adda1..fcbebced05c3 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2.c @@ -12,6 +12,8 @@ #define VIDEO_ARCH_LX 1 #define BITRATE_MAX 245000000 +#define MAX_SLICE_MB_SIZE \ + (((4096 + 15) >> 4) * ((2160 + 15) >> 4)) static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = { { @@ -937,7 +939,36 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_enc[] = { .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, .set = iris_set_layer_bitrate, - } + }, + { + .cap_id = SLICE_MODE, + .min = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .max = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES, + .step_or_mask = BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_MB) | + BIT(V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_MAX_BYTES), + .value = V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE, + .flags = CAP_FLAG_OUTPUT_PORT | CAP_FLAG_MENU, + .set = iris_set_slice_count, + }, + { + .cap_id = SLICE_MAX_BYTES, + .min = 512, + .max = BITRATE_MAX >> 3, + .step_or_mask = 1, + .value = 512, + .hfi_id = HFI_PROP_MULTI_SLICE_BYTES_COUNT, + .flags = CAP_FLAG_OUTPUT_PORT, + }, + { + .cap_id = SLICE_MAX_MB, + .min = 1, + .max = MAX_SLICE_MB_SIZE, + .step_or_mask = 1, + .value = 1, + .hfi_id = HFI_PROP_MULTI_SLICE_MB_COUNT, + .flags = CAP_FLAG_OUTPUT_PORT, + }, }; static const u32 sm8550_vdec_input_config_params_default[] = { diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h index 776b21cd11b2..226894b99dcc 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h @@ -71,6 +71,8 @@ enum hfi_rate_control { #define HFI_PROP_MIN_QP_PACKED 0x0300012f #define HFI_PROP_MAX_QP_PACKED 0x03000130 #define HFI_PROP_IR_RANDOM_PERIOD 0x03000131 +#define HFI_PROP_MULTI_SLICE_MB_COUNT 0x03000132 +#define HFI_PROP_MULTI_SLICE_BYTES_COUNT 0x03000133 #define HFI_PROP_LTR_COUNT 0x03000134 #define HFI_PROP_LTR_MARK 0x03000135 #define HFI_PROP_LTR_USE 0x03000136 diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index c9256f2323dc..659d15166365 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -100,6 +100,15 @@ struct platform_inst_caps { u32 mb_cycles_fw_vpp; u32 max_frame_rate; u32 max_operating_rate; + u32 max_slices_per_frame; + u32 max_slice_frame_rate; + u32 max_mb_slice_width; + u32 max_mb_slice_height; + u32 max_bytes_slice_width; + u32 max_bytes_slice_height; + u32 min_hevc_slice_width; + u32 min_avc_slice_width; + u32 min_slice_height; }; enum platform_inst_fw_cap_type { @@ -183,6 +192,9 @@ enum platform_inst_fw_cap_type { LAYER3_BITRATE_HEVC, LAYER4_BITRATE_HEVC, LAYER5_BITRATE_HEVC, + SLICE_MODE, + SLICE_MAX_BYTES, + SLICE_MAX_MB, INST_FW_CAP_MAX, }; diff --git a/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h b/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h index 3cfecae80d1e..764acf71c72b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h +++ b/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h @@ -17,6 +17,15 @@ static struct platform_inst_caps platform_inst_cap_qcs8300 = { .mb_cycles_fw_vpp = 44156, .max_frame_rate = MAXIMUM_FPS, .max_operating_rate = MAXIMUM_FPS, + .max_slices_per_frame = 128, + .max_slice_frame_rate = 60, + .max_mb_slice_width = 4096, + .max_mb_slice_height = 2160, + .max_bytes_slice_width = 1920, + .max_bytes_slice_height = 1088, + .min_hevc_slice_width = 384, + .min_avc_slice_width = 192, + .min_slice_height = 128, }; #endif diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.h b/drivers/media/platform/qcom/iris/iris_platform_sm8550.h index 3c9dae995bb2..ef87976c2360 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.h +++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.h @@ -25,6 +25,15 @@ static struct platform_inst_caps platform_inst_cap_sm8550 = { .mb_cycles_fw_vpp = 66234, .max_frame_rate = MAXIMUM_FPS, .max_operating_rate = MAXIMUM_FPS, + .max_slices_per_frame = 128, + .max_slice_frame_rate = 60, + .max_mb_slice_width = 4096, + .max_mb_slice_height = 2160, + .max_bytes_slice_width = 1920, + .max_bytes_slice_height = 1088, + .min_hevc_slice_width = 384, + .min_avc_slice_width = 192, + .min_slice_height = 128, }; #endif diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c index 6e06a32822bb..39720e7af889 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c @@ -44,6 +44,15 @@ static struct platform_inst_caps platform_inst_cap_vpu2 = { .mb_cycles_vpp = 200, .max_frame_rate = MAXIMUM_FPS, .max_operating_rate = MAXIMUM_FPS, + .max_slices_per_frame = 128, + .max_slice_frame_rate = 60, + .max_mb_slice_width = 4096, + .max_mb_slice_height = 2160, + .max_bytes_slice_width = 1920, + .max_bytes_slice_height = 1088, + .min_hevc_slice_width = 384, + .min_avc_slice_width = 192, + .min_slice_height = 128, }; static const struct icc_info iris_icc_info_vpu2[] = { -- 2.34.1