From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 957813F8881 for ; Fri, 17 Jul 2026 15:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784303642; cv=none; b=fjD726oQC8fNaK/PnDdXixXUln2t8YQbI9RBq5aQO7GYK0mYzTjwG689un9vpFbJLQ45euvKTANKBU9b/Ucz+hxiisjZahzB5Sgg2kGJTI1yCfh0CpqakzpcE+FlO5J6IG9MidcOmD3ui3E95pNFNoPluwyEdhw9WDbqho2lI3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784303642; c=relaxed/simple; bh=c+mrubN7rsfOnXUrhAmKfIPiEiFtp1qvBtE3BukFaZ8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R+fqMLO0Ajrn9V+5a2qIOdvwxq1EWCWvnJxxTlFJEFeWHlaSISjLRwbhoVmDkgOKoyZcWc4ufC1KMW+GKZWXwXVt5aZaiczqB9FHOMTu7QjafUPmumTogQbZmNLVG039B25tDVQ91I3BJaysnhesgHt6Fgbqd0c29pXu0ycwBv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CZ6a34Wi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UIbUebNl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CZ6a34Wi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UIbUebNl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE7oT21838832 for ; Fri, 17 Jul 2026 15:53:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= su379PS4fCpra/SUatLozY865KIfA6SXq4/i5am3Thg=; b=CZ6a34WiUw/WrrZ1 N61tgxau6FXPk/q7pIv+pdg8r0hthARXrJURahnhsibXj26LmowiSJ0By71s8Th7 jfOHtCL05JXqaP6lAK+JekQ73R37CQoNF10yRJtgp4WnoKMkaobF2H5k6iC3iQ/o zET6TppVxmqlh87vB2T2qwhSh5ZNkkU++kE3iN152IP/aoiIHq73TsqUsNvDDOhz JHMwPM9sigvU96np1ZbbbHQWyU+ASHWWeRqtAUibDq55cPdFO/TcYpKuyRjwMHK6 1e51lF1KPgKb9T7BJXZJrtHb0Y05+YOKaR8wxbL8tEv9QgNBNabmnGnhPPwqH04o 7GkVLg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fffaga24r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 15:53:59 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c07f25de2so64253621cf.3 for ; Fri, 17 Jul 2026 08:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784303638; x=1784908438; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=su379PS4fCpra/SUatLozY865KIfA6SXq4/i5am3Thg=; b=UIbUebNlQefJcJWmZDCaOSKYNIUdCDJ7Mop5xvkvdrsZmEgjqGLfndJXHnf2jgq+JX mhr7SRtbI7DYfqvrydypPt9IBa2RoPA77zhjYfU3oEqkHStXE9SxeINCtHReVJX20mA5 1c5Q8GHWlXLQWsn29scV5/sZeWxf+pLVFN12j0PbYTo3SjvcpKVxD4s3OFO9v+ZtONcN iGVBmCtFt1URaZ81hizdV1RgOknRd7HLAkQHfzY9t9Pb0o3hHPQ+UL9MIlLdhtEPYnDb sIiiNw4mY/d4vj6wmCvOFfc3zFDUfab0yUHkDjJVHaU4wGd/OjHuwqiJhTeHSI6fo74B 22+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784303638; x=1784908438; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=su379PS4fCpra/SUatLozY865KIfA6SXq4/i5am3Thg=; b=I9+61nN9+U2V6lhsoBi3N6NGRDJPJJqYvoY4FQx7p+QhHbT6CUM4/+xMgs55HoRwSD VEG+g22zLOkvId2UK3tv3dsEECLuQUp+XQEPIOh1EygZKRc6s0efg2zCINJ2E3R5mF+c eih7z0yMZJWpT4GilM8SkbeOmSjd6RKpyDT5VW2Nepc1WC7BJtcyVk+7F5cLOKZJviG8 XNpSrmtY1OPUGg5LEWlNjpxFle3aJ9Le55bjSNQZErAcZkTa46PFf1CuSEarYrNa2Gcq 4dvE+Tu9GCAH86xzySOpjdy22TN6jE+153Pim20kGj4Wjn5KNWtdIadDf2x0lw+YAENT FjzA== X-Forwarded-Encrypted: i=1; AHgh+RoFw58yv6aDMo4SOyCsKPfrAqPwv+0QbcRN8LnPUqTuOR7DLeLc0lGrKalD+2hD/W7b/X0A8WuW58VFhSE=@vger.kernel.org X-Gm-Message-State: AOJu0YzWmH5cc0rUU4WJlISgb+0Q7tpDlUwbLRTOpiIdIQ2NSygtOqho B1DCwYQ0jw2RTVQSxAO+bEqfzthbqnB9HIyDmnaswYjM/5OHzslHPyZz8dWAefMCqlI5vy7Ez7k 6UGDni23OGV7FIYFjWt2qzn8cMfaMB2srPz9bzhX6yYfLD1lrthBkLiyxmoMykdAQWUYnUHyflJ s= X-Gm-Gg: AfdE7cleUIkLdhbetT38aw2Swe9+n8BqRcD/1sXT/GNDLyCuhoumRFh7R1N0GZfBSHT 0l7WFG+EeI4G5yaHp0O89spqVFW7Vyv+Bxteivb9mpiLyxdJPIPQuaCvzTvQYm3AW9fR39c+e9+ gAur8o13waBuWCKNJK0E4bKQ24wmIULqzrdjynxcgmY1cBYGjl4idc/XbVaDfMP5upxQQ/zv1le /w7aUCnvJGDgxC1cLKTRh5gR6ZJWH78r+7t7u955RfeWFIEL0C8rg15uI0PFeGi5uI8oZLQv6Kr 6xHQENEhXTQK8FG0Bf3VwLAeREjuTTvBucZFXGTfZsInnyGgBJcdD5MQd/O1adr8jaAsrXSDnrf Ey9Eg4VK9cqf+1k/xS189NB6m0f6wBw== X-Received: by 2002:a05:622a:c08:b0:51b:fcb4:7576 with SMTP id d75a77b69052e-5213aa6e50cmr27491131cf.15.1784303638580; Fri, 17 Jul 2026 08:53:58 -0700 (PDT) X-Received: by 2002:a05:622a:c08:b0:51b:fcb4:7576 with SMTP id d75a77b69052e-5213aa6e50cmr27490921cf.15.1784303638195; Fri, 17 Jul 2026 08:53:58 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:dc44:5b1b:5396:79d6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2a2511sm47057095e9.1.2026.07.17.08.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 08:53:57 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 17 Jul 2026 17:53:31 +0200 Subject: [PATCH v6 2/8] crypto: qce - Reject empty messages for AES-XTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260717-qce-fix-self-tests-v6-2-455775fe5f6c@oss.qualcomm.com> References: <20260717-qce-fix-self-tests-v6-0-455775fe5f6c@oss.qualcomm.com> In-Reply-To: <20260717-qce-fix-self-tests-v6-0-455775fe5f6c@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1491; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=c+mrubN7rsfOnXUrhAmKfIPiEiFtp1qvBtE3BukFaZ8=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqWlAJLk8kf+WO4QPge6zzsH6iLkYm/a4I6uEUB rNcxsO73RiJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCalpQCQAKCRAFnS7L/zaE w08EEACNbC6vHABktCcrqSfMiYaJc6A+6pG66OGWUFdrHM7aOGe2iQwkorloHgWFT5SCmPQoQQe 3Yiqy1+ewkNYT3hUZIIc/5TB252yq6PL92CZGpNLDB3jyR3OX/m2XU16Dg1jkrDhEyUuq3BbfR1 Iv2oOUkByizuoYqiMcJjwIk4kbKwKJ1Mr3PEakYaNNCiePr4NhR7Is7gsjF9Li4muP5BsaaK5B0 gp6n5ty2GyW7HFEI1Fi16TLsk/yhgoR6OFrNiMz5eXrUw5S/k9CpzjS7CnjcJQ9io0c9Yh8QU/U wpGjSFGU37L/2dfozPJc+cUKOB7ZfgEivyeyH1Znua7szBunnLROQI3TWTrV2oQU18kbMt+EyIU 48NS9NgZAStB1xiAQgtbe1ElOj9evZ76TqRPVdZuiaJ70lR5/AZ9T1kNjWyPk017x8YI8ce/3Rq Ezxk0FZU96CzWaEo7QgoCMYRI73WqO2lZB0rLGuqEt2UdWqFUjKD4t2pc9tJoQ24+HD0TWVF+b2 OPlK7cy8skUC9DR0vg5+uKTwaTC/BFM2CP1qhkJIDAVU+RFbsnx52wgt0ktXlmqUIF5Tr1cP4+v n+KwYRFbxSdXFAXFUGoxACXWUNWVv7c8aakCie2VZxZUQn+QprmhyUgTuiU7w6E4U4PLM/fjuct VGupaDD8FkAt9kQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE2MiBTYWx0ZWRfXwJbSYE156Rzi 3lYj5Cmdj526P43HrYQ9ynOerqyt4/C38gDKuWZEBj+P0yLgsfHEST1NidvkFG3CzAFx8oUO4eZ 8kaMPWtffvlMmr32GBLizMMveij7XBg7A6vwI7E6MWna90mMZN2xgpQDTu7V7NoTHWcpUWU9kgu LH+VrKHl15Ywk9cwdRPhoVACQ6tSzmKp53QElivkX4Fvxow9fMfGK44Cd9DpnsksZTfAELyCAhD fWR3jNSdCBfFQGvNCBW5juwAjbDsefbp3CsfQX9TSh1oEMcoAml+HAZMOpP9sQdcyz5xfAcH9aO iXH/hw3YF+Doh9PdcYzbW902IiKdYaWkBgGQ3+4T5XJ+GJ3j/w6Zh8VW07B0PJ6kAqAOt3wGOEa mcyuTzfHLqgyNj2oVz24XyRELX3HL6Yqm+Atlx/OTSbKOJ7ncLEjeCD8YGROU4vGeVTPeMcUFnC 6tJCpYGkpofMHw+iydA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE2MiBTYWx0ZWRfXxSbLsYAd/2Tb OhgZP0QnihuETw7j7bfznHm2dbrqSkFgl219N5t06Epffw1cRg0j1epAo3inynCFauxYw6YShyZ twZXVsxqYHW7LVBPYUFdmW+OiZgN4Jg= X-Authority-Analysis: v=2.4 cv=KZfidwYD c=1 sm=1 tr=0 ts=6a5a5017 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=kiYxeA6Iecqc4QeK3QQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: ID5VdX2yHzZ0oJ0-JKy1C3RpmFJ3q1J9 X-Proofpoint-ORIG-GUID: ID5VdX2yHzZ0oJ0-JKy1C3RpmFJ3q1J9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170162 XTS is not defined for an empty plaintext: it requires at least one full block of data. The driver treated a zero-length request as a successful no-op, so the crypto self-tests "unexpectedly succeeded" when -EINVAL was expected. Return -EINVAL for empty XTS requests while keeping the no-op behavior for the other ciphers, which the crypto engine simply cannot process due to its DMA not supporting zero-length transfers. Cc: stable@vger.kernel.org Fixes: f08789462255 ("crypto: qce - Return error for zero length messages") Tested-by: Kuldeep Singh Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index b27008ace93a8a40c291d564c3fb9d73df5447ec..e1f69057607fac36e8b4bdb5dd9e62a2aabe5f50 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -223,8 +223,12 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; /* CE does not handle 0 length messages */ - if (!req->cryptlen) + if (!req->cryptlen) { + /* XTS requires at least one full block of data */ + if (IS_XTS(rctx->flags)) + return -EINVAL; return 0; + } /* * ECB and CBC algorithms require message lengths to be -- 2.47.3