From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F34F3D955B for ; Fri, 17 Jul 2026 07:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271986; cv=none; b=GiUznA3nPa+8OleQYLt9nXImwQA2v2dVVXdDq/Oy+IIbtP3yV7Rl8xiJg3LSPPtk0iTSwXKPmDSVWJ0vq1Vu9ozxPtqgBuHP/lEP1Fh6Z6HonPtfuHIJnPylu76Sh7JdmamhhTNH6tuPf8cWHIfQ2Qprkl9NmavqGnGo1e9v5Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784271986; c=relaxed/simple; bh=3d+U5BxP8GFfkZa3tznME4j9DaN9aInz1BWWs2tEgR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QK8W6LrxP7ZyptSLCnKFCOOZCUOJm6BL3Ywu+3ZcEo75/Tcs+DMaM28RIRVPHoow8KIO2MxhbRYtuzYT4mFmP6gxIix50wPwRughLmxdxdhfZE8W1rX4sPu1syPiybDuKXwFuYom7GncyDx7G1g0AswDC6TDTQfPZNjRoIy34B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iSw9Oy1V; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iSw9Oy1V" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so6557351f8f.1 for ; Fri, 17 Jul 2026 00:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784271982; x=1784876782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BOdo7TJO/G0vwAKTbM1CqLhpNvaQUJdtcHZEWHaov1o=; b=iSw9Oy1VuRYW332gCNVxVTCMf2MSl3mrxBVsLPc0PfoJehtuqUfyeQ9xqd9FNJrq76 rHsww5qF4DMD0rbo5x9laJlPZpKSnhf7L4k/GmNXFeh4Emm6Qqlp9+nYQ2jLlLnbSueg Ka1GRzHpW+cILEipaVqI7PVORe7Br0j53CHN0V8nUnYIKnLNsEfMtdjE5NoZftp4RL/d 1a7HZR9tEUHd4Lh9e58PvWeIGz+j4NfwxYUYtGWt8etNs0Vh1YK44XCWaFkEoDAqAXQ/ 9hnVybocLaCexzKIpNAMfbO1aU5l+shkLR8Io1JQAEiqoCv1eQep3JmOSRNWOUrJb6fW 4mnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784271982; x=1784876782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BOdo7TJO/G0vwAKTbM1CqLhpNvaQUJdtcHZEWHaov1o=; b=k9t78uLAonIiqVLJWvzAVWXWLcbj4k0zCxg43kkrewV+WEzNMqF+HiAjHiVca5Tamx 0QEj9VKlfQTmcpxvR1XGIs4EqW9WYC2W6C3HPbZyopvlHOw99Svd5oUcRwEUgm+1HJ4O OnVYmekwUW+648NPgtnSs8NCDs1YiCdUTE0txK/1pWkN8+CxTdYZff0qNPp7x6kyypCA 4tKZs6LYaIQrj6a+0FpIqgzQf58TzOmTmyvQ3cIPXu5c+dVMJOyEPbDsmB0e4X7Hn0Tq GA7ASzqvG5Pc209Z+1S8Ml/TRrhn/99o3NlhjH9hpkBaQYUhVpkSR8/ISgTmasoQaZrO K+tg== X-Forwarded-Encrypted: i=1; AHgh+RrNfLs3sM9ThjTc+W2JUDqbn+HP8tlYa5NGuWBzwQpO4M1XWi+mTJRGpX012xF+q6STM8WMbzlhSRNAyqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxKH0hUZnd98d2lvfKIOPHu/5OwVzndYtuXDRcCRdn3k1xljOmP bycMFDEGG3k+VG9e8p31pYqtChw8C8mKsXL3T9+LndMxEIKhBMwktoU0 X-Gm-Gg: AfdE7cnApo1IKyTX4QdWq245x9a+YiQkb0BWi5TSi3tKPz03r6dntlOdABA8yCOncXy 96CzSBaff6roSBWd1S56Xrjw7VcCmQ2zSA/+y9MRFZlDT6uwYq/9IqQI/4CTG3HKsceSwpsFu8R EVI8UYU9D8HeXFVs+JoPaJiFl5Q1GpW9ni8JRdchI3NGPhMTPOeZCvyhAqB8wW69OXwBUAKTU28 9tt5+qCoNIhkNUpsR42nSOlQaWtcyWeUgtcogkRxdCKmmwmIF0fJo7nMkhPvEoauHEy7JkGZDLo gbVrP4TavBq0mSZb1SKYeSzxqrbO22cNdTiQnB/tbTbhPx3W9X/y7mlMrUvcjU4G6fi3fHz/cL0 1fEmuQsqInsCNyJsu18M/7VLJdN6eqB6UkNWWMIaITy/RBqLR9r1fr1ZyN9QWORxfWZq8Qz9aPK gifUN6YR2ElrZZabiegaY+1MjU15andlK3fHxWQpfm6Z2rumjat7yBppg= X-Received: by 2002:a5d:5f54:0:b0:461:e27d:5690 with SMTP id ffacd0b85a97d-47f6230b5e8mr1726666f8f.26.1784271981556; Fri, 17 Jul 2026 00:06:21 -0700 (PDT) Received: from flaviu-Aspire-E5-572G.. ([93.122.248.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63dc25basm1522326f8f.0.2026.07.17.00.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 00:06:21 -0700 (PDT) From: Flaviu Nistor To: Guenter Roeck , Jean Delvare Cc: Flaviu Nistor , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] hwmon: (lm90) Switch channel parsing to fwnode APIs Date: Fri, 17 Jul 2026 10:06:14 +0300 Message-ID: <20260717070614.6492-1-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717064947.824201F000E9@smtp.kernel.org> References: <20260717064947.824201F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 17 Jul 2026 09:49, sashiko-bot wrote: >Thank you for your contribution! Sashiko AI review found 2 potential issue(= >s) to consider: > >New issues: >- [Low] Incompatible pointer type causing build failure > >Pre-existing issues: >- [Critical] Sysfs read triggers NULL pointer dereference via uninitialized= > hwmon_dev >-- > >--- Patch [1]: [PATCH v2] hwmon: (lm90) Switch channel parsing to fwnode AP= >Is --- >commit 3d5d792e5529b3545ccefc21f7dfd9c2acecc999 >Author: Flaviu Nistor > >hwmon: (lm90) Switch channel parsing to fwnode APIs > =20 >This commit replaces OF property handling with fwnode APIs in the probe >function to read channel properties. This improves compatibility by no long= >er >limiting it to Device Tree. > >Link: https://lore.kernel.org/all/20260713190659.4511-1-flaviu.nistor@gmail= >.com/ > >> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c >> index 4b9c0ccdf2609..7d4b8e61bec51 100644 >> --- a/drivers/hwmon/lm90.c >> +++ b/drivers/hwmon/lm90.c >[ ... ] >> @@ -2701,27 +2701,27 @@ static int lm90_probe_channel_from_dt(struct i2c_= >client *client, >[ ... ] >> -=09err =3D of_property_read_s32(child, "temperature-offset-millicelsius"= >>, &val); >> +=09err =3D fwnode_property_read_u32(child, "temperature-offset-millicels= >ius", &val); > >[Severity: Low] >Will this cause a build failure or compiler warning? > >In lm90_probe_channel(), val is declared as an s32, but it is being passed >to fwnode_property_read_u32() which expects a u32 pointer. This pointer typ= >e >mismatch can trigger a -Wincompatible-pointer-types error in modern builds. This is absolutely true and I can't understand how this got into the patch since I have test is. I will send a v3 correcting s32 to u32. Sorry for this! Best regards, Flaviu