From: Pan Chuang <panchuang@vivo.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe()
Date: Fri, 17 Jul 2026 18:58:45 +0800 [thread overview]
Message-ID: <20260717105847.131359-4-panchuang@vivo.com> (raw)
In-Reply-To: <20260717105847.131359-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 2e2526e01d58..261ec2ee63ef 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1414,7 +1414,7 @@ static int intel_gpio_probe(struct intel_pinctrl *pctrl, int irq)
IRQF_SHARED | IRQF_NO_THREAD,
dev_name(pctrl->dev), pctrl);
if (ret)
- return dev_err_probe(pctrl->dev, ret, "failed to request interrupt\n");
+ return ret;
/* Setup IRQ chip */
girq = &pctrl->chip.irq;
--
2.34.1
next prev parent reply other threads:[~2026-07-17 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 10:58 [PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 10:58 ` [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err() Pan Chuang
2026-07-17 10:58 ` [PATCH 2/4] pinctrl: bcm: " Pan Chuang
2026-07-17 10:58 ` Pan Chuang [this message]
2026-07-17 16:58 ` [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe() Andy Shevchenko
2026-07-17 10:58 ` [PATCH 4/4] pinctrl: Remove redundant dev_err()/dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717105847.131359-4-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=andy@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox