mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	John Stultz <jstultz@google.com>, <linux-kernel@vger.kernel.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Valentin Schneider <vschneid@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	Qais Yousef <qyousef@layalina.io>,
	Zimuzo Ezeozue <zezeozue@google.com>,
	Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
	Boqun Feng <boqun.feng@gmail.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Metin Kaya <Metin.Kaya@arm.com>,
	Xuewen Yan <xuewen.yan94@gmail.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	Suleiman Souhlal <suleiman@google.com>,
	kuyo chang <kuyo.chang@mediatek.com>, hupu <hupu.gm@gmail.com>,
	Vasily Gorbik <gor@linux.ibm.com>, <kernel-team@android.com>
Subject: [RFC PATCH 1/3] sched/core: Track the core-wide pick leader
Date: Fri, 17 Jul 2026 11:15:59 +0000	[thread overview]
Message-ID: <20260717111601.6017-2-kprateek.nayak@amd.com> (raw)
In-Reply-To: <20260717111601.6017-1-kprateek.nayak@amd.com>

Track the rq whose task is dictating the core-wide cookie. If no
core-cookie is set (!needs_sync), every rq on the core is considered a
pick leader as it can individually try to dictate a core cookie later.

This detail will be used in subsequent commits to extend proxy execution
to remain compatible with core scheduling.

No functional changes intended.

Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
---
 kernel/sched/core.c  | 11 +++++++++--
 kernel/sched/sched.h |  3 +++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 25851bb5489d..31fa6bcee616 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6649,9 +6649,9 @@ pick_next_task(struct rq *rq, struct rq_flags *rf)
 	const struct cpumask *smt_mask;
 	bool fi_before = false;
 	bool core_clock_updated = (rq == rq->core);
+	struct rq *rq_i, *rq_max;
 	unsigned long cookie;
 	int i, cpu, occ = 0;
-	struct rq *rq_i;
 	bool need_sync;
 
 	if (!sched_core_enabled(rq))
@@ -6668,6 +6668,7 @@ pick_next_task(struct rq *rq, struct rq_flags *rf)
 		 */
 		rq->core_pick = NULL;
 		rq->core_dl_server = NULL;
+		rq->core_pick_leader = true;
 		return __pick_next_task(rq, rf);
 	}
 
@@ -6737,6 +6738,7 @@ pick_next_task(struct rq *rq, struct rq_flags *rf)
 		if (!next->core_cookie) {
 			rq->core_pick = NULL;
 			rq->core_dl_server = NULL;
+			rq->core_pick_leader = true;
 			/*
 			 * For robustness, update the min_vruntime_fi for
 			 * unconstrained picks as well.
@@ -6755,6 +6757,7 @@ pick_next_task(struct rq *rq, struct rq_flags *rf)
 	 */
 restart_multi:
 	max = NULL;
+	rq_max = NULL;
 	for_each_cpu_wrap(i, smt_mask, cpu) {
 		rq_i = cpu_rq(i);
 
@@ -6772,11 +6775,15 @@ pick_next_task(struct rq *rq, struct rq_flags *rf)
 
 		rq_i->core_pick = p;
 		rq_i->core_dl_server = rq_i->dl_server;
+		rq_i->core_pick_leader = false;
 
-		if (!max || prio_less(max, p, fi_before))
+		if (!max || prio_less(max, p, fi_before)) {
 			max = p;
+			rq_max = rq_i;
+		}
 	}
 
+	rq_max->core_pick_leader = true;
 	cookie = rq->core->core_cookie = max->core_cookie;
 
 	/*
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 9539867e9e0f..b80a5eb384f0 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1350,6 +1350,9 @@ struct rq {
 	unsigned int		core_sched_seq;
 	struct rb_root		core_tree;
 
+	/* private state for sched_proxy_exec()  */
+	bool			core_pick_leader;
+
 	/* shared state -- careful with sched_core_cpu_deactivate() */
 	unsigned int		core_task_seq;
 	unsigned int		core_pick_seq;
-- 
2.43.0


  reply	other threads:[~2026-07-17 11:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 21:45 [PATCH v30 0/7] Sleeping Owner Handling for Proxy Execution (v30) John Stultz
2026-07-01 21:45 ` [PATCH v30 1/7] sched/core: Don't steal a proxy-exec donor John Stultz
2026-07-01 21:45 ` [PATCH v30 2/7] sched/core: Avoid migrating blocked_on tasks John Stultz
2026-07-01 21:45 ` [PATCH v30 3/7] sched/core: Don't proxy-exec unmatched cookie lock owners John Stultz
2026-07-02  5:13   ` K Prateek Nayak
2026-07-02  9:14     ` Peter Zijlstra
2026-07-08  5:00     ` John Stultz
2026-07-10  3:13       ` K Prateek Nayak
2026-07-10  3:32         ` John Stultz
2026-07-17 11:15           ` [RFC PATCH 0/3] sched/core: Allow proxy execution to work with core scheduling K Prateek Nayak
2026-07-17 11:15             ` K Prateek Nayak [this message]
2026-07-17 11:16             ` [RFC PATCH 2/3] sched/core: Fix forceidle when lock owner has mismatchd cookie K Prateek Nayak
2026-07-23  3:14               ` John Stultz
2026-07-23  4:01                 ` K Prateek Nayak
2026-07-17 11:16             ` [RFC PATCH 3/3] sched/core: Swap to lock owner for core-wide pick on core-cookie mismatch K Prateek Nayak
2026-07-18  6:22               ` K Prateek Nayak
2026-07-18  7:01             ` [RFC PATCH 0/3] sched/core: Allow proxy execution to work with core scheduling John Stultz
2026-07-01 21:45 ` [PATCH v30 4/7] sched: Switch rq->next_class in proxy_reset_donor() John Stultz
2026-07-01 21:46 ` [PATCH v30 5/7] sched: Break out core of attach_tasks() helper into sched.h John Stultz
2026-07-01 21:46 ` [PATCH v30 6/7] sched: Migrate whole chain in proxy_migrate_task() John Stultz
2026-07-01 21:46 ` [PATCH v30 7/7] sched: Add deactivated (sleeping) owner handling to find_proxy_task() John Stultz
2026-07-03  3:06   ` K Prateek Nayak
2026-07-08  4:34     ` John Stultz
2026-07-10  4:03       ` K Prateek Nayak
2026-07-10  4:56         ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717111601.6017-2-kprateek.nayak@amd.com \
    --to=kprateek.nayak@amd.com \
    --cc=Metin.Kaya@arm.com \
    --cc=boqun.feng@gmail.com \
    --cc=bsegall@google.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=gor@linux.ibm.com \
    --cc=hupu.gm@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@android.com \
    --cc=kuyo.chang@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=suleiman@google.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    --cc=xuewen.yan94@gmail.com \
    --cc=zezeozue@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®