From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013070.outbound.protection.outlook.com [52.101.127.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B0F3F4DF5 for ; Fri, 17 Jul 2026 11:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.70 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287354; cv=fail; b=UwQrV838G1CR+8PInX2JVLZPejkPX2SdcPyRL3AoybMntPlha7zmtz1+r5PdodumJqGZfGbvH8oNbeaqAKALnXo09bbhoaDojGPSPdOAYZfNWl9YhEspviR3FEPVvSoJxJohVB8m9KsNlPdcgIPfbWnYUhOxP/AP7/bUtcjuZp4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784287354; c=relaxed/simple; bh=wOa1hI1A8knSREbwSSotIaAjhAdzQWlefHKAvAY94YQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fAxRyO9sFwnlh1z39YTmCGq7X8Gws1yqxHz59meuZBH3SUvPylFNIHSplFmjiti0K0D8in5zbOC0L/8xHWwY3O+O1Z+Gw1I4Bax6SDz86rTtn5c5MnVZTfAZ2J1ngvHOlynN0HxBmT8Y9sNnD3au8BlFfiZmRgFQrzp1GU24unI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=knSEHlF/; arc=fail smtp.client-ip=52.101.127.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="knSEHlF/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JiPkz4ZMBspSzg4prZNtChXMotDjBKGE11+U8OmThTgEr4jRKXyyxgN+brcEOsU/zve7Pkm6yK5xnnmFwtMutWg5qDeonG730bQ3eEpopjqGKFlFjY9y5S4Toi5JoukpeibpOwpzGhO+UCK/H65Aiyi2PNHcKQMFUUPykRGYilN63rS38s5pdpPICmenhhW8+HDiaOjxt9OJMuG4GdX25AUNjF3vHI1Rh76BFHkD7VUECIYCuL5dDeR4AduMdtFzB5+0cWzrq+3vIwPUytJu8qAOdmUV4P+McdO0jVvCmVMqCUHRP5P0em7oySerFA0BIr/BQ9yppmg97b8t/Ddikw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MAP7yMYRdo+gY8zP9rxfB4h+ot9QhoA8PtThvCZCpY=; b=YWVwf6gUk9imfcRkfhqFLfj+fslnKmlOTJvjabyJxU6uotO0wubk9fVPDN0ol0J3z2I4eAJ89l9NF5G1VAEVd9pTbCAjf/XV/oFMtntnkztnf7ix/b7ZwEVvfPvRpcLDRk6YtfviH3BN/vzr4BPUtFezGM2zjFe16l8NJa7oJmANmdBidzZLVqhAHlQx3+0cWhyZPpYZdHJP8/Ua/4NpcJKjESv7Fmr4qQdFOSKKAP8MtsWGPUrN3xBeRb/9neZx/W6Cgf5abNamTMVKSjlJrgFalhg7klSHAcXnR1ysrV5+xuz4vwxKGoj5fQADLPx8lak6jV+XxJLIn7NKPTWtqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MAP7yMYRdo+gY8zP9rxfB4h+ot9QhoA8PtThvCZCpY=; b=knSEHlF/WSxFs2XZZ4SW5EqzB955bOpX78KNayftcPneMBHGvUU1ARZktEtlvBM0rcy+P5Z6NRi+yZSSN4+b5TYLgh5KR3XKKNHm06xorh48yE1v/qwpwOultCJmwg0sCmLUWjOyKWte2syI026jj8Tx04m6c2ieUS0sj//SjjCZ/rBsycdzs9wL7vrAIsKPczXfzMy1OITGQoD+xE1PI7+iI+d1UXOoLyEQOr3tM6vtG5EtGcpZm/XIg3kyhHSpMT9BpKSZ9A9uQMxDjTdkBXH5PyLck7FAJTfmgVIaLX+bG2zZ5VaE7xKRDzxoscTEF9nIm9Tn5kyN3D8/fztnkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by PS1PPF5540628D6.apcprd06.prod.outlook.com (2603:1096:308::24e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Fri, 17 Jul 2026 11:22:03 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 11:22:03 +0000 From: Pan Chuang To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Takashi Sakamoto , Danilo Krummrich , Pan Chuang , Bjorn Helgaas , Kees Cook , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/7] platform: goldfish: pipe: Remove redundant dev_err() Date: Fri, 17 Jul 2026 19:20:42 +0800 Message-Id: <20260717112103.213017-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com> References: <20260717112103.213017-1-panchuang@vivo.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TPYP295CA0025.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:a::15) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|PS1PPF5540628D6:EE_ X-MS-Office365-Filtering-Correlation-Id: f6bcdd07-e00f-4c4b-aaa1-08dee3f5a02e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|52116014|1800799024|376014|6133799003|56012099006|11063799006|38350700014|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: DE/TBqHlRx+J2/zV6l0jRjYWLIbNvAvVHawQN4qmzcaUfgQRt9pN7kFIQ0VX2zkhXSKHK1DctTDqZHiU7yQ/JAqk4ewupmq7sy/CM30aUpzkEY8aNGpCj1aWAjkN7OD7s1zN5+KGVpuMt3rIA1foWWkT1l1wF0lOjBeIhSphqZuVVvLsjangbCVg4+LQ6Y7pBYqLrW0SoVYcwbLQRU6dXampScMoyErFeNfMzOmFK0MtFhksiQ+Gjsd2Zx5PFBEgyoiR5o9utI8tYngz7j6G+Bxng5/IaMxhxu5LcVurOVEwVUFpo7emhMPyvbuQUhOzXjFYIJjJc7ONgxj/GCdeiTnVuMuZw0U7Df0vj1T3ARO3YzyrHIuafZ65z836j5qWWHI/FxJO2J3CBe+H9tDt95/eHvOSC5XbnfpCZQuFO1jRr6WB2mWAemqpaL20sFIZudMy+mlyOF5hgZHM03CRnT+cUIY8AN8XnaST8+KwEsN9IYlQFjVU7/fJDIPnae2BtKDYxiqabnKHFvpl4xAJNSFHOmIS6W4s4lsSIjGvRhvJOM0stOgPzJOpXnWB9ML3UEz+ckxkVKlqxmYkwiJ2g3M05dTXX4q2jJEZ9VgAPWni5icAKy0jIvGG9JFtZtOHCx3xptIwgwgKW2v1Wj+ARoFaPyUwcxJ6M9icd6Xs9ExMkzpGU5/8LXtDgr4PoM5jcSIbdoyhNGY7PzIVMbPOdWHTuTmHJoYKBNCXDsE+Rzc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(52116014)(1800799024)(376014)(6133799003)(56012099006)(11063799006)(38350700014)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8qkn2WstrWDILDprKBCCIsTBODbehHT0hU3py8MObJIIbDlBAFL7ekq/uH5J?= =?us-ascii?Q?W3H0xA2VcEAS7daOkGdn5gzSr9T9BzIjiLx77uJFGMMiiBeIFWVyNMur+S89?= =?us-ascii?Q?53/ZYRRvFA4uZxKUcUIETAegrbI3Q3yqAf5QDi5CgA4xbnjbVg2k7rLXgAuF?= =?us-ascii?Q?TFlAl+ylG628GNvS4Ti7XtormSBzvyyrwpGCf20vYAjYXDxlUAUkv4XLKl7Q?= =?us-ascii?Q?75l2EYGUdrH4WRRf29lHI+v6JrOfy+rf0RuEc4PUq+nnJdKgFap58g0lDxrN?= =?us-ascii?Q?fldOpWBo6IJYI8W8pgQhOsFp4YjkimGLYLKLAQu1KhicAJ8+C7um+sTkTyk3?= =?us-ascii?Q?apDH9XiLaR7KuVRjJxIgLw5S7GAdGyZND4EfddF7jcl+yLVIxUC1lCAFELan?= =?us-ascii?Q?7UsGdcbb7CVQhE0rw5t9uJuZsvV10CEQvrdkgdi6dOjQDJiO7Gew0i0oFOsU?= =?us-ascii?Q?3EHITIL+saLwqlMMdmWfW8h+kfsVvSb3SfZN3oMXcO0lwK3yDEVgVxRZ/jJA?= =?us-ascii?Q?UQ7UPp4oywu3d1kLjL47fy3gDixoFsf0mnkLTLWjo5Gy2jUxzCTkk948I3QH?= =?us-ascii?Q?lBvJc08ORe93Y5+8w8nMC8uR6VOP16hBo1+KK9NcgwFAdJcld+csAHdKyUeL?= =?us-ascii?Q?KBmiO++m5o5ukgGjGdYec68OmzYDqIfriI0ye0NG+vioJ+oIbZkeDEzZzR20?= =?us-ascii?Q?37tNaWm9xkQ8o6nDdugIxsbcEWdoNqEgAlYmIQfXnWjzRf+YwFi+sMVto4gJ?= =?us-ascii?Q?f+GtSFP/A6WmRFv8Ks450IwhR+GsLOM1tgyVEA12yz6Jmy3CDeqBae5ZU8Sh?= =?us-ascii?Q?yFXQ52v+hjxM/tqovjkjdiZ2OlAqWhoKNgO0//EKsQem52hf8IsVMY7bQjTQ?= =?us-ascii?Q?uxU3VsNczdZYrxLxU7yXSzZbV9XHTzcQUzIUUIVtVBcdSqyK0JvoEvtYvMNZ?= =?us-ascii?Q?NQI7pq9mHKgLAPyW0PxlN6puVTeZsqVlGmBjxvOQQpoXJYQGZUaeZkpG9Jh4?= =?us-ascii?Q?/5iV3EXr8L5A4t5KTIkRCvNUEqR94K+z9ehEfIPsI6DqGK5tsd4NsddmJKQh?= =?us-ascii?Q?ZgkR/WpigfqnM05bRxYgIFOsF3JDqxOJqx+yamIPgO1wFQqHwoUWx2i+gkIG?= =?us-ascii?Q?aI2j0O3booti3Mwz5//xxpDH1HAD94erQLdDk6aZOyUDiE60uDljkUK6BXY3?= =?us-ascii?Q?7hn3vPEyEdnxhppMzj8TL+QZNWD0NgsFikVOyIYSfTBeSDo1RsD/S507YZCb?= =?us-ascii?Q?/ImvfuZh/nWJ+ieP35Yu1pXB/mnluBpLX65yjQ6+8pS53QWpeDujpHhvo/iR?= =?us-ascii?Q?HpBTHCp0upQVklT6f7ASob89/gS5heLDdy3mvsuKFSlsYU5vlY47ntS2aLLM?= =?us-ascii?Q?c+w8ZNL9Ch++ZqWfwpX/AzchF1kF/yH13f/XXyqlDm3vyBFdqn3mL/Tn0oMo?= =?us-ascii?Q?SMX2BdByDOI6SDmXjTfk4rrl88KqRHJwhW/A6n8tWkxFYPhpIzHzjrIqT+Yv?= =?us-ascii?Q?zsqh8+re0Ux0sgLVxF+y3gwvv6G2KJKOfozArMRjrUtc29QnjJ56LAmahKbV?= =?us-ascii?Q?6gGpjayiw2RY94bKVkPs1dXwlKzuVnEfST9L+Ztqa2DdZn3/G6xqy9YXXyYZ?= =?us-ascii?Q?otRI6uVoAzDeaUQ9TPqCQouf7g0TKsZ2M6P3rfE5cOeyphcnPQ2BX/X/zHPI?= =?us-ascii?Q?wpjCdaWkMThW24/3Y2nPJQjHFvQdnWHHTgZs9D64aZD4lxxc/+w4/CjZMRJF?= =?us-ascii?Q?9GLtKxHHVg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6bcdd07-e00f-4c4b-aaa1-08dee3f5a02e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2026 11:22:02.9970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aAZzHud+hY7O2Yy30BXF8tLquZlHv6nNr8Zc9KPJPkw5WpWq08bGD9F18QCifG40YxzCaVfj1ZF9CJ0BUBqXag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PPF5540628D6 Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/platform/goldfish/goldfish_pipe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index fa241ca8feb0..f4f25c0a011c 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -810,10 +810,8 @@ static int goldfish_pipe_device_init(struct platform_device *pdev, goldfish_pipe_interrupt, goldfish_interrupt_task, IRQF_SHARED, "goldfish_pipe", dev); - if (err) { - dev_err(&pdev->dev, "unable to allocate IRQ for v2\n"); + if (err) return err; - } init_miscdevice(&dev->miscdev); err = misc_register(&dev->miscdev); -- 2.34.1