mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Onur Özkan" <work@onurozkan.dev>
To: Younes Akhouayri via B4 Relay <devnull+git.younes.io@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Onur Özkan" <work@onurozkan.dev>
Subject: Re: [PATCH] rust: print: fix broken `_printk` Rustdoc link
Date: Fri, 17 Jul 2026 14:51:35 +0300	[thread overview]
Message-ID: <20260717115142.62938-1-work@onurozkan.dev> (raw)
In-Reply-To: <20260717-docs-printk-rustdoc-link-v1-1-892074948f75@younes.io>

On Fri, 17 Jul 2026 13:44:06 +0200
Younes Akhouayri via B4 Relay <devnull+git.younes.io@kernel.org> wrote:

> From: Younes Akhouayri <git@younes.io>
> 
> The Rustdoc link for `_printk` points to `include/linux/_printk.h`,
> which does not exist. Point it to `include/linux/printk.h`, where
> `_printk` is declared.
> 
> Fixes: 247b365dc8dc ("rust: add `kernel` crate")
> Signed-off-by: Younes Akhouayri <git@younes.io>
> ---
>  rust/kernel/print.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/print.rs b/rust/kernel/print.rs
> index 6fd84389a858..0d62beeedca5 100644
> --- a/rust/kernel/print.rs
> +++ b/rust/kernel/print.rs
> @@ -99,7 +99,7 @@ pub mod format_strings {
>  /// The format string must be one of the ones in [`format_strings`], and
>  /// the module name must be null-terminated.
>  ///
> -/// [`_printk`]: srctree/include/linux/_printk.h
> +/// [`_printk`]: srctree/include/linux/printk.h
>  #[doc(hidden)]
>  #[cfg_attr(not(CONFIG_PRINTK), allow(unused_variables))]
>  pub unsafe fn call_printk(
> 
> ---
> base-commit: 7059bdf4f04a3e14f4fafb3ac35fdca913e3e21a
> change-id: 20260717-docs-printk-rustdoc-link-a6645b2873ba
> 
> Best regards,
> --  
> Younes Akhouayri <git@younes.io>
> 
> 

Thanks!

Reviewed-by: Onur Özkan <work@onurozkan.dev>

  reply	other threads:[~2026-07-17 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 11:44 Younes Akhouayri via B4 Relay
2026-07-17 11:51 ` Onur Özkan [this message]
2026-07-17 11:52 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717115142.62938-1-work@onurozkan.dev \
    --to=work@onurozkan.dev \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=devnull+git.younes.io@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox