From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6183C3F1AB6 for ; Fri, 17 Jul 2026 12:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784291164; cv=none; b=Fn8w6dR3LGgWv4tYmxG/xOUEw7Svpi7jqjL95ObB/yszHODIvqKh4bwfmVMtTA9JHbV13BIrzHGJpXgLJ0U1CDtl7jVMl7qEvUR5WrtzEkp81bTUlMlTBBcH5Eu1xUhO4tXvVjE0Jqv4gLdVVckA5KoiwIgwxdGarXzETozhqBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784291164; c=relaxed/simple; bh=IC8gzWzxCsIar3IfwGi+djNUC+FAXYvXRt0qdcQ6O8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DIPYemcJBWzr3Ax96f/TmRGbswG1Yij/VIcjOS51ZiJ/jlBUqvBydhzQ7FDchH3WbOZ4jwhSTCDPCUVxS6ooRqz0EEumaxKyQbdAppYhk/gB6P6SHYKwY0C3S/anTBafg2Iqj0/qqo2B7j1TZ7le2I6xjYBR2RLdDZPFg/HbnII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fIAujvwe; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fIAujvwe" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ceeee8c46bso10022075ad.2 for ; Fri, 17 Jul 2026 05:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784291159; x=1784895959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H4y0Flvk61D5jK2+voopkUsDY0AemRgTCBdod4M2Kx4=; b=fIAujvwe/u1pvCc8Gmf3QYvSQNtK7FTDI5FiBWFhYoNV/xcM/29xEKARWpaijAfSH0 BNBu0cVXbDPyMzb3JTpQ5/BdeLXVx2gTAHp9cfaNRxFAAknIeEaHqRm9p0ri1IW3NxJE swBWsOIW7zpgxdO4kVgXcIr0Ow5nByQlZix6B1TC5bEBTXAqHxTmAXfja7/8YUj4/3/H UFC/XzD6k62vaByvr3YovcwNvC2zm/xK36qs1y63soNf07kmTttWc1VEerIBsRI08oOj tL1icAKyKd6rEL1GYpzMfhgtkHMrwIdNT5EU2454ruhv1BHg1/ExzdX10FwY7AgE2edu gZYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784291159; x=1784895959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H4y0Flvk61D5jK2+voopkUsDY0AemRgTCBdod4M2Kx4=; b=q5Yyl2vCtSQYHoGHK1+dwE8O4Qlza5K95AH6PAFTRp3KAuoydaR7O2Kv+5SI/pfIjg Qjzm7PXRoUS7sCK5mErQKT6EPWjUJlrWPg0rp34H5vZ9yVVjIFF7R+thr67peva5HdmH ferCMqlIUJIkmgMGrpr5UzoSAF/GmE8kSwzXYFYG3hml8KcGb23c38oEYexFRLW7dpzn aevjfBr5Cbi7DyO77irkIL8sdRSmixercuYy3bAo44JHtElWlu568d0k9rmFiwMG9vRt 6RPrY94RkgOEcR39I1EXwwRguoe5LeD6ZsPAYuIIQ4/9IWHJHExOy24x3pA3MX+4igZM sXXA== X-Gm-Message-State: AOJu0YzyFOPrdovt1dvshY34rh7wFtlbHYUq7bHQUY+QTeDXuQO9xwGg BGRkuN/PGM5tlgfsNn/iBv0eqd5eJrcTrgZDKgNYlMaqicKMpnUpM8Nv X-Gm-Gg: AfdE7cnkUqGDwoM+0PFnOBsVbt0XWaXMBnqg81Vggg6p0Zfi6F8Q2SVSRdFb1aAi1gR vIcM9+sev0A++cWNiPhj4UKWxYXXEsOUROK0zFkrCY2pTcf/EnNVki/UL5TrZMip0AhgbipZw+d 1eUnw9Ylr3ctUB9Y4+KyHmsJMiTdy6Y7LeBVEv+d2RU1OKGGhJeZMHpSkPmcPbjPqcGTRdYvrQv 7PM68WcN6DBGb0ssFo+Bqlhd+7dT8kFBYc1NKqjn5liLSEMRBRYfrVfBMr35I7dFHUjWHHJFvyN sc/tYXBjgBlLhGuu+5RG9ELKC0agGKnF7mAr4jMhaBuFSQu+ANBo8oRUtJcy3za5NVgbj5c/kHZ EoMeAOATvQLVAxGMI3cVlVbwkp7ER11e47ZKtYrp7rYwe/XVHaWdTQEge+Hh77XRUbWKYYVuUse hzEOfAdGHLZ8Fxsc2urq131/v/jmIz/g/vgy9/Uptk296g X-Received: by 2002:a17:903:2f04:b0:2cc:9d9:b8df with SMTP id d9443c01a7336-2cf349c9761mr23369415ad.5.1784291158894; Fri, 17 Jul 2026 05:25:58 -0700 (PDT) Received: from debian.lan ([240e:391:eb4:a240::1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf347119dfsm9935955ad.56.2026.07.17.05.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 05:25:58 -0700 (PDT) From: Xueyuan Chen To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, baohua@kernel.org, zhaonanzhe@xiaomi.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, chrisl@kernel.org, kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, youngjun.park@lge.com, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, baolin.wang@linux.alibaba.com, hughd@google.com, Xueyuan Chen Subject: [RFC PATCH v3 4/4] mm/shmem: split large folios only on -E2BIG Date: Fri, 17 Jul 2026 20:25:14 +0800 Message-ID: <20260717122514.51514-5-xueyuan.chen21@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260717122514.51514-1-xueyuan.chen21@gmail.com> References: <20260717122514.51514-1-xueyuan.chen21@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit shmem_writeout() currently splits a large folio on every folio_alloc_swap() failure. With the refined return-value contract, only -E2BIG indicates that splitting might allow smaller folios to be swapped out. Enter the split fallback only for -E2BIG. For -ENOSPC and -ENOMEM, redirty and reactivate the folio as before. Suggested-by: Baolin Wang Signed-off-by: Xueyuan Chen --- mm/shmem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 3b5dc21b323c..d76812dd3cef 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1599,6 +1599,7 @@ int shmem_writeout(struct folio *folio, struct swap_iocb **plug, struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); pgoff_t index; int nr_pages; + int ret; bool split = false; if ((info->flags & SHMEM_F_LOCKED) || sbinfo->noswap) @@ -1679,7 +1680,8 @@ int shmem_writeout(struct folio *folio, struct swap_iocb **plug, folio_mark_uptodate(folio); } - if (!folio_alloc_swap(folio)) { + ret = folio_alloc_swap(folio); + if (!ret) { bool first_swapped = shmem_recalc_inode(inode, 0, nr_pages); int error; @@ -1732,7 +1734,7 @@ int shmem_writeout(struct folio *folio, struct swap_iocb **plug, swap_cache_del_folio(folio); goto redirty; } - if (nr_pages > 1) + if (ret == -E2BIG) goto try_split; redirty: folio_mark_dirty(folio); -- 2.47.3