From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ACC9390C85 for ; Fri, 17 Jul 2026 19:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784318010; cv=none; b=BZi0lK4KDh62sSDj2v+MyGzjij3wkTtdSguqEtBrhLe7HewANLLhIV1TgrmTo4rm8Qr6lR6ER8ESxsVeksnWnaxt5Y3OEsg4dgWuxJcKIBgUDj2oZpdP9fCZ+Lgn7Jgb52yN2zdAkys12LTU09QjVZ6uGiMgpCKPu6h1J1Zf5xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784318010; c=relaxed/simple; bh=XlcOKwDKth21uhPu3XElh4WaMacS6eUQXpILgepzbYo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=IMV4PkTOzCIG0WZHK8nRF/zi+sQxCaJ1r3SrdQmy50JctsSS45GeF6j+IA+xrVxCnMvkIV6JqYXaUGctJ6Sn27NiHLGuA5fhqt1qtkXikW5myFi+jX475dSZMbV8btS2Tmj+tlu1znmVDDsD5jV7jJ0j8I0ynOlkvmFIg2E5/Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=A5uBCCgH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="A5uBCCgH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2991F000E9; Fri, 17 Jul 2026 19:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1784318008; bh=FzGsMfjy3uVZeOrqXk8AeG/VbsEl/Z0QNXbp+sZJkN0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=A5uBCCgHeNQvijKIEyvEb8DXl8uibvUySeNGJwOWcZY5IPzcru1rUI6ytmHrQo4g4 i9/WjiT96/xL8Z/CWhjFzhog12yFLy0JR2RKK44H77o3wf8fYQXOH/ePH6HeMR+VEP hn0Rj1a8sWaXrvrwcOVXiEKznVfYgYrdFw8PcfnA= Date: Fri, 17 Jul 2026 12:53:27 -0700 From: Andrew Morton To: Ridong Cc: Johannes Weiner , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH 0/3] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim Message-Id: <20260717125327.cd3e3cc4e6cc28b0855e6502@linux-foundation.org> In-Reply-To: <20260717113300.214717-1-ridong.chen@linux.dev> References: <20260717113300.214717-1-ridong.chen@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Jul 2026 19:32:57 +0800 Ridong wrote: > From: Ridong Chen > > Two fixes and one cleanup. > > Patch 1 fixes "swappiness=max": the anon-only test in get_scan_count() > sat after the "cannot reclaim anon" check, so when no anon was > reclaimable the request fell back to SCAN_FILE and evicted page cache > instead. > > Patch 2 fixes reclaim_store() collapsing every error into -EAGAIN, so > callers can no longer tell an invalid argument from a busy interface; > propagate the real error code, matching the memcg path. > > Patch 3 drops the now-unused gfp_mask parameter from __node_reclaim(). Thanks. Sashiko want to know whether MGLRU should also be fixed: https://sashiko.dev/#/patchset/20260717113300.214717-1-ridong.chen@linux.dev