From: Greg KH <gregkh@linuxfoundation.org>
To: Arsenii Pashchenko <ulijg308@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
Date: Fri, 17 Jul 2026 14:10:45 +0200 [thread overview]
Message-ID: <2026071713-drearily-tropical-49ea@gregkh> (raw)
In-Reply-To: <20260716-remove-readchipversion8723b-wrapper-v4-1-9493b5f37c31@gmail.com>
On Thu, Jul 16, 2026 at 05:33:10PM +0700, Arsenii Pashchenko wrote:
> Collapse the static CamelCase helper function ReadChipVersion8723B()
> directly into the main rtl8723b_read_chip_version() function.
> This removes unnecessary code nesting and cleans up the CamelCase
> naming violation in a single atomic change.
>
> ---
> Changes in v4:
> - Format patch via b4 as suggested by Greg (no code changes).
>
> Changes in v3:
> - Merged the previous 2-patch series into a single patch as suggested
> by Nikolay. Completely removed the redundant helper instead of
> renaming it with '__' prefixes.
>
> Changes in v2:
> - Resent the series due to submission issues with v1 (no code changes).
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>
The changelog goes below the only --- line, and the signed-off-by goes
above it.
Try using the b4 tool for all of this, it should handle it for you
automatically.
thanks,
greg k-h
prev parent reply other threads:[~2026-07-17 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 10:33 Arsenii Pashchenko
2026-07-17 12:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071713-drearily-tropical-49ea@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ulijg308@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox