From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A7F442B312 for ; Fri, 17 Jul 2026 14:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299585; cv=none; b=l70OMAs4Fp2ET/p7r+/Ta2M//4k6Q9w7xvQxgB4LCCtmnXTRP6Mw04f+jz9s94Zt/hqTACbBSn8gv5aSFv6db9VrMu8XkhAmvw+zLECQBvn6+K8OEp/vFMXxat1XSOmqHF6IX/NzH5hE0fmp/ZVc5DXua0gcJ3A68QSc5FlRkGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299585; c=relaxed/simple; bh=MMP0o0/wLxlkOACAQ1AZ23luEK1+TS0ogSqOvAnVWdo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wfq7xhMwteNXPuwyEqxB/As0J6eRi1ZySGrHPXJR6atyEyp1URR+g5wv5TG996KuekdjjT4J6ir7MIZ51VaYImBMv6BTx/rBmYrN6vvKNFfzXbrR635cEm4bF5PupY6uYB+9vw6hiWqg+BbOtOIB1cvoUnsEc9ehpFiji5VCQCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MsCNE9vS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E7Uafncd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MsCNE9vS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E7Uafncd" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE7rQG1838944 for ; Fri, 17 Jul 2026 14:46:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WqxH1zDa0UM90FIlcAZOeYgVcW9oIh+YtN03t/bfm5A=; b=MsCNE9vSa5V3v0T9 TOh0LvhG/ngqx7nbQ/VvRAqiPY3pwCGdJTulrwpFROazkDyqkzyxUDiED9tyqZ+y n+8QI/OcSnJq2dK6Pca9KcHGnPdsOAAjw9o6Z/Txt+Gpv2OG2X+UOB+luWz2Cegs LW5PvQLMtKAL6qvqzCpYsNPm239q9d2FrHBZe9clnkvRn++bnOpZjnOwAAdrUcHU vDDP2m6dkTbHxcQK8qyfLynvyZ/5dpOZFrRfuWKEFfT9sq5DVC7VICg6T27nm0eF wMftm7oQAIebMugVWdRBjRfzanC3WqUgE9PiQ2x5o+DArmArvSmLAIX2lru0XhGu 5iuw9Q== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fffag9rex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 14:46:22 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c21c01cf3so98151211cf.2 for ; Fri, 17 Jul 2026 07:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784299581; x=1784904381; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WqxH1zDa0UM90FIlcAZOeYgVcW9oIh+YtN03t/bfm5A=; b=E7Uafncd6xjaUVmQaybn/6K3f1YG+h+dzfWYQ13b3X3H7G3C6P+lxV46E0lmx5tiUN kwrI/wx9ObIUsNwFyxOGdcczYkRVcf/IY0zgfqD82XhBJhgnTvqyrZTiBemJa4q6YV1o mm8yto4tr6wS/io1KIEdnSBNLUdOBjLpRbc7Rbct+SRsbMuhyxHyFdTYuTQ/t5jrKuix qBpnk4Oz3sGIxzis1+lR2qk8EQvzG/FpdKn6ukPAeeccV6UcxZeSJG1mt4ESrpPVZFq9 0aIYd0BvBUoO43PNXKmGeRwEuwyFzGwOovK5OPmRu77+5sNaou9HYl22t2BaMH1sXP6m Bl/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784299581; x=1784904381; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WqxH1zDa0UM90FIlcAZOeYgVcW9oIh+YtN03t/bfm5A=; b=oIXlXGd4Sbo4mE0lrirXTktXGVfenn3SNlWZqNF6ktYgKBD69N3OHV03L9wAEPXyp2 bRR8TzVu7O72UP1UxZPNsp7kmPQ2xwTpGq5wBEimWgL2s9In/DHI2TEXLlcDoltDbag9 xg2EFX3uX1WtnSoKeSD5Uj+Q83AsuK/QdoUjvFiGmiAbrQ7x+dgWyU+AHMsFQN5+MxcU IvTv2lav4qrvCDLrg6XrWxe1R9qq2e741MCGISycZ29u3tk5PRlKU4jLZcjSXky1zIC/ RBfGb84bC0pF2dQVLFOZmEzaF9q2c2KQzR46H52krLCQddYqcOJPq5xDsF2/uYRJ9yM6 CoaQ== X-Forwarded-Encrypted: i=1; AHgh+RpTOBmDtyztQd7uaOFGj9TXk5VzHP/Zhio5KV8OwnRC60WstttxMREmGBmGwNE81NbTPBnFLklUIPSsDqk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzzr64LffEeYE47ZX7RC8tU1EPiyTYFZPpmynvVtMxQX06vWwIT tM0G26/jzGXAw0UpapzJufBE2nyQzW1eVfScAdrJ43XoxwOsKn2uHMTKVOOD3r2dbWNdbSlaN9+ xbuZbfToXdexl3iyJ4IVsuZN+vKAudHPtmzudFiL+35QBHyIjzlGBedeITFy+0ru41IQ= X-Gm-Gg: AfdE7clKs7cnkWVOKeLmPNdCwhkIxwAMiYiGY7iVGlRgs4zfQfeslIbNqmRSDOaktBX KnjDhm4V6pYqHNC6FIV4WBIpzPIKsQkXFNAWNdKtstNqyxBnOXZ9FvsxqO9k37dSUauaOy4WlS7 m6YXmIHtKiItiDf6F4ZaBgKQg2B3noK8/xJGjxFfR5znXdXxNG76hpLDUFC1n6X9rqNLK1b6q+H 7Fr0oWO2Gxgqo66z/dVNvZ6k+1w+fOPI6OwfS13F0YaQ2MLPhNJLDkmcCJAUlIffJaAYmDQYigJ C1J7IBN16Jue4hQj4UGlUI/DN3nR1jXcsaQxxRbeenc93rRStHIx4/8AVSibPRuoZ6wfEhD1jMs dvPsdSewvNh/NEqdGLuDknIuDhCg= X-Received: by 2002:ac8:5d88:0:b0:51b:eb55:2916 with SMTP id d75a77b69052e-5213dba36cemr24144021cf.34.1784299581268; Fri, 17 Jul 2026 07:46:21 -0700 (PDT) X-Received: by 2002:ac8:5d88:0:b0:51b:eb55:2916 with SMTP id d75a77b69052e-5213dba36cemr24143621cf.34.1784299580715; Fri, 17 Jul 2026 07:46:20 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52149a3ce4fsm13414801cf.0.2026.07.17.07.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 07:46:20 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" , Alex Williamson Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio Subject: [PATCH v2 1/6] iommu/qcom: Fix inverted fault report check in qcom_iommu_fault() Date: Fri, 17 Jul 2026 20:16:03 +0530 Message-ID: <20260717144608.3216274-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> References: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX22ePIfnDmkoa oDHxpis2Dz+g/9ZNyrBZKGPZ7o/NexyeuQcuOzR34ZXzdPRLpaNqYoQEnBVrkJ4oSOIdEIH0YHw Engh1QB7GfUdDuli0ZrB4FThkBc0u3XCg3TcirWG+JbHHxIsZsEylqkKjFeJjsurEP0oYcs6lbc 7OY8Nu00ycGBy7u57+VOer8w4GxIkDCcee2WZZDHc6aQ7M0MNJ/aJed4P7Og5ggCkSUmNyUkroy r6GslpBSR8X62jqcV3ydqAi6gw5PXh54MgiCkdvl1xi9yVxn5IClQdpkcRX6wy9Ww96ZhTGSzS5 VzzUs5LqzSI0op1ioFpF+AWUz2qxBL9vxGtNk7mhBJABP8vwRjoK31gpw78LUPu82B12iF+2Trw uSNwPQbGT63QKIEoAZ0RIG221UBYSuLaccDnpDs52rAHBfPBDMCaXY0sL+M9/CyivAt7NEI0ILz nbCcNeviYA2QTzYmJkw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX6OCRy0gf/CZd UI6k53+J4XKpXZnezal4pShhIb92sgUBpY64pzkwFxM6ofHj/BOnxjjcf5amgU3tYBgRZY0z0Fj 8BvmPoPsd705Qluc5jPyK+7J5Esf6yA= X-Authority-Analysis: v=2.4 cv=KZfidwYD c=1 sm=1 tr=0 ts=6a5a403e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=xmDQi4VeJV1Yj6r8B4kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 1_MJr3V9QKnmnmeVEbuHLpc2stxE34mI X-Proofpoint-ORIG-GUID: 1_MJr3V9QKnmnmeVEbuHLpc2stxE34mI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170150 report_iommu_fault() returns 0 when a fault handler successfully handles the fault, and -ENOSYS when no handler is installed. The condition '!report_iommu_fault()' evaluates to true (printing "Unhandled context fault") precisely when the fault *was* handled, and stays silent when no handler is present — the opposite of what is intended. Remove the '!' so the driver logs unhandled faults correctly. Fixes: 049541e178d5 ("iommu: qcom: wire up fault handler") Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 32efef69e72d..09f2ee6be988 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -200,7 +200,7 @@ static irqreturn_t qcom_iommu_fault(int irq, void *dev) fsynr = iommu_readl(ctx, ARM_SMMU_CB_FSYNR0); iova = iommu_readq(ctx, ARM_SMMU_CB_FAR); - if (!report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { + if (report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { dev_err_ratelimited(ctx->dev, "Unhandled context fault: fsr=0x%x, " "iova=0x%016llx, fsynr=0x%x, cb=%d\n", -- 2.53.0