From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8158342B339 for ; Fri, 17 Jul 2026 14:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299593; cv=none; b=MCm5uiXpX3uEUCrd7YsnlUnOqDCh+6CcjT+n0uND64qSGv5+qSRYg+igIabAtCCIhEEaGs45kEWt9ngnTCGg/juw3eSHMJPQb3jqD5QO55DoGDcCCQeZKdwEMf//DfpeNAMOuHcF929PahiHcrNy8s78FNKMBwkf2ge5nEUY5M8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299593; c=relaxed/simple; bh=Q5Zhxh+S9+V7GhxrObo3WbR4OQ5znsS0Y2jHcq5ulvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lnrJchuBuhXVnP+Obg2iDqeQDc+700MibtUSBbHPfRuWzcaubC0fba1ZEKmAT/C7byxMcEf5H14Sqx+zuAGjmnHdkUEw+elfmdSbLkcs6pPKP8w3zlBnYvFA/Vpg6mgQQ4lQztFIp/u01ZRZzxGlc+4tuPkUQZAD4MlkcgV1yJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WpCJWEpL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ImM95/gs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WpCJWEpL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ImM95/gs" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE88Tk2106549 for ; Fri, 17 Jul 2026 14:46:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=3uivIe4Q1p6 JPBZcaMSYc8eXAUuOqshf8Fsi7jMSrjw=; b=WpCJWEpLxEptXN7UO3vw3bvMR2s WRsfv2IGmIYdeQATdBtLosTFLH99BDeuAAaQSZB2qxOkaXZ4rJ61owpQw8jmaRFr VHCZGP9Os2RcJFEbBSA7yF9WCHyXImihGmDuaJK+UQHxXBZOC5EVmn1jBvPbXm6Q mU1BvkjTk+jfb2HJpBszjq6Ul5iH0lPcux9KE3bDLLlOFK2MnjWz05hyKOiSPamR z8bjLw2ZYGS0sfJkwPoJnuobuF+vTsm/o+qr3Ou/pY+7d7JeTlI+oTxbiME5DrmH GvL0B5LiaAcmcWZMVjC4dg5UI2ZyuWgKqwe4LI5b2P+xEcIwY4WZwC7YSkQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffhpfh6y8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 14:46:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c2af04aeeso47992731cf.0 for ; Fri, 17 Jul 2026 07:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784299590; x=1784904390; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3uivIe4Q1p6JPBZcaMSYc8eXAUuOqshf8Fsi7jMSrjw=; b=ImM95/gsEGAJat6TFzK1molspPP1aI5qtHYqIi/OCrBpcSncRHQm8VOfh/EFvcx9JZ ro4Mp6hph8NZNvnZlu9LtX0ANDLSR/09AItolLrds/YA9FM+72At3XvDxdAGHBlTsOSn 9YNw62BUjliXhG3kOHnZv0FyM0MR5kjjEKTlPZXCKLTmJp1RYwzQ0uljAdvitAeyxyAJ dNuiohwLsWZwcHU5guyApwS3JpDCzdQypol/+ibBELpB0SnSI0ZmjdPMJxWS2A94jjp/ PKciK0dbCTYRwP9PJ3/TJU7cMwILNE+sra7t37VaQZp6V28cwaBIhINgShXDsrkT4e5G vmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784299590; x=1784904390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3uivIe4Q1p6JPBZcaMSYc8eXAUuOqshf8Fsi7jMSrjw=; b=n9ddPMyH/2OKsRw8LMN3dvhzngKUFir8zfvudHHXC+xcKwKpcb8AmobPjiujrs1US4 240m4PsOFGeSFiCaRMYcG/5xynF8zFVFyrdvx/gn8DRHooumY9yq91RwGwpRs/x0/BDx sni0uFjc+0nilPRwHDHSF7BSBwuSLM/zYWQJfQPJQEiMRgPBII8aN4eSCoxQGia+5trO kRBo7nJlUKhhNuu0R6jCGqOhW4S27KNeZp829itTykyi+ZOY4QgOBDNXdzb/N3eQ4D7x ucN7jbFTCLkzgRSr85DBaEIidPBQL7gMEi/nU47apxYnWcje0NYYEQ+x2zTD5mX+Ixoi aPGg== X-Forwarded-Encrypted: i=1; AHgh+RpCrvi05+i1LQ6tVvqn4qx71kyz8ylu1dJ9LEuMHGgQHA7zvWE8yAufyAcdFX9TGe3uy0E2KmTXob1+Puw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6AP8gwGPxYJy9nW7o1cr/bQXql/H0No7Lhyyyh4mtTTaQBxmh dVcGBispLuqE78icATXGAAIgeZ5jo6/bublQ+op9Sd6XwQrPjdEJz2yi5K5RPl1O341DzhNbZha GC+zxYnm0AJM0OfY5PpaJjPel2HIVhlAQXYsxpQDSnt8xJdpLuaNQOD2e4B+1aXPr1+I= X-Gm-Gg: AfdE7cm9cbS5Fs8dBouqtxcukkiw5FjEb9gPBA0Fzv2bNIFOoRE5hhw7P22S65jiwfq lcQV7OqP/FGdsOL7Xz8Ta6PbqN34QwR8rv0095XeRESb9Brnu16I3Ejr0K5F9aM1752FDXTlEL/ lsjWZmoEy9rkSJXh7VoQwmXBmpeCvR+IFo0+OMYiG+FuZhz1VaFKjoRHfDYjcSw6kWqHdl9xueA ReFPU1rVMXc1Gxtvr2/egdWfmPlRUus4EsIXvcVxez9gxLJ4YMFE506ldh239Zz+BnAr3Kizrja TB5zcAOUz/XZ8h51cvxFgZ5PVDV3/s+gz20ckOQcXJj6EsTHigCCS7l/MvO8swQBVLAwDa4Eljz OglJ+mPPE7jlzFXjGQqpk7Jja0xg= X-Received: by 2002:a05:622a:410e:b0:51c:fdd:f040 with SMTP id d75a77b69052e-5212b63cbeamr29077441cf.21.1784299590324; Fri, 17 Jul 2026 07:46:30 -0700 (PDT) X-Received: by 2002:a05:622a:410e:b0:51c:fdd:f040 with SMTP id d75a77b69052e-5212b63cbeamr29076931cf.21.1784299589793; Fri, 17 Jul 2026 07:46:29 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52149a3ce4fsm13414801cf.0.2026.07.17.07.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 07:46:29 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" , Alex Williamson Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio Subject: [PATCH v2 3/6] iommu/qcom: Check pm_runtime_resume_and_get() return in probe Date: Fri, 17 Jul 2026 20:16:05 +0530 Message-ID: <20260717144608.3216274-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> References: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX7HO6tbw9x00Y oDNQ/8jdx1t++zXXmHLrqdCCmd26MWqb5T2yCa+KpOrqWN+m656fJ2/t0VoL2SJRR5DLV4tjZiv Pr/zczTtN9iH2JI13CJ9NZiJDHJ04gOFXSaInFpFBeQrkzHcyPQGE9QkcRCF4KC47yvEV4gAQ31 iQog5R7jqCj2ZnkLC3hqEb7OzwR8IFfdr0wx3lEjMgFwhAhm0phr6daEzqrS1Q4jeh0ij0Z7slt HYXB8LqdxJv3pFHsGhQyOph/RhKFivQoN65rO/Tl7cwmwEI0Mc8DgVu6DdgGp+EcWEixG8YACBC iAU+swFpAM5htcLB37+IRP8KcfBZCVZJVxfoHlQKXhKnJNIlEi+5udKWU8WbKko09df6bOX9U4D 5KzuH0kEVJgypIb+rKfr6zt6tDzE2uR6LxqdaCP3Tx5H799YlNvMJAV0KYYL2iacdLmjrYmXmHS HqPsJCcIJ76JGx5ZdsQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX0lmHtbbzlBHl gOaM/0pRMSPGbbRjjiJ0W28IVRu+6Gy5AC4mk3qQ/ii4Cp18Fc3I2tQfuR6zL6OOHSPlr635KZq kk7rCUPXwVEZLuOIjTxd40xDvvJnsA8= X-Authority-Analysis: v=2.4 cv=YeWNIQRf c=1 sm=1 tr=0 ts=6a5a4047 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=uh9JkKNIBQsmCcNjqRkA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: bcwD-AipdEZs6AescixSnv_J9JtDl4AF X-Proofpoint-ORIG-GUID: bcwD-AipdEZs6AescixSnv_J9JtDl4AF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170150 The SMMU_INTR_SEL_NS register write in qcom_iommu_device_probe() uses pm_runtime_get_sync() without checking the return value. If runtime resume fails the subsequent writel_relaxed() would access hardware with clocks potentially disabled. Switch to pm_runtime_resume_and_get() which handles the usage-count cleanup on failure, check the return value, and unwind the already registered iommu device on error. Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 71251aecc292..1d04f0a19124 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -861,13 +861,17 @@ static int qcom_iommu_device_probe(struct platform_device *pdev) } if (qcom_iommu->local_base) { - pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); + if (ret) + goto err_iommu_unregister; writel_relaxed(0xffffffff, qcom_iommu->local_base + SMMU_INTR_SEL_NS); pm_runtime_put_sync(dev); } return 0; +err_iommu_unregister: + iommu_device_unregister(&qcom_iommu->iommu); err_sysfs_remove: iommu_device_sysfs_remove(&qcom_iommu->iommu); return ret; -- 2.53.0