From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5152742BC51 for ; Fri, 17 Jul 2026 14:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299603; cv=none; b=JCJQbvX4Q7OpmMXWkrYf0gyY7IWMVUJUvseqMPOd2eP2wfW4tp+1bIx6cMIHPenzp6yeylJvSS+vxjTL0evgvp9V0I8a+GUyYwt4pb3l8lacGO0/82GsdPJwAQfReWRhCsMdoiaPjGCxeZ+0h4iYFAdaB0bNM8ktLbPr/YOQfQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784299603; c=relaxed/simple; bh=SJxXIQqT//xBWQlFhfXbmp7aC2DouDQBgU+JmiLe18w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k2LnRnz+ZhsJlU/FKUWEazIMxyOSdaCFNDuxbzZkXJXpypLaMFn3kiHlIAENe2SP75hxojPy+XqJZWcrwEHI0sOFqCjtP3Pd/OYRXVO5H/3YY+tZADOmKmymV4xABrw78B79xt5/pkaHDgiduJxhnuIZ0X4bX4IGqOO8xHbwTFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dcl3uIUw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RkXBJo/6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dcl3uIUw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RkXBJo/6" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HE7nCr1973377 for ; Fri, 17 Jul 2026 14:46:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Z/6lk2kxW2n TS1x719Bxes8ej8Ufj/5F6jTJEH0kaK4=; b=Dcl3uIUwdol6XSOD4xXwUWtBbBh AlbqLwRt+YULgKoms56hrHdn+7deWYVfFcXknBXmyQOfgu9JAXZAMe2QRhNofxh2 XMwiUJtiXQlDAXcD7B7DLVEmOiokKPPujSgSHWFIQmpy7tF3ENP8UuBtKmZVwRG0 zO77DEi4h2xTbFE1+07cynDEaaZS23KOictYRWsUrv7Tzw0ub/GI8D8mCDb3JYiZ cWdPrQYfOdbm9eOTfwiaVWRmNz1iIst5W13Ee65jUUgU2BGi0iA2PeAkthq0lgP8 5pcb3dFs9BvaYFAXxGoBFtL5qQMC+5i1eIgJl0s+XpIjvSBnEjlvvtjliKQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff2f2vpyx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 14:46:40 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c075c1e25so106924281cf.3 for ; Fri, 17 Jul 2026 07:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784299600; x=1784904400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z/6lk2kxW2nTS1x719Bxes8ej8Ufj/5F6jTJEH0kaK4=; b=RkXBJo/6wDO6apU0v2Uyu86g2OCUxiwsgYkenXLMlsMQW670maJgLXINEVbxkXOsNy al2M/DvvewWFdjRxkin3ZdGyEaj8fMg4jCaeMPgZnIW/AbFWmSDQPAfGj2xj8WLPXBeR TNUyTwEKwYc0d8fdrftwEpad6ABVS2aPPezkvnI2vdyaGFnrDhOi72dek/MRtL7haLZE FCbGdZPnpjNr0bkvw7M09kClimaUoJcJcVpeYxY6qOmNlhR1JERd92NRW8LweZdV5o7a Hd8lhuznOqjp/slg13u/b9DaRuvHv6iCw8rBms1jS0UXxB5G1EWLTcZhszPiFth7XbtL WgHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784299600; x=1784904400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Z/6lk2kxW2nTS1x719Bxes8ej8Ufj/5F6jTJEH0kaK4=; b=fPwD9FC3llbvjSYO0kKhiVEgp326pQO52TK5/+OnDaL1HXSz1zHxDrhgPgp4f2cQhV EexuAPNiqT6TDn62tLAbrnlWdfN3mgNhAmSy4GGD5ItZH66zgt2dT/VxuSmFaFxFtK5p JMsQ+OFvLvUytYNHkKqDblK0ULe615RmdUI4/PC+nehAaHM7OFGH3jLIFWUjhAhj07jP T6DjZhdRKQBkHHR85zERKfN1Jpi6lTJXPkVJJQ4j1hZLECTpFnser4BeI9fjzEyV0Vwv atSZcUJnUNxC9gOHdwQSgBe8lVMzlAvBnWzUkSIQZStl/MGH7FnuqwSsrikbikNxVwNc hVyA== X-Forwarded-Encrypted: i=1; AHgh+Rqohx3Uj6PlvKTjn6LJeOAhIcd+7DM8L2Sng/nyP1PlAtDnDU1qlXF7Bz7/HMfZwwkIDHleJP2W6yAGNkw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy72630uRpeJc5g13Kfifr0EDl0s6t12A4ZNWXuqc1MjGmgimZB g2a8QQW4q+6nowsl3BtMioIAyPfi/JhGLB5QuW3t8u95Nx5mGAWb3qJ+lURWL2RmPDw688vbdH5 JK84+d1EBi8K/rHN/XFUJBP2K9bV0B1YVCXutdCGRKXgkZNMUIURud+V6ru16/EJXdMc= X-Gm-Gg: AfdE7cm2ElXF2IjQLjmfGhFfLZuEoOspPsW0MMCpMvFPRZnzdcfteNXgsrLrp6WlnkC JAmAENp9jxa3SH41Dc6N8rIXKkIyCcx6YQcX/UGTXkx15wZ4g5Q+ojR6CWQ1eTfC8Rf6iunrza8 nX37G9kqYeO3MIe35TqFWV5VfEMgHrQ1v86r3hTcYWKaHrwfprPjurpnJrDl3yJS+bAPSSTm8Ao 8taR82V+jfJge2eniDre8igqFaQDKU842k22YYQomgmHUBbV9Uw1mC+vreJjZC6eAszQzHLssA7 32NBQ37GJGFf4r9q/Pq9R8WW75F7uwRXw++vw/UAL5LTDoiDSIHNDvdcpv+Exs3e0TFmGrhqPFw C6JsnwP7YR1CxHh95Ztz/Vd5Hkyg= X-Received: by 2002:a05:622a:1ba2:b0:51c:6e:ef23 with SMTP id d75a77b69052e-5213c9e3db3mr27724661cf.32.1784299600108; Fri, 17 Jul 2026 07:46:40 -0700 (PDT) X-Received: by 2002:a05:622a:1ba2:b0:51c:6e:ef23 with SMTP id d75a77b69052e-5213c9e3db3mr27724121cf.32.1784299599569; Fri, 17 Jul 2026 07:46:39 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52149a3ce4fsm13414801cf.0.2026.07.17.07.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 07:46:39 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" , Alex Williamson Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio Subject: [PATCH v2 5/6] iommu/qcom: Publish pgtbl_ops before releasing init_mutex Date: Fri, 17 Jul 2026 20:16:07 +0530 Message-ID: <20260717144608.3216274-6-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> References: <20260717144608.3216274-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: vSvULSNWaej7Von_iI_yt0hzFDw3KXLz X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX2ZKVTvUKaq3d BdcopA2x8ormvGQAFAd9ufQQjrhagiWa4fchSYPDP9I309eRtiHh5+2oaHWfbSaZrncan6ckEGu 8/0NcL+kKATxARbe7lyMkpGeyAA/RZE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE1MCBTYWx0ZWRfX2PPK5qGWvKHl LBcSUcW+XXJekWU4s1NSbpXGYLHac3kIqwXzTM84ZOl3H+TQm2kpqn5z2QLMhsr5eoqvGaQBR6J UB2LSAy/KnWMRJEzAdJlN+drEmPmORvMWwetJK9h81a+fgT0gAIddap5Jnxig+IjhbkuBN5vScs A8SU90rcT7hoTwwQ87IUJVtI71s/vpCik7x6UO16xIr+aEGszCvj0v4T/IJ7PpmGE6ryXekvNKy i6lW0+/mWeLNGfwSGH5ZLO13OkTmM2XwSU4F2LjlelSgzCrDDBUKDb8zykFlTVnfUA9dGbMvD+M Nf54AIkDScxPNq9TnW44yQObD5QTaWxVjI0kQ7X0WvT53U81eJ6nJSjs2NoczfEnsVm3a2OiNX+ jACkpLWTpVwXmcun/tme1warGZn1hSCuJDMTxMmwAY6qLU8/wTSSPQpveCE1gQ5uGv0YPFNeDZP heBR8xhAhTYoBLePmQA== X-Authority-Analysis: v=2.4 cv=NcTWEWD4 c=1 sm=1 tr=0 ts=6a5a4050 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Ya-8ghbQ4qwRuljleqkA:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: vSvULSNWaej7Von_iI_yt0hzFDw3KXLz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_04,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170150 qcom_domain->pgtbl_ops was assigned after mutex_unlock(). Another thread calling qcom_iommu_init_domain() would see qcom_domain->iommu already set (domain fully initialized) and skip re-initialization under the mutex. If it then called qcom_iommu_map() before the first thread set pgtbl_ops, it would observe a NULL ops pointer and return -ENODEV for valid mappings. Move the assignment to before mutex_unlock() so that once the mutex is released the domain is fully visible to concurrent operations. Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 222bb7febd03..ecde5ca2d476 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -306,13 +306,12 @@ static int qcom_iommu_init_domain(struct iommu_domain *domain, ctx->domain = domain; } - mutex_unlock(&qcom_domain->init_mutex); - /* Publish page table ops for map/unmap */ qcom_domain->pgtbl_ops = pgtbl_ops; - return 0; + mutex_unlock(&qcom_domain->init_mutex); + return 0; out_clear_iommu: free_io_pgtable_ops(pgtbl_ops); qcom_domain->iommu = NULL; -- 2.53.0