From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97892282F3F
	for <linux-kernel@vger.kernel.org>; Fri, 17 Jul 2026 12:29:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784291370; cv=none; b=rOBo4/TMs3KAkqMHP/OUVoP9SkHlhWO91lcPm983N/ABx/W8u3z9EQUFXkKly6CQZFVW/E3k6acPde5x0Vx3CMA5idhGkYtR2VapnBApRXzCSUQUtkg8baDE76QIWVO8oX8QCgnSObV32p/rv5Cs+81+mZn93kig5k/Fh8VZDx4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784291370; c=relaxed/simple;
	bh=FACKv3rmEGbd4IdD5xe1ib/M27CBavreo/RgqcPVU+Q=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=u7dUqtLg2o8BpE4/aDlNrFUAA2NCiX03US2LnC/maEg5Ztb4URfWiMaQoyJQBTt47mKM3Jj5aMe0fREJMFfibx/3CrcK6sUsj7xbDwykKgxzxbuyGqk05sFA0n32peK4jwZuEyEWugPyroofMB6sdhlH3ecO4j+ELjotsHB5nyU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kbAjndS9; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kbAjndS9"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A49FD1F000E9;
	Fri, 17 Jul 2026 12:29:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org;
	s=korg; t=1784291369;
	bh=7Ni31vMLxScW2nCLxIZvYk2YkcjtXuMKSxiANOz0XQY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=kbAjndS9D2PEECz0WHaO1DyhIxflOq3aSNMuHnu0n/cw/0F4JXf0spHsdDimqRulT
	 Gg1IVmLF6MluzxtXmPBxDRNvZdIaLsjYOB0l3dO9pTX26bUHwhmQerI6yRRDUFMQHC
	 vQ/qTqGHY97HCJnahHxilo61nTcSJcR3QqHR6IXM=
Date: Fri, 17 Jul 2026 14:29:21 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tony Btw <tony@tonybtw.com>
Cc: Dave Penkler <dpenkler@gmail.com>, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Dan Carpenter <error27@gmail.com>, stable <stable@kernel.org>
Subject: Re: [PATCH] gpib: ines: fix I/O region leak in ines_isa_attach()
 error path
Message-ID: <2026071715-matriarch-pajamas-843b@gregkh>
References: <20260527183225.1307330-1-tony@tonybtw.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260527183225.1307330-1-tony@tonybtw.com>

On Wed, May 27, 2026 at 11:32:25AM -0700, Tony Btw wrote:
> If request_irq() fails after request_region() has succeeded,
> ines_isa_attach() returns without releasing the I/O region. This
> leaks the region and prevents a subsequent attach attempt from
> acquiring it.
> 
> Release the region on the failure path.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202605271229.d8wGTffx-lkp@intel.com/
> Fixes: e6ab504633e4 ("staging: gpib: Destage gpib")
> Cc: stable <stable@kernel.org>
> Signed-off-by: Tony Btw <tony@tonybtw.com>

Need a real name please.