From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28E573EFD2E for ; Fri, 17 Jul 2026 11:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286892; cv=none; b=nzgpgrosiodPTAxKJZW67zX1IwJ4tsts1u6i0stVjtKdRNKLDXJPJFi99vxvSgG3qXkyrUyt9KF6cjiq0t+Odf9hHuZ4Tdfk7OZgb+Zjthn7LH45Vuluw8Yi16xjdVU8KdyWMb0FZvqd348Ow8wufVT9Rnov/88P7Il0vMw6RBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286892; c=relaxed/simple; bh=2GSUpULzoCr69NjexmBoYoSEOTO6brLmNPYKsMibUgk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OJ/vGhfNYlEPRoj7/vTaaGZFRQZ6bIVmKBQriAbVEBRcG4NDM+M90vl3pq1fgMikKyQ64k1NLIndrcGHTdb2hGM5cSZyRsQoyo/4FkJrbYh6d0om1CORd9Thi4/mDvUJSLAiBU5Ojmb6gFxasr9GTO1MVknCOxrv8AkVBELN1ZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=u2sh07hI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="u2sh07hI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6BE81F000E9; Fri, 17 Jul 2026 11:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784286885; bh=yFxck1SUBYI8Vt+jUa4nr8EhHVbB9ZoZutGhQipUfGc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=u2sh07hIOfx1AocP3JVa5FXWjYaM4WfQBPEwkML89CDO3rJHzvsCmgKwzy0edq5gL t6SqYMW6Mg3qdZ0HOeRCaiy2LDPsfITqYqtG2/TEO6bGzeYyD59BeSuMGweunXaiz5 kW5NF9WWZ5FVWJLLMeVaHdeSweaco24ujaWM6BcU= Date: Fri, 17 Jul 2026 13:14:37 +0200 From: Greg Kroah-Hartman To: Yousef Alhouseen Cc: Alexander Graf , The AWS Nitro Enclaves Team , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio: nsm: fix raw ioctl copy error path Message-ID: <2026071716-reshoot-subsidize-98bf@gregkh> References: <20260624173501.4094-1-alhouseenyousef@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624173501.4094-1-alhouseenyousef@gmail.com> On Wed, Jun 24, 2026 at 07:35:01PM +0200, Yousef Alhouseen wrote: > nsm_dev_ioctl() uses a common exit path which unlocks nsm->lock. > > A failed copy_from_user() reaches that path before the mutex is locked. > > Return -EFAULT directly for that pre-lock failure. > > Signed-off-by: Yousef Alhouseen > --- > drivers/misc/nsm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) The subject says "virtio" yet that is not what this driver is :( Can you fix that up and resend? thanks, greg k-h