From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08F7379C24 for ; Fri, 17 Jul 2026 17:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784310632; cv=none; b=ua1iDhbqtCHkhoRZXxtx1WrdvDXfV25WGqvAUur5Li9pCmFQg7hfRmZehz0ctLQIGtCePoDP3URst2A0TwOlwPOxFsI70DJHAwv71izZ43uq+wnm/IxwcY4wIy2706NZOmjO2RES0PHCENc2w1H+Fem3cSWISUYGAmJx9olkkgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784310632; c=relaxed/simple; bh=NNEIZKXo9Gk0gdXnGdTbnSnR3Wi7bJIrBopUTtp6W74=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A9MxP8JJ0UwoqlobTa1fnRCXNi/O7nLtw2hzcOPVFj0gGt7YF1NqQWeHbqo3yT35v0cNp3c8wINYytxa7VVQ6UxHDVHXGiDFQZFMtNDAxg6wPvfkdXi1NcykeHrexcmMp7tQVaIobnBjcQ7t8Ncwumrne+OYiVBbBfmFTdvSZJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MPUKznDm; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MPUKznDm" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so1392791a12.0 for ; Fri, 17 Jul 2026 10:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784310630; x=1784915430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P50P6HDMmVOibCPLHmatcmF4wTn2RT68qvoNI7ZMC3A=; b=MPUKznDmRm4c40aiTtlrMLogvB/PfljLACHol1g1e9o8yt5YhcmzfW+VUDXjSEsKf4 xFFycl1iXdAijloWFGkCn79DjU6oKTYWS8yHwWWCagXJtH3800yfB1cWuuXIN+Sj9gX2 EgcCaSXqHDdb1P7E5oDuQWyQ4mR0gJu3GOZyrrBXa0f9+Vuoi5xPbDdgRyj0nrUrRJMP k5U/+L7iTpGFfhy87fawddkUHpuuWCJ7zDfMA2NerwL88SOdvWr4Dj79g8TjkzX1c41T lQRde+1NvNefOFA1Xdo+R/ml8ZfsO16TVRsW0ISgu3DLOu06q5X/werstTqc9ppbNab3 Ii/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784310630; x=1784915430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=P50P6HDMmVOibCPLHmatcmF4wTn2RT68qvoNI7ZMC3A=; b=AxYExOjgRVfvNdoSRbdikh85/1IoChCjUo7e7JU2GV5JnaSuzXw/8atPFZFzVt4zNd y1/iX9VjMgzCzlhu7suz/ugls+U/VgRe5AT8Qa2G50CYmYP4FAqaQqs8AiAiEs4t5vXn qD0DGoXXTerN4c4VQf/Z3ehkFFwRAseChU1tsf5Swdgq2CaN4PU6wd26dgk/0kYk6DYJ SJzLks7jxm/z8dmSTts1Pt6Z9Ml/xf1TsMFRmUgOOkWeYvb/S5CulAURpqGNhI7cdEbi 5K/Y6RSI+r4uo0GqqSmp3nr7JiXqe9Ydu2CE6N8Bam18/6YvTn1i2P9s1wXT6qzGYo88 1JJQ== X-Forwarded-Encrypted: i=1; AHgh+RqwUNNIBMZ7yC0R7OkckXMoq0yUiQKFFOt06V9zlR0wuAJq2vOi1D3JCx/Kq4yKIV7wMlFZ/B73v2KER6M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpn/8cv86pR6uA7tsZkUGc4RTA3XriQNzoOBonYTrPdwncQUMg CtQroXFUBlSD3CDxdIK1i3lbCWftQ0GYTsIlVH0dpnoBzScJuoxOH+Nk X-Gm-Gg: AfdE7cm64+8umUONytnxoTOJqRtFFjslGc/150lff+cioh2b17Vjn0Rnxt3qft/zV81 fsoZM5YnE4hfUh4Y+J8ggRuQqUNxcd6TV7B2qWU+CRmrnXvwphSfjU/zI1nVtm8C6jiwwivwYx9 oSjo0oJX/tBbC+bdmvwzzPmCofryu6dzJ+VzaLcFK30Bs41GJPWNet3DEnRVQqxVPV/Q2E5BD60 WrdbDU6YVNuWYNMwzpb5lUEx8dyrmCUIq1vvT8eUdJj9C9hE/nskmI93Sej9FMyKpg7ktkF9053 1Oxl+7KNlZDXcSGd31kp0jV0feffTsyQL6k7eWUNblIB09WBnVoHgKm2ZhOgZKrXss0YI0yFaPq 7nunNeeaZlORPpSSeyhVNKKNq6a8dqe6XTbQA4cspgrrO0VZu64ckHg0O3+dyeVtd2V+t1d2cao 0G9jeR478MP0xN854sKFtUzOBzFHxLxtmX X-Received: by 2002:a05:6a20:7484:b0:3b3:3506:cf3f with SMTP id adf61e73a8af0-3c38d8cf13dmr8712801637.1.1784310630009; Fri, 17 Jul 2026 10:50:30 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce2cd764fsm7634392c88.12.2026.07.17.10.50.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 17 Jul 2026 10:50:29 -0700 (PDT) From: Biren Pandya To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v3] iio: gyro: mpu3050: fix runtime PM leak when enabling trigger fails Date: Fri, 17 Jul 2026 23:20:22 +0530 Message-ID: <20260717175021.70834-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614071549.81920-3-birenpandya@gmail.com> References: <20260614071549.81920-3-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mpu3050_drdy_trigger_set_state() calls pm_runtime_get_sync() when the trigger is enabled, but several error paths in the enable branch return directly without dropping the usage counter again. pm_runtime_get_sync() increments the usage counter, so every failed enable leaks a runtime PM reference and the device can no longer autosuspend. The driver state flag hw_irq_trigger is also left set after a failed enable. Jump to a common error label that drops the reference and clears hw_irq_trigger, mirroring the disable path. The success path deliberately keeps the reference, as the device must stay resumed while the trigger is active. Signed-off-by: Biren Pandya Assisted-by: Claude:claude-opus-4-8 coccinelle --- drivers/iio/gyro/mpu3050-core.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index d84e04e4b4314..1f23e700a0dae 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -761,7 +761,7 @@ static const struct iio_info mpu3050_info = { .attrs = &mpu3050_attribute_group, }; -/** +/* * mpu3050_read_mem() - read MPU-3050 internal memory * @mpu3050: device to read from * @bank: target bank @@ -994,14 +994,14 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, /* Disable all things in the FIFO */ ret = regmap_write(mpu3050->map, MPU3050_FIFO_EN, 0); if (ret) - return ret; + goto err_power_down; /* Reset and enable the FIFO */ ret = regmap_set_bits(mpu3050->map, MPU3050_USR_CTRL, MPU3050_USR_CTRL_FIFO_EN | MPU3050_USR_CTRL_FIFO_RST); if (ret) - return ret; + goto err_power_down; mpu3050->pending_fifo_footer = false; @@ -1013,12 +1013,12 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, MPU3050_FIFO_EN_GYRO_ZOUT | MPU3050_FIFO_EN_FOOTER); if (ret) - return ret; + goto err_power_down; /* Configure the sample engine */ ret = mpu3050_start_sampling(mpu3050); if (ret) - return ret; + goto err_power_down; /* Clear IRQ flag */ ret = regmap_read(mpu3050->map, MPU3050_INT_STATUS, &val); @@ -1037,10 +1037,16 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, ret = regmap_write(mpu3050->map, MPU3050_INT_CFG, val); if (ret) - return ret; + goto err_power_down; } return 0; + +err_power_down: + pm_runtime_put_autosuspend(mpu3050->dev); + mpu3050->hw_irq_trigger = false; + + return ret; } static const struct iio_trigger_ops mpu3050_trigger_ops = { -- 2.50.1 (Apple Git-155)