From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18F031714A for ; Fri, 17 Jul 2026 18:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784311856; cv=none; b=I8Brdhda1x0K475TBR4LZ1FIr2x5ZEgS/h6x6gmTdMK6RsK7vjkDa64lS9WYJHadGRI+ZD3uWaUfqQl98qHNZFkUMggGnUgsC1Vl/V5CbniJnHebZH1+82N6YvvlzA7uUm1AOMy3lB71C9T6ycYSQzWEqw02jIprYaSXQsgiP6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784311856; c=relaxed/simple; bh=bX8NLRtes9kGdXkVlJaJW/CPhYxygJmJvj/HPFkFD3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pUGbDP77pCw8822vFyvyB8AK6yjbycXv9nCKSPK1zxP66aCRuR57UepI1CusECHDjTJBpYIGHqEHwQeNtvbVf3g/HDp1pPhYbAPtjLYh0svqScU3+N8i7UR3aZeHO25F4xJenLnSixzUuIn9liNrPnYEJ0dUDdV5hcj3HHtOyeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hAetVf3x; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hAetVf3x" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-ca913a601fbso5597461a12.3 for ; Fri, 17 Jul 2026 11:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784311854; x=1784916654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dTCHiwT2E10d/HI/axutsBD0+RAwI0EPUJ73rBwlA7E=; b=hAetVf3xwvnYwxEF6lxVqxyfao0r5jK7DjwCPdz8uQ+hapKbsuD+UPZt9/EdKk871H DbIjx6mTKnA/2bZ+EIOjgGMnMRr7jGAIVxO2zf7sUQItHWFkD1goLd3v71SBNNA5Nt/i iIsx3iYF4IjVFg8Flsmvz0S9dGoGgA2LRlE/addqQm/fIbnYhK/RBQryLmEhtFfJC9wk qEij7xJR+DeR6lp1p9pcZDDw9Mpsc/HKcuZ4xNAgpSm/QlVFf3P2Ns9lTkqf03gBxGQm WGxP5hocZhWljErHX5dXIJNNu0zTSNVoC0FL+pozGPtaSfJqpt8XqEkYA7BLCpONICs+ pa1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784311854; x=1784916654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dTCHiwT2E10d/HI/axutsBD0+RAwI0EPUJ73rBwlA7E=; b=IhwX606KOa0zNBCHA+XV+BBeKKDgLWYKw70BxBQ6PuZmNZyip4PQNVnGM3W9SCX1G0 3Rmutf0a6BEbUjKktko18FPlg1qMCjPopBug2pUsWZWo86JxSX2XkfoVMBXvKtAzD4PF EAwoBfjh6cueGVeatrH5H33L3e0k0OLSgJOMKP8bprwCvaZnGeFRsfH7IaR/4p2cjg8H K6jdjvjC4ydr8K9u62lza9qBLODUuCP3AIAAFIouZm7KoM7tx/vR0Ax0wzGq0fiHtTYi X5MH12YOKtHH41S9I7f9YAmiDA/jaoECm9sQkJWUi9lMDnmKrpBUl/LzTJBRcLh5owhu SLDQ== X-Forwarded-Encrypted: i=1; AHgh+RpQ+rhgJK9s+10vYOTHa9rhHEIaSaSd4IFZd6GfCK0FSdl3Tec4+6sjxx8kVg8s1eqKEP5iOYR8fWCVl/o=@vger.kernel.org X-Gm-Message-State: AOJu0YyBV1e7JevsTcvWdLEMoa2SuUUFJ9PUkZapKb+htclnvhiI4c7q oNdeqIzGAeMdILH2QwdOhV0iCqHJs64w6t8cpGGdEyq7ekAyq1GUMgFc X-Gm-Gg: AfdE7cndeJXJ/dTJT4nLPg0bZqI2CNoo7E+VO85nbMh7+GYVEc3tpESYKMy7a0LHP4F DGqeDUQYR1J3HGetX9WPE5QMQZ9jaT4YFxL5yf9/O+3nsnd9hmHNbx2RyhA5D2yiryzIHT+xaFt cnG9n7xFeVoZqrEoak0Wqvke92enHvJMSZHuzsxe8wpjwTy5Ed7gU1xSYDckYUAuBldOqNG5gpv Vaea1sFNszYpf60tQqecrAsPfOk/I1qfq/O5AjeetBMIlVBwy3S6lDyrHFLrSkXotySQ8z2wYdl /qdaonhoPDeH9ZVmVpUypeKVCFIF/fJjGvS/J++mLsSSRcNl9iYmdz7xxNU99261GpZ/fLDE1ku /TmA3/JIABzEO0u9FLoHa4/fi5DhArpkCJGlIQJUMYlXP9kdc5nFEuRECjh960FnUjhwkFQskXo pZynMZcAjOs0ww45rnrU0Or9gz2u5kbNpZ X-Received: by 2002:a05:6a21:4584:b0:3b4:61f:1fec with SMTP id adf61e73a8af0-3c3ad5d572dmr4502171637.2.1784311854063; Fri, 17 Jul 2026 11:10:54 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce2900a37sm7460574c88.0.2026.07.17.11.10.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 17 Jul 2026 11:10:53 -0700 (PDT) From: Biren Pandya To: Linus Walleij , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH v4] iio: gyro: mpu3050: fix runtime PM leak when enabling trigger fails Date: Fri, 17 Jul 2026 23:40:48 +0530 Message-ID: <20260717181047.72309-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260614071549.81920-3-birenpandya@gmail.com> References: <20260614071549.81920-3-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mpu3050_drdy_trigger_set_state() calls pm_runtime_get_sync() when the trigger is enabled, but several error paths in the enable branch return directly without dropping the usage counter again. pm_runtime_get_sync() increments the usage counter, so every failed enable leaks a runtime PM reference and the device can no longer autosuspend. The driver state flag hw_irq_trigger is also left set after a failed enable. Jump to a common error label that drops the reference and clears hw_irq_trigger, mirroring the disable path. The success path deliberately keeps the reference, as the device must stay resumed while the trigger is active. Signed-off-by: Biren Pandya --- Changes in v4: - Reverted stray change converting `mpu3050_read_mem()` kernel-doc to a regular comment. - Dropped AI assistance tag from the commit message. Changes in v3: - Changed to a unified error label instead of individual drops. Changes in v2: - Fixed a missed PM release in the first error branch. drivers/iio/gyro/mpu3050-core.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index d84e04e4b4314..783be9a786df0 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -994,14 +994,14 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, /* Disable all things in the FIFO */ ret = regmap_write(mpu3050->map, MPU3050_FIFO_EN, 0); if (ret) - return ret; + goto err_power_down; /* Reset and enable the FIFO */ ret = regmap_set_bits(mpu3050->map, MPU3050_USR_CTRL, MPU3050_USR_CTRL_FIFO_EN | MPU3050_USR_CTRL_FIFO_RST); if (ret) - return ret; + goto err_power_down; mpu3050->pending_fifo_footer = false; @@ -1013,12 +1013,12 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, MPU3050_FIFO_EN_GYRO_ZOUT | MPU3050_FIFO_EN_FOOTER); if (ret) - return ret; + goto err_power_down; /* Configure the sample engine */ ret = mpu3050_start_sampling(mpu3050); if (ret) - return ret; + goto err_power_down; /* Clear IRQ flag */ ret = regmap_read(mpu3050->map, MPU3050_INT_STATUS, &val); @@ -1037,10 +1037,16 @@ static int mpu3050_drdy_trigger_set_state(struct iio_trigger *trig, ret = regmap_write(mpu3050->map, MPU3050_INT_CFG, val); if (ret) - return ret; + goto err_power_down; } return 0; + +err_power_down: + pm_runtime_put_autosuspend(mpu3050->dev); + mpu3050->hw_irq_trigger = false; + + return ret; } static const struct iio_trigger_ops mpu3050_trigger_ops = { -- 2.50.1 (Apple Git-155)