From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28035383C6E for ; Fri, 17 Jul 2026 18:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784313062; cv=none; b=GjEPPS1ISAVjxu2NdYIvD/SHBiKpp49p1sAk7i2z6zZZIMiPBrsVvyJ9jYZP5ffPfWk43NkU0n/sW32tcxTdexKMAq46hiDuimZavE8iFtjzpUlCfxoh/6BciOFDkuI/LYuquYOQMEYdiKFbQo7hi1/T/zneIZR5gd7uwOqQeSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784313062; c=relaxed/simple; bh=1F1SE1lLP/oS3nzGeTd/9IBL0aREwzGS+Bo3bJtQMdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CjO2j+0a2Ua/eiWZOdBNcHbgMOyc6dfmovXlYwj2mYfH01ZUKeS04dZsMIlvxL4JMWEjOuZu2NX8uSCBJLUhcB+GeatHhnUxiH3OoYu+mf0bHN1lj0kR0mb/NLzojJgxqgMFa9PrK25Gq3lYxA84JmQrMJY3UJXAFm1t6M6vHH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iWgHjMRI; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iWgHjMRI" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8453427d3f4so7538487b3a.3 for ; Fri, 17 Jul 2026 11:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784313060; x=1784917860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=joB5XdEMkRYTFOe6oQxV2wUDblqkRFAT1rpZftZWDv8=; b=iWgHjMRIPkaIn4MXMafrXPVtrV0PJ9oxpFzbeYQP69MD7ZTZhiWr9UHtGVvIFKkxtp 2rfFcuoUEmgftCRUj72UMOmUoLKrCTKS4t/hyax9Uc7MEkcznn3lZdKgyYYpTvWSJvUf 7FQsHep0n5WOsph2AyyaA6tV29yWhsxfDLaHjPPeIlELH6Vi5NM+zf/ZbEpbuwDV1Mf4 0tZGZEsKJB+wEcs6kMnkEOgsWm5F9H+RR3i37fDrscwhsm1yalZYdWkgyn1plksLaFK5 oeN1kwoT06E21PUYrUFaAeGfKjqcngQJdKQ+QT0/TVrCWPhvcqP16dC+AJ4ZVZgZyOj3 vvmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784313060; x=1784917860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=joB5XdEMkRYTFOe6oQxV2wUDblqkRFAT1rpZftZWDv8=; b=NOar+OV2lXUNf7LdwYQuTPUKqeoc5CoowWjhDDz3OzcdhgCOnjzdvrUGz0yhToDm26 c/lEfN0YW7Pd6OSrAQubumjkeTUXTM0otQ8mV1kUG3fNCLMQGjDZaak9MXyHzUijljwU Kfenp5+GddhjLb58jWEjY7U/C0/9Wo9tY/KfM/Y2O+4bYksahWGeoZ212F5T8TZDsJ6W zBxY3dNIY0FWE/liNWqOIsFH4Ah6oufbiwETVfemnKdKF7TiITO+QNeYvc1KQ2xnjBxH qRvtEt4TUQcjYpKi3ySQUVH2CJ031vLbHBzN/p84GLVqq9owaf59212N5DPIaUW7AzYR lGsg== X-Forwarded-Encrypted: i=1; AHgh+Rrqka/TzEnHB1b9XRMJqXGn1uJZOkWBsWA7sT25Y9wUnmAd+lF0WXyypBUJeNbRdxipKBZ7G7zSn0Ymt4o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+SJeEE1bsL2dVQQcTqgpIic895FAEkZ+TcMCKEkxxhSRez23g NsVA96AX1NPH9no+hmzrEdEEipr3vyOEOLkv83SQTKhKOykTZbXUlEGD X-Gm-Gg: AfdE7clfSGCozWD+9BvnPhcty++B9WQK75iik/SqoBT6i0QDK86TwgQBWzCAL3S196a v9dxjW1e1DQZ+bLyzP2KcYgnokst28XHwCM4TqmUx3AUUYjP7xIEPa4/sxBwRViL+/i1J5G2QHQ t5UZ1CE6plOXoNK2gYERAvnmG5YqvRhyTtTnxXoItR3rupp3ytb3tEFFaJHCB0/UhUXBmiZjztO Hp34BFshC0imISWAoOk0uJovGBeMjCg/5Zhp05g97jbODkxxUDxNd0qX+Y+mPW5NEEe484g8ix8 0R0hi+LreEEBSMKB+bEh5ocg+Vlr2/RlgcwtXwd5FZjklKeRtRPu30HhFp6seY22k+lOBBtIWhH Fnn3syaMBHAj1o9i+HrmFrWEorbhmlejLIOd2kOit1q/i4aZiPvIjURHtkkv9S5gQ+bH4QpnL7l IqdwnFfPfq/pYyWUmc3MTuH29281Eu9eS0mHh1BA== X-Received: by 2002:a05:6a00:17a0:b0:842:706e:ad43 with SMTP id d2e1a72fcca58-84c292ef527mr4052683b3a.33.1784313060471; Fri, 17 Jul 2026 11:31:00 -0700 (PDT) Received: from kimi-bug-hunter.. ([8.219.140.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2afd07e2sm1565255b3a.61.2026.07.17.11.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 11:30:59 -0700 (PDT) From: Weiming Shi To: Jon Maloy , Tung Nguyen , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Cc: Xiang Mei , Weiming Shi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net v5 2/2] tipc: fix node reference leak when defer work is already pending Date: Sat, 18 Jul 2026 02:30:46 +0800 Message-ID: <20260717183047.2725959-3-bestswngs@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717183047.2725959-1-bestswngs@gmail.com> References: <20260717183047.2725959-1-bestswngs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In tipc_node_write_unlock(), TIPC_NOTIFY_NODE_UP with an empty cluster_scope takes a node reference and schedules n->work. If the link flaps down and up while that work is still pending, the next NODE_UP takes another reference, but schedule_work() returns false and the extra reference is never dropped. The tipc_node structure leaks. Verified by flapping the bearer while the work is pending: one reference is leaked per repeated NODE_UP, while the work is put only once when it finally runs. Drop the reference when the work was already queued. Reported-by: Xiang Mei Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Weiming Shi --- net/tipc/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index b545a47d6ccb..428c4eacd02f 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -447,7 +447,8 @@ static void tipc_node_write_unlock(struct tipc_node *n) /* Defer bulk distribution to work queue */ if (rc > 0) { tipc_node_get(n); - schedule_work(&n->work); + if (!schedule_work(&n->work)) + tipc_node_put(n); } else if (rc < 0) { /* Bring the link down to start over bulk distribution * when the link is up again. -- 2.43.0