From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A7E35DA79 for ; Fri, 17 Jul 2026 19:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784315185; cv=none; b=OR+H7EQHoJpeZK6utbXxLXu7WPgXZLP7nmjP17KV4c6pVdavS890XqCmJidFixIIcC/CaRmJcR1H0mJEGq33zovZKre2khjwZI7O0pZu+AkGGijTO+WzTBXpUa8W0zDTO59EiZlmxdPeyN06MV1CixLU+hMc0jau8QCK6Z2ml50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784315185; c=relaxed/simple; bh=nWMgcy9zH/zCGg85IYNWf4KjnH9+fNVSaaVmgPl1xDM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Lxbp8TymyGIdFAjGIg9hVAjrobRtdpUpH1LqufQ7EMTE3U3cr4+I47Oya+0UXfv7uZ0ku190dXAWWLkeQJef4fzxi/LRd9CFCPWza7B+gCqJGIooOpGpo+vbKABjzAhRcVRUmSLt5BQTnGtWwbu9x5Ogz3qLL57JQ3lNbMECFoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gkE3hNG2; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gkE3hNG2" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8e5be46f663so32731106d6.0 for ; Fri, 17 Jul 2026 12:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784315182; x=1784919982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ErOSeJ2Za9/1ZgC4ztqnYtsxKhikz8KNOMoALAHDxVY=; b=gkE3hNG2ux1nHj9OT+vByI94BA/1KfE4Vmxdqq8u9Eg7ScUJ1MNG8owDvs/Ni2BxP6 XxvrqYSapwhErJb+afcpCGpyjPI0kEUYu8QsJ5JDbElAgQaLAHBS2kFdDwzgw0BtFOnT VP/bIiMJ8Viq4UUyZhGq7iEIRWj5h6v/JmQYLZUw6MMnnfHfUnkw9l7AeppjszGOfiUb A34kDASA9mz3FHPU1xVcjYBm3izAhB/utLYg5yGW10hGXhed/2lD9BSAwGM4Kw1ltawp cPMlsSkifgh+yV+fKi5Z1EnnjY96hyDBYGnVgNIpi4sukB7AYHkaAKWcoXp7Z6okvjbo LDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315182; x=1784919982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ErOSeJ2Za9/1ZgC4ztqnYtsxKhikz8KNOMoALAHDxVY=; b=ICIPCF9PFww0zSY1t/aruDAVqZP/Q2vGgnUrjFZyW5Z4Hu3/eYe/rUVVeeLs+YuLNZ wafcWDDwkfl5+nCRcTFrScKJ4OX94CwbEGHwWmCxTjYIAP0GYmxm8bxNbkyWW6wKbkGq CnvMS988w6+/+Vbe8oMglQOqO4PEHFZ7+WupubU/CBzlUa+wIgb24kOIJkUvUxQ0UCon Vhsgr7PVCTSXN5fKyQeZ8Q7cV4w2b4xCv/3GBS4zugsWqlXjLa3l6ts/Tor5rp3cAmse vcqTMZqIvYZMnH5LbzXjvd+Z8RLN4d+mEjUOImbW6pVOqEoCBLCs4OrME9RVBRPPBcAu 9IsA== X-Forwarded-Encrypted: i=1; AHgh+Roe1QLvSsj/jK71MKZzAypiOveG7YUYm42EaBZFsPmRNvYatnzyH8WPNHJ29jkDIC2Mee3k2mQZvuU19tc=@vger.kernel.org X-Gm-Message-State: AOJu0Yww+UAUbLEhv11jqkiqiPFEOH55UQNQ8j7b6hG2bgBv9UhhK0ib CnM8cVez+aLdRQL3mPwAfsDT/oWfNamAhqSjR/NyNUwDDQ6aKTaPy6zv X-Gm-Gg: AfdE7cnJ+zXlCBLc9bRtbxQL5BHVwY/LS+uOhmqBX0M7E7veD9GqsC/9Rs+w/BYQLv9 qPuzdEUmffq5F/7pSz/s6tV7Pnwi9oVfiQuTvWTQsNVQv4DStKi59bmNSU2Re8sqE7XpNZdk1/e 7HMkZNxPi/YVq1ZODLzWRfPguAtiyKLIF4HhdgXfFJF0aISVF9lnlTtfInYsy0r8HmEZtNrySkl oAaR9nXnzS7v0x7YRZV/pt27Ra9iSqruA2bORJhT+eblZ03y2XSSLHW2RpIn8gkHjN7kzcb50jT 3RxFUDa91X4hBmpcsYL5j/chUwsNK25ZJNKJFhjK3BBiSyL33v4UIhACQe/qiUw7PclPZ+k1csR fco9ZthVa7l62ItZb1Nge27+d5q3XcQDB4dNg8tZsBRL/jix3wUzacNYCzhbEgI6QYn1/Kl82XS wNTf/WNPb+ X-Received: by 2002:a05:6214:449e:b0:8fd:6de3:dd8b with SMTP id 6a1803df08f44-9077850ed21mr41084416d6.65.1784315182204; Fri, 17 Jul 2026 12:06:22 -0700 (PDT) Received: from TurinLinux.. ([184.144.109.221]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9077871d06csm24035606d6.43.2026.07.17.12.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:06:20 -0700 (PDT) From: Nicholas Dudar To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, deller@gmx.de, James.Bottomley@HansenPartnership.com Cc: bpf@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, visitorckw@gmail.com Subject: [PATCH bpf-next 2/2] bpf, parisc: Add support for BPF_SDIV and BPF_SMOD in the parisc32 JIT Date: Fri, 17 Jul 2026 15:05:44 -0400 Message-Id: <20260717190544.257306-3-main.kalliope@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717190544.257306-1-main.kalliope@gmail.com> References: <20260717190544.257306-1-main.kalliope@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit emit_alu_r32() and emit_alu_r64() call the unsigned millicode ($$divU/$$remU) and libgcc-style (hppa_div64()/hppa_div64_rem()) divide/remainder helpers for BPF_DIV and BPF_MOD regardless of the BPF instruction's signedness, so the parisc32 JIT does not implement signed BPF_SDIV and BPF_SMOD (off == 1). Signed ALU32 and ALU64 div/mod get an unsigned quotient and remainder rather than the verifier's and the interpreter's signed result for negative operands. Thread is_signed = (insn->off == 1) through emit_alu_r32()/ emit_alu_r64(), and on the signed path use the $$divI/$$remI signed millicode routines (32-bit) or the hppa_sdiv64()/hppa_sdiv64_rem() helpers added in patch 1 (64-bit) instead of their unsigned counterparts. $$divI and $$remI are extern-declared and exported next to $$divU/$$remU in arch/parisc/kernel/parisc_ksyms.c. bpf_do_misc_fixups() rewrites the zero-divisor and INT_MIN/-1 cases out of the instruction stream before the JIT runs. Signed-off-by: Nicholas Dudar Assisted-by: Claude:claude-opus-4-8 --- arch/parisc/net/bpf_jit_comp32.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/arch/parisc/net/bpf_jit_comp32.c b/arch/parisc/net/bpf_jit_comp32.c index 5ff0cf925fe9..eea0a34a3bfe 100644 --- a/arch/parisc/net/bpf_jit_comp32.c +++ b/arch/parisc/net/bpf_jit_comp32.c @@ -321,6 +321,8 @@ static void bpf_put_reg32(const s8 *reg, const s8 *src, extern void $$mulI(void); extern void $$divU(void); extern void $$remU(void); +extern void $$divI(void); +extern void $$remI(void); static void emit_call_millicode(void *func, const s8 arg0, const s8 arg1, u8 opcode, struct hppa_jit_context *ctx) @@ -562,12 +564,14 @@ static void emit_alu_i32(const s8 *dst, s32 imm, } static void emit_alu_r64(const s8 *dst, const s8 *src, - struct hppa_jit_context *ctx, const u8 op) + struct hppa_jit_context *ctx, const u8 op, + bool is_signed) { const s8 *tmp1 = regmap[TMP_REG_1]; const s8 *tmp2 = regmap[TMP_REG_2]; const s8 *rd; const s8 *rs = bpf_get_reg64(src, tmp2, ctx); + void *func; if (op == BPF_MOV) rd = bpf_get_reg64_ref(dst, tmp1, false, ctx); @@ -604,10 +608,12 @@ static void emit_alu_r64(const s8 *dst, const s8 *src, emit_call_libgcc_ll(__muldi3, rd, rs, op, ctx); break; case BPF_DIV: - emit_call_libgcc_ll(&hppa_div64, rd, rs, op, ctx); + func = is_signed ? &hppa_sdiv64 : &hppa_div64; + emit_call_libgcc_ll(func, rd, rs, op, ctx); break; case BPF_MOD: - emit_call_libgcc_ll(&hppa_div64_rem, rd, rs, op, ctx); + func = is_signed ? &hppa_sdiv64_rem : &hppa_div64_rem; + emit_call_libgcc_ll(func, rd, rs, op, ctx); break; case BPF_LSH: emit_call_libgcc_ll(__ashldi3, rd, rs, op, ctx); @@ -630,7 +636,8 @@ static void emit_alu_r64(const s8 *dst, const s8 *src, } static void emit_alu_r32(const s8 *dst, const s8 *src, - struct hppa_jit_context *ctx, const u8 op) + struct hppa_jit_context *ctx, const u8 op, + bool is_signed) { const s8 *tmp1 = regmap[TMP_REG_1]; const s8 *tmp2 = regmap[TMP_REG_2]; @@ -666,10 +673,12 @@ static void emit_alu_r32(const s8 *dst, const s8 *src, emit_call_millicode($$mulI, lo(rd), lo(rs), op, ctx); break; case BPF_DIV: - emit_call_millicode($$divU, lo(rd), lo(rs), op, ctx); + emit_call_millicode(is_signed ? $$divI : $$divU, + lo(rd), lo(rs), op, ctx); break; case BPF_MOD: - emit_call_millicode($$remU, lo(rd), lo(rs), op, ctx); + emit_call_millicode(is_signed ? $$remI : $$remU, + lo(rd), lo(rs), op, ctx); break; case BPF_LSH: emit(hppa_subi(0x1f, lo(rs), HPPA_REG_T0), ctx); @@ -1163,12 +1172,12 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct hppa_jit_context *ctx, emit_imm32(tmp2, imm, ctx); src = tmp2; } - emit_alu_r64(dst, src, ctx, BPF_OP(code)); + emit_alu_r64(dst, src, ctx, BPF_OP(code), off == 1); break; /* dst = -dst */ case BPF_ALU64 | BPF_NEG: - emit_alu_r64(dst, tmp2, ctx, BPF_OP(code)); + emit_alu_r64(dst, tmp2, ctx, BPF_OP(code), false); break; case BPF_ALU64 | BPF_MOV | BPF_K: @@ -1211,7 +1220,7 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct hppa_jit_context *ctx, emit_imm32(tmp2, imm, ctx); src = tmp2; } - emit_alu_r32(dst, src, ctx, BPF_OP(code)); + emit_alu_r32(dst, src, ctx, BPF_OP(code), off == 1); break; /* dst = dst OP imm */ @@ -1236,7 +1245,7 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct hppa_jit_context *ctx, * src is ignored---choose tmp2 as a dummy register since it * is not on the stack. */ - emit_alu_r32(dst, tmp2, ctx, BPF_OP(code)); + emit_alu_r32(dst, tmp2, ctx, BPF_OP(code), false); break; /* dst = BSWAP##imm(dst) */ -- 2.34.1