From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D830F3A9DBA for ; Fri, 17 Jul 2026 20:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321352; cv=none; b=Xclx1pcvVZAoVwbCwLV9dzlhEC4YXN8jd/ebGYubSZzcvUo3gBniHAuK/Pln7fbdwwU0Ee172lmOQ/kfXNSxVe3F6GGkBTNHFkYAvvZ5AB44maoszhX7XXaqDgFH/CRbAnBPg8xVc+hoeehnYwyWv+F1xqpZ7eg1RXbOClkkQMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321352; c=relaxed/simple; bh=FEVhhN1Tu7fPtcshXYip5B1GaOhw9gRDyazaGKTnIDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DjAJl73LxNTgMx1stDg/njI7ERxibyn8kTgXw12YFizyER518C12F2YIIYi+vfszZkxhJtCR9NvM4nOo8BG9okMGqa9kvj6579sqmMAbrOpkpiRmd0Tl6PI8SfXb8A3YCWPbieIm4RpnYaIAxpeYDvWO0YwMkJ9RlY5O9tcqh0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SzgWMNtd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Oj6q80f5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SzgWMNtd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Oj6q80f5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtPPm2751693 for ; Fri, 17 Jul 2026 20:49:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=L6JvWLUmlfs jBa14lcBw1BoSx1fLycflHxKxG02lUBQ=; b=SzgWMNtdFSoIESyCO5ht+jZrHyF O5sn/pAv092HvPYZWgrMVeoKHhKhpf34fXHihPIblOapjZRvlQ5/RPiO0MGqFKKt F3WT2T+LyS+pofMxyvDHMMawCa7bVZ4CLnl5Pf4Sdmyr1Md4R7qzHdvqymUObzI8 b8AXf/Be9SIvGpkBmJBXfFPgLzC9NxpSct65KQ0ZWKRQvSveXSXzbu0sH1hdPwoA ECGQi8dQnCHo24mM53GrX7NHJWUMNuTkFX/FLwp7tjSMvMOTUHioUkNghPpPIhNj 5AYJRGRTi2Aw6KWFO3sqYQqsCQQv8ukJv8N44PNLmD3Imww8QXhm4Ko247A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffpug1aws-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 20:49:04 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb48f41343aso1182545a12.1 for ; Fri, 17 Jul 2026 13:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784321344; x=1784926144; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L6JvWLUmlfsjBa14lcBw1BoSx1fLycflHxKxG02lUBQ=; b=Oj6q80f5GFs0ttTACXIyNLmdUWsFK5qTxSdoSXLcNXVBQM5vjgRHtnXYLzvUYzaDy+ g+/YeispnAbCZ5QI1ZNV9n6RxObM3v76a+8sBgYWQG1Nhd1ULe3vvQE/X6eKRVF+qXcS Sa1W2QrSpSYj5mob5ywu0pspzvqVq2xYBBkUkplu0PQTjHW417M36evNk409/HCTIhmC Js47d5Z/r+ByGfcWKUjSSeviGJVjDEsgZlvTGfXBf8reTbbmKWiKU1DzPTEjUayN0Dkb y/hC+NWxaIy2q2lxT+V5aBzRWZnWf258xwxXAjiz0J6m5Sc9hlhZkL45xTpxAfn2o4O/ 5mOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784321344; x=1784926144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=L6JvWLUmlfsjBa14lcBw1BoSx1fLycflHxKxG02lUBQ=; b=Fu4e+iPPLFPJqkttSsPL/R5ZBSmgufGssxXdnygS8CuVqeZVQWEkJ0NOFgUQJuUjoi JlazlY9aKDAhIVYVbDYY9RNazSXgeA4ohAAtmiNpx4sJ20N7ONaIyErOx/Z64qlpmOqo CQkXI+TwfftOpZIrGe+pWGYSUjf9UOpPfbMIOZS9nBKkkE99nU/PjhwO4LTRuAWp8+V4 7P3xD96Azd0Oxpx3LDRcXGpMmKbe9YQy42uvONF7PjRufvl5NUqZNW/UovvRcHs2ibJ/ dNnUgkW23keJbCazi7b1705h8pFr5C3/tHRX7MOXJUoMpg9H+lw6/pkYU8P9M+lqeYje 92QA== X-Forwarded-Encrypted: i=1; AHgh+RrVFeL9z5wfoVm1Ruban4nerX88VeyKXi8hApEFEbxElXD8J4flBk2mp71HGsMGSGqOxRr8qxP5EDOm3r8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4VcsjkNDc0hUlkVR8Dz3hHAFQ4OPz3E6b0QpacQNNaNOHSiio RBAwtWrbTV45rNMjdjYGA00Kr3OEr+utqS0eLKK+pH5QKeLD9C6g5WWzm5q0KRhmEGG7WMyUTKD HUh49AAplki8Ur38/htHe+NXWJnECcd1tjdUKecHcfc9zAO01o8WcuCVkEwFwYSJl0Sg= X-Gm-Gg: AfdE7cmHl6zfqdAG6HQ0hi3sCIa27/6M+ze/wVC4ano8g/yThA+RPx8BfWJ34EajM2c AwEfojHMJTNXmyU4KehV7NAQfjT2nBEkLmA+OyiIbRcA5nhl6k48qKZVV7nWD8GYMKowUf0+le+ DX7xo7TMcAhFcfZPeoxlvId2KGXT96cpY2DBWL+OITgUIKt3J9L3fDyv9nMf6ZvoAJXdkZITLCU ZUsEUDfOV1SQhE8lnLspHCKijTbJlL10dPIJYeC/wrTWuLgJRCFT5q76gKtR4rSd3ilpOFRB1RM bmKljfGuNQR9JSb6AHTQaGbdgywEx8WKs4gLzeTEZ60/M1ja8G7rDm3+KGXB8ui3cpmrbNdVOWv iDid6Ox6tOtw2bPw2HuSp5aWVP9AGHUnxAV+wVAyPocv6nlM= X-Received: by 2002:a17:903:2ac6:b0:2ce:a6a4:451b with SMTP id d9443c01a7336-2cf1f2e71eamr96842915ad.11.1784321343699; Fri, 17 Jul 2026 13:49:03 -0700 (PDT) X-Received: by 2002:a17:903:2ac6:b0:2ce:a6a4:451b with SMTP id d9443c01a7336-2cf1f2e71eamr96842585ad.11.1784321343258; Fri, 17 Jul 2026 13:49:03 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344b1ef8sm17884615ad.21.2026.07.17.13.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 13:49:02 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 09/16] drm/msm/gem: Remove useless locking in GEM import Date: Fri, 17 Jul 2026 13:48:25 -0700 Message-ID: <20260717204841.26120-10-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> References: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfX1p5LOTbDQ65l tWTQPhl9yjo/0OCv1ghhfU4LVHdnLtN2+xdekBGTuItU73bHABumgh+XWmPzzCq1JQbhYlJZtVd OR9u4baG47QybhpClyra0YFFJntZHnj144CO2WSdf7JkSuXslN6quhZCQZJp74p4BOrXckVhVQ8 AGqZUyyuz3yFxcWTdiE8i91Klv+MTs+jC4mwbTusqPjCMaIe27RRVOTTRjqOvPOVHwgfn9MOCZj GP0ESV5PaS0NK+h5nrsQ5AuPIrz+Zo6OSkA22w+j4X6EVfuNiI/T3Kzliy8O+nZ7B74ZD911Hwk ApAxBNLgi0N9nCJWuvubS20uQXiQS9VJhnk4K5jaZh7ivuIxeE0WY3gWimcZwDwsii5fAkkFWS3 cwYORtVdx7CQTHD8Q5BSOT1hQZQ6qTqBa32Pecx2fDLWJDLhECXlwp2blnLGvKdHLU8T3dYKeI+ lSiOrU1kNbHlmFkejrQ== X-Proofpoint-GUID: jkKZSOqQ4fsZkvWEgKLmwyt74GUcQ7mG X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfX2xS3CovxdqFr 2/cB7baNSipIqf4i4jlSiCIj0pri3nHJUy9wxC82GSdNcGpKvAj1Pd6WTVtAw4Icu9WWOw1B6a3 3b62Ratl8CgjljTski7eWJFXoQLMSkY= X-Proofpoint-ORIG-GUID: jkKZSOqQ4fsZkvWEgKLmwyt74GUcQ7mG X-Authority-Analysis: v=2.4 cv=Q63iJY2a c=1 sm=1 tr=0 ts=6a5a9540 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=isCY8TonHXl0-fnU9HAA:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170214 The locking has changed a few times over the years, and this extra locking was the mistake of evolution. Harmless but useless. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index efd3d3c9a449..1aa844ce4f2c 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1301,23 +1301,18 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev, npages = size / PAGE_SIZE; msm_obj = to_msm_bo(obj); - msm_gem_lock(obj); msm_obj->sgt = sgt; msm_obj->pages = kvmalloc_objs(struct page *, npages); if (!msm_obj->pages) { - msm_gem_unlock(obj); ret = -ENOMEM; goto fail; } ret = drm_prime_sg_to_page_array(sgt, msm_obj->pages, npages); if (ret) { - msm_gem_unlock(obj); goto fail; } - msm_gem_unlock(obj); - drm_gem_lru_move_tail(&priv->lru.pinned, obj); mutex_lock(&priv->obj_lock); -- 2.55.0