From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 816AA35E944 for ; Fri, 17 Jul 2026 20:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321359; cv=none; b=gKxLP3EdCq5q0x5Ogpd8cUgbS3foxp2pcTCEXas7vEzrS19+dY4QxikSIDmz3/F0Hm42Bz6UW8wSCYJY2Kxet94cBuV2bhjuW7OrisDWv22mv41NdtfQXC6PK02uDI5AEPRiv3/FWxW0jBoMfQqI+URwddzyEHK9b1kFVP2QqCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321359; c=relaxed/simple; bh=103H7sjaSqTLQYEjwkqUKVVhu8LNhT7rrbQpAMFnKcc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NUJuEJgEuTAV1WBL48ljGa1B3TuJ7x8el77zPw00et/JTTMeN4QBZT4R/wS4jlfrPegTy+nVLX2hR2UQjvSSyJS6S8wp+W4cGaCXNgrNJKv+88ERMqk8+UyEC0HJGw79hvj1KdgMvHtmAmtNEf1AOkUrmmQjv+yatBG5x5zi62M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iXFU0Md6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=USGDIX/U; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iXFU0Md6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="USGDIX/U" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtbpl2906442 for ; Fri, 17 Jul 2026 20:49:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=DA8G+ZNQJ0z SGZowFGnb3Omh257suiDVTqWi0Dh6qc0=; b=iXFU0Md6AWKczwyfoJ68sdt19ip tD9k8pVmC86cWT1lbsw5xmX+LvyUPHYbmFO9LGx4NsqEtvkFuHWoGaY8lblbBxQn AJlJck5MWs3FuenDV10Rjp14Z0mEUUuymcQCxuUnowcHeUTbzcDtRW2Ujyf98WxL wryhSSbGJ/gkq8A61Vp3gEWyiTgtsIeh3i1ZOj4s/70/M+auSrk9Vc5ZJkXsYEtk PVDGInK3cF8dx4/QNfMYS6Tt65uvUc4Mh9GVSz6mVLtrK6nh8cmu2bCybFBo+imP j00i+tvWx9HxLAeRIJlYUzH4PF/m1smTuTumTapsVEyNZJn0fqII59+2mFg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffrsq8rex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 20:49:09 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c890bac374eso19353125a12.1 for ; Fri, 17 Jul 2026 13:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784321348; x=1784926148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DA8G+ZNQJ0zSGZowFGnb3Omh257suiDVTqWi0Dh6qc0=; b=USGDIX/UFggrWthZdw1TciPR6+o0xn7xEbg6qFURsW3JppHA+AL2tTHXEWQ0O8reLw QRnTlLrR1Kn83zkB22FuLpc9FbBg1wu4HjY7RYRqWs2KbU7wZjqLMAPkUj7/m+yYnCpc HhyC+G6D60wBp9QcPc0EWWUlXCxcp3y6k8V++lcfP1fqPM6OtgTBfmNp5tko+6pmjAz7 D8r9c2VxEb4F37islMiJTIoVb0S1F6POkOm5dyrJ3vaTQYxvFJT/N8TPf6v8hsQSuTzH EoF1UPePZWHBIYpZ0p6k73ZIywUa5zwR0ZayvXNWt/XdKIT3gcFaHeGs4C4tW8z9Tdnx JjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784321348; x=1784926148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DA8G+ZNQJ0zSGZowFGnb3Omh257suiDVTqWi0Dh6qc0=; b=QXXJEaQwN21H7AE4Tfs4jNDTndX7r4kdJY7TolX0jE/EdpH8RTCg/HYe8765ECY5lQ R73F06L3be3v50Vh1QpHYJWSnoUyCwk7coW3CnqAbyUXcoCgoPxTJSflY3qnMkPf+gvx eyi/C4TjUcu9Kh8UASiNn30slLBcmWRZQufljGOOQQn8V2f3fo++WxV0fTFNLMYRPebO zYHPXXFtQ7+LxgysnOeUSZ+irKavSVAVMzaWnppgX80nBSsv9bf6QOJ3fZXb4/tp84E3 +HwGDqHzmDRjUCz5WByrveSG/apAIsD/3dtwfZQLemncisrYD6GoaU6V8xgaYWTckTdr SIwA== X-Forwarded-Encrypted: i=1; AHgh+RqL8B9wfWBkC5FLOoXTIiOuraF3/SOrXfCo+iPqrHpHjQOkyzDCoykTlY0gm97cJjh1Vf5Hk+4+dFBzOhw=@vger.kernel.org X-Gm-Message-State: AOJu0YxgBRx3XISu0LmYdnQUlrEU2kPXZ81JvQbM6Zt6EkwJuGQA62UC qQBd6msrGxl5eIViTTTniGsRJExI0UmpF2wOUYAG2VcHb+VPg2lLh1EN2/vfkCew0xooxc24UuB xmZN6LhX5j38FKRYONtts6rTlARhbnWhvN3vBzMjri/YZp7kBzOvmntiUw+UV0D2cjg4= X-Gm-Gg: AfdE7cnztkyEIKz+hReOK5hEDSTWR6zpn4bVGkVycZ6ZsY0Mmi3U7GYaCPbhhBRrN4M bbQFJ+iyl7GU2qY9lNs82+znx89EBXjW22j6AjBVsY5m2XP7AYgTyVS5UzZp5ZkKXBbLLxj4z6t 0Pn4sJXgv60X0yfqiyXz54o69xtez45xwycKPXGWo6v6+czHAe9bjWeQasvUIsTAMGFI2rqKkmR vH1pmsVB/NkSc9UJOLy5URzuMnj/26eCgMwQKJW9TjVwJOPHuWm6tmDdQ427Izt4koh1wmvzFU8 bVK/sxaFAe0hQHKFUNgHi9cjV3VHZKVsN/5niXKckjj8Sd9anR9+Rjmkdl5zc55f8+pAK9sbjZP e1EVBQgHjRlB6uvQfiiBYNjaf6tlUWcdjX6suw5ezQQRLCC0= X-Received: by 2002:a05:6a20:258d:b0:3c0:9c19:65bd with SMTP id adf61e73a8af0-3c3adab057cmr4905223637.69.1784321348242; Fri, 17 Jul 2026 13:49:08 -0700 (PDT) X-Received: by 2002:a05:6a20:258d:b0:3c0:9c19:65bd with SMTP id adf61e73a8af0-3c3adab057cmr4905196637.69.1784321347805; Fri, 17 Jul 2026 13:49:07 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb51a2c2a13sm1338524a12.31.2026.07.17.13.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 13:49:07 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 12/16] drm/msm/gem: Validate lazy VM in GEM_NEW Date: Fri, 17 Jul 2026 13:48:28 -0700 Message-ID: <20260717204841.26120-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> References: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfX+PfUSDgSywCj 5WNccfhi/WvHlTjsJBzTDoFIB9JnXj3XVl96B30N2V/GzPZVxJjKTCC/1rybKywEcxz56mHyRbm +r+oPIw8j6GcUiOVQmEiDr+GewR+ugM= X-Proofpoint-ORIG-GUID: 9LH9mORznK4k_6ycqGNNOdbPlwqAl-DC X-Proofpoint-GUID: 9LH9mORznK4k_6ycqGNNOdbPlwqAl-DC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfX7VLPeUvckgAG YXklB8zzR4arQvSi1T/Xuh1Shg0dxL4T87p4Z7+tds6hidGapy1pleRh2bm7B4neQzDEWlKttCk ZRtadezH4FjExIVHdlDBUl02gubWj0U6ibvQ5i7k62bXDxLuqO/9s+OVQQv4JiLKt88enEyRLWu OPKwOyOjE9/M52RkGnJLeCL2iJZ0TWyN4Nix1Br1Eg9948LD1dVaPCVikmkvFQ1/V2YnvNrsRwV xAlSP3Rd0KTW9Cd2yodOlM5ddbPlpu+ITUgYsXH6pBrKtbUZJCE8sNpoYZzi5hShtNeMTk2q1+X 556QYwDhcsuKuNH0UqsSn0tPbCOmmBZLi/UOrDwnRUm+mViYdr9U0ORN9RKH7sFfG3tz3t21Aj9 mL9qVPUJKSv2jkKlvfnVAFow827EfmtJm3gF/eyiESosCVbfOU/NxwPiT1V5CwRbNtsM0c7VqQK 6PxBBPvJam8lXoCzjOg== X-Authority-Analysis: v=2.4 cv=OJIXGyaB c=1 sm=1 tr=0 ts=6a5a9545 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=VGCgC6sU4evaG-_1UnEA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170214 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index cb00bdf21ef6..153a4e4a916c 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1138,9 +1138,13 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, int ret; if (flags & MSM_BO_NO_SHARE) { + struct msm_drm_private *priv = dev->dev_private; struct msm_context *ctx = file->driver_priv; struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + if (!priv->gpu || !vm) + return UERR(EINVAL, dev, "not supported with shared VM"); + r_obj = drm_gpuvm_resv_obj(vm); } -- 2.55.0