From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7976F36E460 for ; Fri, 17 Jul 2026 20:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321360; cv=none; b=VrT368jscmPjvXRNWNB8BcXtSSAburQ3PI2b8kmQ8aob3wLiEL5KaLfb4GAtQuTYdJ5qJQLL6mgKQxmbcjPCU2HwM3TIWfyRw5q7SYdbzELKRh7NLkMXGv3or7qs6KM4KIT+jAQUVCBt2UxvaVXRmb2+to+y6Mv20zz6G/PnKIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321360; c=relaxed/simple; bh=5jusFGwn3Qm4zEYz94oUfi+TSGTz9Tl8cBbI4B7YQDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d9r8v/y4hUJplHpFw0mb/f5mnvnJf+lJNUiYnIyY5CuxPg3I8ikyh4nbTgyJ6SQ7RYPsCUPxcydXeurQ7W0AgptHS/noaIOYFNnewBnweTj1OASbxb/2yZYgfeUTAxfweGP8RxsFjobd4wPscKtdpytZDt/jGEwI8W6jdPhil1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RNkF/IDT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=asMdpM8Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RNkF/IDT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="asMdpM8Z" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtVRt2619490 for ; Fri, 17 Jul 2026 20:49:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=4y99CIHhO7Z Ma20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=RNkF/IDTdB/8cjkd877OsA0iNJx Ijt0TcpsLXlUxHxa8yrB64zdCa2GR47qr620wPjFoH/yaYVDx6FFqxWuZwQcYt0d D1eNFOxcJaSGlY1dVrUfq2WiUXgU/C7kjw0z7OAPH3wjbEfXH3TJhepuGWuQ1i/7 4Dw0vG5RmKKJYvDz96ryZDtgV4Ot9AYNxV7+i0wc/gGYx6dSBEoQeXBDY2O9oWWX V6laMNUaPDj0RzcwpDCNBeJaT1hjGnhc42agsPpJSIKAfvuqfFT5C1NDsyKFUkax 7QebA0diTVVW3XpY/1eRTrftgcOxArw4ZekoI+y9Q85wMDV9e6BOP3f3Qqg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fffagb7h0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 20:49:12 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-384419c6c74so10460153a91.1 for ; Fri, 17 Jul 2026 13:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784321352; x=1784926152; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4y99CIHhO7ZMa20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=asMdpM8ZZbMU4U5CwxE3DNcfUOPtr3ditw2W+5cD3Uw3pKlHbej700+xuuFnMipCdQ C9zBTAm7QZJr0qc4tid1BpVOYhUCkrQW3UuC245Fvin8S9A9abW37vDA76jMraGUKYsG b5N8V6rmjPhItYomiai4GWU35d81KAlQ6Gb3cp195Y75MXSOm0a6XsrypFseJCgvQfoj cjmxrYiUTkHd2BXH52khAs59UxI4Vckm5bYFYTfA6tVUH85bbBXSRC9NjbspCFVSjMfs +8a5qU9TYl6RL6Zm7CFh7Nku4pjHiKZWtk/TJtSQd0ftjikz1lfYwdPw0saX/neLjfn9 BzoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784321352; x=1784926152; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4y99CIHhO7ZMa20JkU9vG7q5Jf/ock0IskJ460LHt8I=; b=OcfhtvclfCU9/OrHepx8b9BJXM6iKcJtHOGZQVfkx/WJ7wi4ahucR6WXkUSDxj3dQg hXSgAPqI9v2/4eiF5KuD5GQp4A1AVdmf4nXTIeV2r+adpndxwGxxaxbPkfzBOgKeLDAT yr25LoN94Xm6u37MJ1PjiLVzd+OA745UchpJD3DRn0BW0sKRR53sVVu/rQsOZWDha5fv hZjA4g/EgZ3XC4QZacfGQ/qrQqa5cPphMvK9lsIiT8/OatO9x1sVNAUgHBZuAxE7uHU0 VuJVWcOCXo1o5UDzmexqpKnARZYA5GIlFgXdZuJIU0HiT+BMIgveQ3QbUdIlno9buLmF 3x1g== X-Forwarded-Encrypted: i=1; AHgh+Rr2dIg81B5bu+InkeU8hLIKJI9XcQr2RULVe8pOw/+avKUw4rQkrlUwR1kBxHuRyuIgq/+zSg8sENZrX6E=@vger.kernel.org X-Gm-Message-State: AOJu0Yy03Gkn7+rYEbSICqscHrUSiBKK5t3mcLNYD0N0O0dIx2fcLiTq VEhS64PWO3bzvcVLiKKx/hZDepGUFSeafTRNnfxHMyWhvh96IlGT1+2FwbhlesWd8lOSOXk5uRe giGrcMvtEGoCVbhHwawJM5/UqF5X3ym0J4W/t8hOUbkk995LnhLOuSSX9fIPD00jiElgAVqWcDa 8= X-Gm-Gg: AfdE7ckeypi2DJMLrOGxjDD6GUKaVnmNhKktDTKY8U3MrME4RzJakaPp73uW34IHEM0 2MfXmxA/fmwEJA5BgvTyRDE0oIbnwGVwwNIX3F9gOTKl0shy3dsb81zjOBvDW0oBlt76bZa9xc9 OekueDFTS8/H9XFonxYg0B8UGTUs3sp+sGQS8inqs2UpcOgo6QKB4kDudIiYf+DPHUjrF/k1TXe YSayp02mCoV/RRlvWG/j3mzp8ITsMlR6kH25vpnR13lC2NqXYMmhAP4rPCEi/+Iv/PtxWIDw6t/ qJQVMYKF31TMKfXMV7IYC4vjdUhNvq5ol0oYvJDWkb9UPmaSU5khQ9ZMeCDCQ+FXzXJXfwL6L08 d4SttfW5F2fB3a5nS1ERz3M9ySLyIeRYppftrXq58MnE76A0= X-Received: by 2002:a17:90b:1844:b0:37f:9ce1:cdb2 with SMTP id 98e67ed59e1d1-38e4b55aeebmr4534803a91.32.1784321351945; Fri, 17 Jul 2026 13:49:11 -0700 (PDT) X-Received: by 2002:a17:90b:1844:b0:37f:9ce1:cdb2 with SMTP id 98e67ed59e1d1-38e4b55aeebmr4534758a91.32.1784321351503; Fri, 17 Jul 2026 13:49:11 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e3a11e36fsm3627781a91.17.2026.07.17.13.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 13:49:10 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Akhil P Oommen , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 14/16] drm/msm: Don't fallback to shared VM for VM_BIND Date: Fri, 17 Jul 2026 13:48:30 -0700 Message-ID: <20260717204841.26120-15-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> References: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfXygYvkuL73qfK wFnLaa7lZoi4eaZMa7m+HtwoimuIyEd1QxD8/U4W7xtkpuIVqxfXe/vx1z/DwYRIVAtzrXYpnMw /KmK4Hs6qjWKd2vRlyS/T+qQf8AkqkNRLkTZrsOI5GbGOSQve86Y5K5weRip0b3Vsr0TXXBfwvP +U5qKSI11JrC8loba07HlQAiAyhZdZCrlnKPkkDBPxheFZY0R9Pobe6UMILv3W6txhPV1z8exrv 41gZlmv5EleOERaJKad7FBg76/09V8khOIzRwqikdYl7+UrOG7YyL6v6yipu3P2XA3frkmrVT1l VrxhWXBJ+dV8BkrwuU9jhINSOAmtOt5s4BYvMJ2WtOV32uP/xNRgmAjYVx2nn8ONnJB/3XNoYwU jqRE/yg2In36/u+QVE8N/vqRNyEMCY8AgZZNi2AlyJ0oXekFXoWZJCcs3i9swU6B/rLJ8CQeftK I+FC+Kvmn+fpI26oshA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfX8cyVU+Qu3BHP WogAIRo3Ij8hrqWGxOl7HCrLgsUN8kkV7Lu2w19HFLkNYw8Dxi6rwxdtCsP4GbiYPkyv9dKGQtV VC4104BTQ5vyvsm78E7Gsorsp/3/lNI= X-Authority-Analysis: v=2.4 cv=KZfidwYD c=1 sm=1 tr=0 ts=6a5a9548 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=isCY8TonHXl0-fnU9HAA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 7km9odiLkhjVe2gJh_AOMWN6iXj5wMCH X-Proofpoint-ORIG-GUID: 7km9odiLkhjVe2gJh_AOMWN6iXj5wMCH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170214 If the user wants a userspace managed VM (EN_VM_BIND) don't silently fall back to shared VM. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 52ff72d8e17a..73d99bde26f1 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -234,7 +234,8 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx if (!ctx->vm) { vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - smp_store_release(&ctx->vm, vm); + if (!IS_ERR_OR_NULL(vm)) + smp_store_release(&ctx->vm, vm); } return ctx->vm; diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 18ed00e5f143..a1c4adcac128 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -875,7 +875,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct task_struct *task, to_msm_vm(vm)->pid = get_pid(task_pid(task)); } - if (IS_ERR_OR_NULL(vm)) + if (IS_ERR_OR_NULL(vm) && kernel_managed) vm = drm_gpuvm_get(gpu->vm); return vm; -- 2.55.0