From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E63835AC32 for ; Fri, 17 Jul 2026 20:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321339; cv=none; b=ALOGdGy3tvquQ+ya3GHj8/PUfrmzErOh7sCaz6R1NFSwrcLK0LQ903NVuGvTEm1ZJ6JotMLWK2spU2xGm38lQSJCTSOksgBvAo79AuoFyOFQuYQZguB7JHny6Cy0y/Mc0p5BNKyKHPImFHb/Vg/dA6JtHvfuhRcf3GG3j7DPlbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784321339; c=relaxed/simple; bh=wZufhlf2OrTXiXq8s7psP10WRX750jNvVBTi3KYm6Ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ACY2xlSMNySA/hpNMLU/WEyfClfpUao30vTKK4uT7dBmrsH7AlZeoWYuIOpVcsVzThg8PMpiZ/VzQVbjosWD7OWe8JZWJXe8qCngkqzvJ5QOmpvUDeEZ7pTDqPCvIN/FJe22CWF74nDH2X/Phh9KZm7301iRUf4wOe9lvYrMEUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hEVnMuB7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cbms/t05; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hEVnMuB7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cbms/t05" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HJtaee2780359 for ; Fri, 17 Jul 2026 20:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Ss8T08lcQRu h4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=hEVnMuB7JH37W5cfKsOLBno8Ef+ 94Q/ZxE9MwpMWvrnzYCxagCyucP5XO9OyUb5dA+IT9jl78roqA4Vwj/Rz6x7R0ni XFAXvdztczHynVLnsFP9QuluXxaPv8xhQEBXsex3BZCNVMltbrBZuGSvNL/age65 iJhAn1fbiLHFnnMW+h6s2xe4ogrfxM0c19CXNfNAtgEeROW1Q5u5k4uTEw6eeUWT 2p7T8P+0lMVetpGHFruP3wsfcEk0+qi7XHPG7RtxRgRwz1RLSUHedV9mm+8ZodK/ ZPNqfevnPGMDNCkZNwvQ5gpAoGVz5J5KUjBjiFFHijNBiMMYjnYqnILd7Gg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gua54-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 20:48:56 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb4cdf95b5aso2699485a12.1 for ; Fri, 17 Jul 2026 13:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784321335; x=1784926135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ss8T08lcQRuh4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=cbms/t05DbIC217A9BSQXNco0jonc9pH4gRhnmU1LayNMj0J2PoiJ7cKw+aw8O1VJE 0jHSp4pwQ5f012w2OTDd7oVsfl6UHjeJArwqs1dPE88dC7mdhfR3l0NqSj+WQtlmmY/f u6FW7AztLYUu+WajQOPKUMCkQBA8SlP5kthDF7U83mo5pNtOU+rjmhzPdpf+DVB+VQVW jCUeJDwc6rk1tv7elHIfrIXQ3Qelmuumu71m1OtNXcfRTRLpV2JmDNbek2VcmW2jYCvb zIeanuC+WW8znGfjEQvswQQeYweCpCpElIGEtuhFPWeJ97dWpzQPK3r6lf8rg6No0qHw Tl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784321335; x=1784926135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ss8T08lcQRuh4LT8qU7cdiXED4Y+cvXcR0q697Hi17o=; b=Xau/aAzVMAEdrUdPemaJY1ep93izOjx7QjDedk7imTtdCriZz8oo6lWeX5l8lLvGSh //ENeYjHiNOXvYCs0GiRH6YwyredFJePocalMD3FZO6IS+nqlXnPO5umvplwUvsRiGcN fH/vEJC3GFYNiFG88KOqJw3/AuiartFpWcS2UshJusmSkZnN+hr4qoMWH5De4RHJEq/6 dnP/X6aEx1xYSxSoRRHp4KnxLhieZlag84jmLJzGkXB/e172AGw7LGY174s5gaQ6LDSM jGkFfBQEQ9KhZqY0gslpvARG+OkWhwmogbCLjTqjIfoUkG2llO/ETDxAkwOw6ZvCbV2H hIeA== X-Forwarded-Encrypted: i=1; AHgh+RpO+pNzmkeXewEgfF5B6ZPMu7MdoAAWzACK2skbAncCqpmKFGA700+T+k18mBbw8XIr2gKyJk/OT36fnnE=@vger.kernel.org X-Gm-Message-State: AOJu0YwIVNEbnpgH8+89BqjK1I1iU7jODztMThIkBWh0+4RICM2S3vMO QGsR/4rJHne3/+fF9DLJ5q/B2Yctnnc3VdiKyycSFpf3FiyN/JMBeCFCfZTT7lUhfYo9aP2GUcD 5qKNFERSDBZLO/M+/heyEi5LKDGj9VAlKSSoZ96utU+i+InyM8dlnQu3cBpvdkDof4C4= X-Gm-Gg: AfdE7cmC1VzfIJeiIgAnQH779qMEtQchtR1+dVFDHGS7rj2MthpZ7fk7mtlW93kDMRO zLMo6IgJu/B/Lycy6xuB1tlTTKtTuvSxUDaZH7+lolTS4jCCIT6yWGjsbkoEJVpr4/UPdRs1cA5 wKr8NdTswQF3qU8JKShY9WtMAWI/kHMcveaRWBL86QL/AesCxNagwP0u2o/+xQfZaqSydJeD2UQ N2TIN/HLy4eitGpjeuoeqGGo+swk2Hxu/wo6xdvv2/yubRRyViqSYl1Ih6J7aO0cog2ipO6XXPs rHzbvfJ61BgiBQonVLlhErpvTrqSm8b10NI2uGb0+AvDlm7P83+q3zkZe5Cedz3xgDEny7uGQZy R+B3nWF60gZpnOhcObRt5+quLkxJ7awyBNANPimK+LISVgGw= X-Received: by 2002:a05:6a00:1950:b0:845:eadb:821 with SMTP id d2e1a72fcca58-84c29271366mr4815799b3a.14.1784321335580; Fri, 17 Jul 2026 13:48:55 -0700 (PDT) X-Received: by 2002:a05:6a00:1950:b0:845:eadb:821 with SMTP id d2e1a72fcca58-84c29271366mr4815769b3a.14.1784321335169; Fri, 17 Jul 2026 13:48:55 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2adcd3dcsm1743863b3a.24.2026.07.17.13.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 13:48:54 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 04/16] drm/msm: Synchronize set_sysprof on ctxlock Date: Fri, 17 Jul 2026 13:48:20 -0700 Message-ID: <20260717204841.26120-5-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> References: <20260717204841.26120-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfXy5T7mZMcxd4C QfHHSX2dNLhiQh5jYOrd7iyfb7YcNGMBHoFlpz6/iHf2dohOsC8g75+XP/hCKyIDFS2MTXYL8mN khe66X4gu8PVzXSZtjNYuNsSyge9Vng= X-Proofpoint-ORIG-GUID: aE3K88ZLEuCQATJGhHFDfr7btWbIq4Fc X-Proofpoint-GUID: aE3K88ZLEuCQATJGhHFDfr7btWbIq4Fc X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a9538 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=A-0ye_aN_Dr-yZQka4YA:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDIxNCBTYWx0ZWRfXxkfXXiu4olcW HAnnwyB4ZvpsaaS/lPlKcKgSpLTZs6sefjuCNxTttUT/GSCvhvctRrIxSSIYBACiniD7ABgXLPa oKhSFjZ2wiAZ6Vs+BouHH+WZYBxSTZJ1T8B61SVtBfFQbVnao0mpZIsY5E3/3os8HwDglqT0RmF 7QoLzynKgLyaM/rXTp/OcrNoIiIegl5bg1pw7LL8SdkXnWgWECYxUGfXpFzigylCac5ktw9WrW7 EXA/eIT0Syttmle1zRhLfPmbFliBUO6DfuhyEvbx6pLFAACrdqJ7sfpQAZ/5BEGnO8/T50JyaU6 5IlnuUwmKvaAZP3rq8GsYE4tx0mCNpmBzSqDxg8JRcE0/FysjYXrHUC6ERh+U7HRuCH87A7XuLv 7tk7FreZA/U2/VBpTy5oAWzBzq5EjdbTkXJ7V1E/LbS1Fnc/d7k8LoFYWvqAc37AVqEN7OCfpPd vCIQ7y+ZSlMKJuH1a4w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170214 A user that was perfmon_capable() could try to race setting SYSPROF param on multiple threads to trigger a reference leak. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_submitqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c index 8b5980d5a6a7..233c4f35ab12 100644 --- a/drivers/gpu/drm/msm/msm_submitqueue.c +++ b/drivers/gpu/drm/msm/msm_submitqueue.c @@ -9,6 +9,8 @@ int msm_context_set_sysprof(struct msm_context *ctx, struct msm_gpu *gpu, int sysprof) { + guard(rwsem_write)(&ctx->ctxlock); + /* * Since pm_runtime and sysprof_active are both refcounts, we * call apply the new value first, and then unwind the previous -- 2.55.0