From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5874C299A84 for ; Fri, 17 Jul 2026 22:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784325784; cv=none; b=RFV3XkgjHyi5Vy7O7vcQFawCyYIYcvjq63PCUfweYLtpwpqVslqfPoybVaqHGm79QHDYgJPt0kZ6En8AvGOmWekJR9klAr5NTWTqH2nX2qpFDl56yTVTYb8ys0Q3YLgYJykULZKwrv8qKI8uU40QCi1JuIPNs0XKTQjuG2GELMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784325784; c=relaxed/simple; bh=lMArcPFWWuRlk6z5NoBTp+gMqPtSbXq6NoyJ6ndpH9k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tvz8+jLGiuXaZM3dE0w8DX3coU6Vdia8Klq0cshaWIT8HQ8gHlwEVtKodBRTDe6plbS8CFLo7gYSRj/zCi5jCqogIIq/uIGXRn47c3xk0O3pSjCBZDAaSg3HBrsydzHv7oHK2t4LLyPZvgocGw7uLT0bEkpnK0QVEgNa4Qmyv5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GMWuZAKn; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GMWuZAKn" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cace91f112so83588495ad.0 for ; Fri, 17 Jul 2026 15:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784325783; x=1784930583; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iEkd0sxNlznW0uG3RudvQnAJteJfNYHswB1Rjkp+2dI=; b=GMWuZAKnH7yyHqb4diCFu+wsYFSrKISV0va6ATl8/BZxAJzYBr70Ct07dy8EpvynIr FRgz53eFzuupY1FMSIMasY+oE/eh2TfcCG9ELvImuE8pf6izdA/p+C4ckgusmSmFB2aX ApeKD0xKxe1BTMjJ0iqMwLZdxBW37sUTJYq/Ng2r8etkkF0XZBiXmWq6f/kpHqzB6Xqq t+QleEM4/BzgsCJfuk/TmUWbWacVYa8M3DgKcb2LljtXog/nwa5sBULnBoNUuUlAPAjv B3IFrMnO1ND2qjUH3zN3VbgPUN6wL9Hrh6xRA7YvATqXPnaZLBf/DLKNCzE1yTVooL7L xX9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784325783; x=1784930583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iEkd0sxNlznW0uG3RudvQnAJteJfNYHswB1Rjkp+2dI=; b=Wm3R3d9rRWdrfjUVCgmuA2BjAp64L7C+71B1PqomMq9dZC9C/Tl+kItUVgI6aAFAkH SyJvzmfRQHLGfXlbOwe7lU3/ShfEh724IgJmg5gzjGbVZsxrPURpPvFGy1jMaCJN6MY4 J/1Ekso4OQCN93X2j24PMNuHPGOUlT7SS59eS/HsJejF8nL8HJKiqYh3IwJBdZo5iU5G dpr1c6zHT6g26buVjrmjL+OtPTVVCGbyknbxiHu3XM5Qdue3G65wOKlK534kzOoARW3A P6gf9IYs5UkHn+KhALwOXdEMNmUjSaBnZpKEWPtbX8jkOXy0m9DluuwK9deBgA0+pBb7 +PYA== X-Forwarded-Encrypted: i=1; AHgh+Ro2NUIPQRAvKnjdte3fT0MObaNhQWoSGai7XGKdlrSjdomZ03abMW2BXnMwFt3wTxBmNago5ppIOZS517E=@vger.kernel.org X-Gm-Message-State: AOJu0YxP2zTHxQTKYLXw4U1fs0VIGYKwT6zFWKP9WC9R/7YKlLWid58d bRgT0zjDJg2/GspYrEd335lLdMPcvTX8s8uWPljfLORrpQ+HsE2XjGFDSGzxa8sCHK0= X-Gm-Gg: AfdE7cmfMbkgJsa32z9/LE/RMKBPv3UbHNwYJteqXgHnd2XgVI8SCmbQ/000xn7VBWp j9G0pQYcqj6GUXXgcVrnYmEG0QxLRAuA8KpTF5Ml3Ej+PdL/xr00+8OsCecxORu6XqfVl7CTsxR 38mD3xE8KNMq5Ln18cPnDSzpHgLwy7eS1V8T/5zR+Gbb5cf5vCFWeaO6+WPUxAilmIuTRzedJPT TVQJshWrM3lLe+SuujBKugGjEtGE/XXL3gqXVkdcUQGL4itMhmPCdTVD7TxCNmhq9dg72TfueDv ngXI+NzK+bCKrmHf7Z1leb46T+KtGXymxVhZL0K5oj3b0fVwMq3qjr5GIpNeJOyPnhmPRDIE6dV Yk3MmRWFql23Pbyhvxxi2y+kRmPdjX+KE4LU6+5NHmfMKabqzU/RT6XtH0v0UpOZ9SJjj9sQQYc C3Lxsh8CxEAqIndJ1k9NDYTuA6yoQsnCvbUhyj9qMBPoHmYIeIaLnIFszPH6AsVdf857OiHMwdn w== X-Received: by 2002:a17:903:8c6:b0:2cb:ea0b:9164 with SMTP id d9443c01a7336-2cf3481941bmr48976245ad.6.1784325782345; Fri, 17 Jul 2026 15:03:02 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::9dab]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3473ba1dsm17439205ad.65.2026.07.17.15.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 15:03:01 -0700 (PDT) From: Ivy Lopez To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material Date: Fri, 17 Jul 2026 16:01:35 -0600 Message-ID: <20260717220135.17836-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260713233401.48262-1-skunkolee@gmail.com> References: <20260713233401.48262-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The set_stakey_parm struct contains a 16-byte encryption key. Use kfree_sensitive() instead of kfree() to ensure the key material is zeroed before the memory is freed, preventing potential information leaks. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Ivy Lopez --- Changes in v4: - Add Fixes: tag - Previous versions had unrelated ftmac100 changes (now removed) drivers/staging/rtl8723bs/core/rtw_cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index b932670f5d63..a34ee407285b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -899,7 +899,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ if (enqueue) { ph2c = kzalloc_obj(*ph2c); if (!ph2c) { - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -907,7 +907,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } @@ -918,7 +918,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_ res = rtw_enqueue_cmd(pcmdpriv, ph2c); } else { set_stakey_hdl(padapter, (u8 *)psetstakey_para); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); } exit: return res; @@ -958,7 +958,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 enqueu psetstakey_rsp = kzalloc_obj(*psetstakey_rsp); if (!psetstakey_rsp) { kfree(ph2c); - kfree(psetstakey_para); + kfree_sensitive(psetstakey_para); res = _FAIL; goto exit; } -- 2.55.0