From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DA7B3BA25F for ; Fri, 17 Jul 2026 23:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784330776; cv=none; b=lkKl5pNZxH2Ht/udrxluQxntOAXxI9xXdQa5ceYHe5Wz9nRxWalPED1nccSTCdzGio/I4vzMM2nMItg7umN/ybu92Nn2nsr8008LXO8xlgRS+ZjQ1RrlJP0WVlH6DJ+869H6iSWZs7a1hWeoAiRbHxbttq/9t3445qNiQNFUBuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784330776; c=relaxed/simple; bh=Mr+M2V4EySH5w/o6fGZtPCNFPSb1eKpwfb+NSwiNkmM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gSz5QjkRIafAF6E4fjSUm7s8TfZxqqZkQ9dfHn8r+IFsHS0w55De0aw6dD4ZsfVIHrXZrmjPaEZLAf/bBZnINWo9wFrLA/kh2icAEtWL+ykp40j2UT3fUgF0M3G+owlejK98sfn3vJNlGfHeS6agA+0EyI1fuy0jy1UZiiDUyPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZLklD+Vs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dBGheRRl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZLklD+Vs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dBGheRRl" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HNEGmi3418115 for ; Fri, 17 Jul 2026 23:26:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EKroq+M5025DWWLFFadkmaK5KHqMFcN31yiR+hQHEZQ=; b=ZLklD+VsSssVWiGq f/Win387NUnx5O1S21B9OdUO2RRUc94tZfdlDUyifphhsek6kfUnENTElQ0z8/GH ic5jMJcZCrTSKgaKYYZ7+QQRncZXnaMo5F/5uwDMlCe01YIljGOCq38pV7j/WHKI BLjYlBerUDP2qwzEj0JChczc41pj+OJRf66uP6EurFOwSxqLaQE0smdltz95A6px rL/fasyyNwsWkpG0RNpCS+yozLQb0Twn5vFeu/wjkuwc/veLBL+xN/C9Xoujtl7b VkmXp2ZECc2GgR9PZulAMsitWjNFar6zBI806eloCHMQbtJiek+1e6MORtHyrzGv uHvpSQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffwhfr2k9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 23:26:14 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc5faecf01so160618455ad.1 for ; Fri, 17 Jul 2026 16:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784330774; x=1784935574; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EKroq+M5025DWWLFFadkmaK5KHqMFcN31yiR+hQHEZQ=; b=dBGheRRlB1glWCKdKJSO8Out82HSNyNMBXFxANizSz3M/9Z4oq5ZliByPLTTvK4Pau ARmjhqR+yco2UaPFM9no8chOe5mWNmMR1WcqJ5k915N6I136aIpxBmnIaYhjYDqEnCzx Fbkuhwfbr/bHHztevQ4c5/7t4ZD2hRmGl8mtEA4o+AkCAIIH9YdTUtVCHkGYRG0pKKgr JVSOpbefrmIEOcu/F3H8PxdC1QylAGPceZTDgL3E8eP17Sd95h1PriQ7S+v/x7F+IuMy NEF6JKRppHwI4SfvLKSB+cHwr2W43bqUEJebtNkDI7z78ayYP04dR5qlI9HSV+ABAzQo N8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784330774; x=1784935574; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EKroq+M5025DWWLFFadkmaK5KHqMFcN31yiR+hQHEZQ=; b=TGacRuewJNokDFRm5Usu5zr4mglFE+G/BCroohK+TetPbVTV9SaZKcaFLWx5c1mFBW b4qacWLLr3A07Z9243WsPbN+5bscZ6TRXjad0CYjSBSGZIM91KH1ERHnhZyRTh5gl04z 1KDsuS+inbss0Ts4qECoMu17znW6qLdSqkkZcj2jqGy2+4qfyTOENyLNUcZhTNyZSySA ZF9ZqB9KFlm+V53IkCY7XhHxdElE3TPtMnVxaBXehleh0AcbUQrMv0k6s+52fhIgsFms O2gtfARX1uke1pubA2u5QdeR6XFSe3UP59YACsADXQUgQcsdtycj8P597V9s+3U3W5ht S3Jg== X-Forwarded-Encrypted: i=1; AHgh+RoI6+B2u9o9SHy9KXzSnseNSi2J48YexKVbQIXz70rkAzvgfHvdHdm3t2vDS5UBfEiX+UkU2cZ4wu0rfhA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8A4uMzdeLGC20XmSHZyNi2rne8QloDuYXe456m/6hcmv/LRj7 4WQxjZxs7L2hyI+9k9b9KwYk2EHETzMdZrn7jssa2ITwF1w/174/WUEZ3o8TcT7OSUFoUaAX/iq 3tlcOzYJG0PS8yy/EINpMwVL5MnkbxgPj0sWaQnwVAtAltM1tjOwsGey368JCgPiOmDk= X-Gm-Gg: AfdE7ckTspJuf0NfZ6rYV3b7axH7r64PbOgWU2Sbw3FzZB9TpvIheiT0tOODNNZl19O vtgXRsQDKNTpZUyyuR2Iwc+R7o4oZQI1gFq6KJIYAxHpSa+xWEH0BXIHORGO9KJWdMIwm0xmchv vxPT7EkrR5gPRVK4t4yDpZ1gTZjB7GZvdMaXE6G8GxXduXdbDmROHG+Vb9UuD/KapBqWHHvXVjR nl1G5LcD6oqAQ5uMbidnE5Gk1qZqaw9JN8uIV+ugBpz8lOGdNZKMYHSL1B4Wm07hp8LqzIkKLPD X1uBKFGTSYytD3h+zkq7HapZe5aJACkBSMqqosMqNgkNSd22RnYCcDgPMflV/uODxxJ2FFD4dD0 91dQt8tlJAEVkfVE1 X-Received: by 2002:a17:902:f688:b0:2ca:5d24:720b with SMTP id d9443c01a7336-2cf349caff7mr53608545ad.39.1784330773719; Fri, 17 Jul 2026 16:26:13 -0700 (PDT) X-Received: by 2002:a17:902:f688:b0:2ca:5d24:720b with SMTP id d9443c01a7336-2cf349caff7mr53608265ad.39.1784330773302; Fri, 17 Jul 2026 16:26:13 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3473ba1dsm18246615ad.65.2026.07.17.16.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 16:26:12 -0700 (PDT) Date: Sat, 18 Jul 2026 00:26:09 +0100 From: Jonathan Cameron To: Pan Chuang Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 04/13] iio: common: Remove redundant dev_err() Message-ID: <20260718002557.2e530d50@jic23-huawei> In-Reply-To: <20260717094408.509583-5-panchuang@vivo.com> References: <20260717094408.509583-1-panchuang@vivo.com> <20260717094408.509583-5-panchuang@vivo.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: w0HW_xqgNsqfPwFikByzW01eLDRyXMcn X-Proofpoint-GUID: w0HW_xqgNsqfPwFikByzW01eLDRyXMcn X-Authority-Analysis: v=2.4 cv=ZKDnX37b c=1 sm=1 tr=0 ts=6a5aba16 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=1WtWmnkvAAAA:8 a=hhBeVE5wmSm3c_K4xCsA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDI0MSBTYWx0ZWRfX9NYDxqLYGaZQ Y2c3NqUZR8RcxfQsv+2Bfcs3X0uyNaF61oK12nr74scWesJeLK8FKDXjtoZeaI2itdB9VtF5G7n s2TjgX6lkLocPDhWc0tmHwqdrj29wBT/33qmOgpOGkp6rZQRBOuoHFOUpggdxcz6534aGIKtbcz qM0PDl0oH6+9AIGSaGrb3FG+5+cqqkBlZMvpyonn1CDT2kP8YLIAKLmRq+X4LQFBCysZMeOFA4w YlVS9Y4m5marBgBo0eTxjoi0dfEclLNe2oH7BzNG9Wxy2r/GkKjeKyMNwF0th/VLO6PE8gX1oEY kyP+agI+EWBV6iwEGQco0frUcHsWRxF98jkZga+r3v0qcPHHry9HFyg4dct8SjRTvrP/3sud7qb S5Xkeb8XuMyNKoQm7KnA+C7sz4S4ZYkjnpghsO2h3fCKZ4ZdFnuGCjGxr1vXrGo/7HkmE/hEPRd m9uEAUjCZjfqgph7b0Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDI0MSBTYWx0ZWRfX6Z3ECIueBXGR K41jAb4bLY231IYHrx+c0UdzQVYH32jfHqrhlxOxbaJqKUvyol4asO1rQBkd+ZrzgOsxW2DxU1j jgbQtvryfxEo/r7uR3kug1ogL3iniH0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170241 On Fri, 17 Jul 2026 17:42:27 +0800 Pan Chuang wrote: Hi, Where there is only one driver affected, please name that driver in the commit message. Let's anyone who cares about other drivers in that directory know they can ignore it! Thanks, Jonathan > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_threaded_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > > Signed-off-by: Pan Chuang > --- > drivers/iio/common/st_sensors/st_sensors_trigger.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c > index 8a8ab688d798..7b3e9732cc3e 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c > +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c > @@ -211,10 +211,8 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, > irq_trig, > sdata->trig->name, > sdata->trig); > - if (err) { > - dev_err(parent, "failed to request trigger IRQ.\n"); > + if (err) > return err; > - } > > err = devm_iio_trigger_register(parent, sdata->trig); > if (err < 0) {