From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820B02288CB for ; Sat, 18 Jul 2026 01:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784339517; cv=none; b=oexELS/LPo1+cvbJU3YqGcCz4c+BWcdB591BgsnQthv2BUbys5erpy4M+PztcXAooLuOqVFIPvJF59O8AFMI2Unfveq1ybLoFrBITCIMALPMNacxNxjpcH3sEFvrEGEq20CwlYSj0pzZE72wZFW52H45lNCBC9/1rNHlvKy2A18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784339517; c=relaxed/simple; bh=uktmRHgaHId2Z3bEN8aBE0IcMStiNYNfmwhY+mzHKeo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gVWNJj6rVhe9Sp8AXa7BCemM19SZas/dIbLOe1L6WtpmSlPubXA8hSggJ2vN9+ACOvgoDFlruGizZQ+fmJ9QRMIDDSXw5omUGfV2L3A8sObssC0/8G0H/IEXYXGqjtJ+Jku/3PkiGElizXaQoZmUW1v3pYaU2/qI6tgfHsaH/kM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jnb+ttwr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BTnA1Ihy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jnb+ttwr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BTnA1Ihy" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66I0JfwW3318098 for ; Sat, 18 Jul 2026 01:51:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gju1xgVLjNEMVzQtIE3O1WK5Xxgr/j2HRmtju0PVRAw=; b=Jnb+ttwr0jhyQepF 1aY+6NDraVxHWPo4ouu6yuZju56xL5DYWE+S1ktRFfQtt2s31HcI/U2gYlM+R+Zo dZpP76YpxlDlybZEwPKwufwN/0rF29/O6ep5+aHlD4qSY/tUzFMno3Eb74CGDXbj YF9io3XqDxmcbBG2BON+mjBu3A0yLrTJ7fZpfyz2HTPRo4R4iy0qbTztpsciGrm3 71UT90oayi3ock8q6O/JbjjINzTIDQDSCPk+qHqWcQ2lMRafluZH700/o3MMD3/N +JX+9iaMrz1wN/dNP5hc16at6vb8Sj5gzw5DVTOsTXCAYx1QHlv5W328GoWj1aZe JvxpbA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffxup85s4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Jul 2026 01:51:55 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cea6a46766so117909445ad.0 for ; Fri, 17 Jul 2026 18:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784339514; x=1784944314; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gju1xgVLjNEMVzQtIE3O1WK5Xxgr/j2HRmtju0PVRAw=; b=BTnA1Ihy7v0q0ueOiRiKyncnTxzCtAbu88gtB6uCUfQbbzJyMh+ZG+hgdoXsDY8mzV n8KL7RkKIs42bCQJthqObUPM2lv6RTlf7bHno2yQoW5Aa5CYrbIrGJ9KnVPHbys8tEUI Z4DuZiVBtGwBu/mNmt/BWwG09UWsAG0Pl1H1B2+d5tM0zMdfaYY0GzB6aptUKh0IKDmR dzM8Doxrx6B3vtfd1O37L4LtShLKuZ/IDB1vAK2QysER3RFX/PVU38gvxT0LiTwHFaD9 CoVxDNMWycyrTZVFKSm8GELrfy/XymmagzNXWGO5EAd4qrBmXIU8OjtYDUFFO5TcvczB /Tnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784339514; x=1784944314; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gju1xgVLjNEMVzQtIE3O1WK5Xxgr/j2HRmtju0PVRAw=; b=PmLDH4YwxgKREnCl/NrGlyrFULlzDjR1QjUQ9NLKttsyVSVsjirxRNAfww9vu4+S9F UiW0TzyLDsoihYk3VFfXiMRaVbOPkHDnbpUmlvv6Uw1LeYAeiib3g9bfj2G0GQ3Mq7qe Od+PlayjiJ2LWdzoIdxJYzU6WXIigPhtm0Ps8g7btrOswGHB33imH6Oc+sB07jVfWf51 xj01MEPWzEvCRlMqCaLyYuPEmC05ADOKTbbT8F9qJNaXTxVxCljUMnW1WZHqVcXAG9ww 3TJRNqQl706k+lyaOlty5pUJ1hyBIfNytpHT9kKKXzFuCplOZ+G2q7IcU74AUN3wglMU rEVA== X-Forwarded-Encrypted: i=1; AHgh+RrDhjFGp8bX9QnMhPXkn1yHW6ztBNdWRNzvc4lBbOO3Ta/ojZgf/Cv9xNezMYsKkQhElKMjNBy2XZ+OXt8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi4Ng591OzHn7xgtJeCwPH1n+INxl8jwmK56q/JVvldDQl4vUx nvvUhh8Cc1JlxDG1KiAQDqLNd4JylPHdjKDBxdIv3BKqeO72qMFjP4Y6WgW+h6HKaHP9PCFYEmt 88nGwnU1ISQwOn0rsfsiOep7C8cqbnQQB5kKV18akxBd+WV/8AvrCvAjtyhErcDUez58= X-Gm-Gg: AfdE7ckCXSSWlfHn8S9ri36Y+NlZuL5Ehfm3KXjp+iWFgLYzwdfvkgSqgaXd7KVaSyU aRDOHMoM74cDtt0g80bWsFrub5GPi5K6osRq2iHt1vorPra5oNnno/iSJlWY4BEufR0W51UThxw E/p0SUetlRPg0EvTVM4EDGngao6m7rkGOhAxhLePXlCDxDqy4s8Wv36GXWNFr34aCQu+DviNciM E+CjIS2rsd0BsS42A0IDvFQ4f3T+esZ2S7LTzuNxAHDJm3YE3THhjzjwxyxWvhvRRT8YVBj/Snj tVfY5hOHr6Bxu7DvBaTNPoYt8bQd2C4w5mxaJOio7++s4L27kW1dnuapB3HWxI9ZyXUv2Igiit+ 9iuQkQSNuPONPks4i X-Received: by 2002:a17:902:f78c:b0:2cb:3f5b:6663 with SMTP id d9443c01a7336-2cf348bee75mr57045895ad.11.1784339514214; Fri, 17 Jul 2026 18:51:54 -0700 (PDT) X-Received: by 2002:a17:902:f78c:b0:2cb:3f5b:6663 with SMTP id d9443c01a7336-2cf348bee75mr57045745ad.11.1784339513767; Fri, 17 Jul 2026 18:51:53 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3471eb94sm20636455ad.62.2026.07.17.18.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 18:51:53 -0700 (PDT) Date: Sat, 18 Jul 2026 02:51:49 +0100 From: Jonathan Cameron To: Marcelo Schmitt Cc: , , , , , , , , , , , Subject: Re: [PATCH v7 2/4] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs Message-ID: <20260718025138.091beddd@jic23-huawei> In-Reply-To: <5108c89986ae8723139419058db1b2f2e74daff6.1784235595.git.marcelo.schmitt@analog.com> References: <5108c89986ae8723139419058db1b2f2e74daff6.1784235595.git.marcelo.schmitt@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ZDdJUwiXOGdQpq30CGFhsEEWrb3Lps69 X-Proofpoint-ORIG-GUID: ZDdJUwiXOGdQpq30CGFhsEEWrb3Lps69 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE4MDAxNSBTYWx0ZWRfX/9841yuQRl1N XYbOU9tXGDaMPParQhRmpQONS7q3puvSKtNUWZVzOne8jYfPGG4QkkWV1qNvUnumVmd0Ewsom3E 01tSV6wj8ta/eXyroUUG7Tb9p640+IVbMKQ8JrAEwlfF7jvdslYISQxgSphSghTlXb62isk/08m cNFPsE14GsV0bQ0qBNJH2+spJUr/KqkXHX+DwbK3MkB6C2P2gKVgtSVGmrN4eD+X0XAWqdxmgQ+ jmfktnDPKm/T2iMaPO8gvAGhQY6z0jlbTVfyhO+yFGw9eNl+p4U2bGWMp3eAc8LgtBw6z1pKPJC lZfETAlboENUU+cc1jmSMm61y6GeQC5M3IFcISiyhsXAi7+fi4eF6X7C7E5a5xObYYJWxT6gJkr 0zm2IOr5l6WgDTqWXQt2Mg4P3z8Ae+1pElxxez/WJ2h2l5FVGl7hs2OpavJSCJACBqZbi3lS7FP ybL9WGHBiHCW1/+dS4g== X-Authority-Analysis: v=2.4 cv=JoHBas4C c=1 sm=1 tr=0 ts=6a5adc3b cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gAnH3GRIAAAA:8 a=IpJZQVW2AAAA:8 a=U5XZBdOWIMhTiLln3IoA:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE4MDAxNSBTYWx0ZWRfX+oV5ZoTPkmX4 4zN7zegNAMSz4DtmNgXMm2YfL9kJ52NGKxyncKyXhyvfQlGe68rR8+/SE5Y9fVM9VMPfUyZpeuI zGm8k7U4YZ2+iBqJIX8K4fohiWxHP4Y= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607180015 On Thu, 16 Jul 2026 18:09:36 -0300 Marcelo Schmitt wrote: > Support for LTC2378-20 and similar analog-to-digital converters. > > Reviewed-by: David Lechner > Signed-off-by: Marcelo Schmitt One entirely trivial comment. Jonathan > diff --git a/drivers/iio/adc/ltc2378.c b/drivers/iio/adc/ltc2378.c > new file mode 100644 > index 000000000000..5600c820c7f4 > --- /dev/null > +++ b/drivers/iio/adc/ltc2378.c > +static int ltc2378_refin_setup(struct device *dev, struct ltc2378_state *st) > +{ > + int ret; > + > + /* > + * The internal reference buffer amplifies both the internal reference > + * and REFIN by a factor of 2. > + */ > + ret = devm_regulator_get_enable_read_voltage(dev, "refin"); > + if (ret == -ENODEV) { /* refin is optional */ > + st->ref_uV = st->info->internal_ref_uV * 2; > + return 0; > + } else if (ret < 0) { if (ret < 0) > + return dev_err_probe(dev, ret, "failed to read refin regulator\n"); > + } > + > + st->ref_uV = ret * 2; > + > + return 0; > +}