From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8631283CAF for ; Sat, 18 Jul 2026 04:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784348000; cv=none; b=u7gkcpsE7M9NpZlzTvPnxrkzsNC8YLnWBvo7FOqYbYWaYT4/2IW6sGJFD+ClhnlFTA7D4Z7yiSrUjj0WTJWKvzzHeKWV6+73Av9B019fPEQq0c/LDPuxDIxYAp96Akerth0KTtC/KZi+UAejb6CXzzRetEWl4/0R90LRVW6tvPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784348000; c=relaxed/simple; bh=xQb4coZfpWrjigkaUG3SD+9F/JAInpSwhf+MNngfJgc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pocb55K36KFYEw/IzvkCZmoWhnLkDFrCuLntvLIzFtivWKQcNQH52nQqCbY36l6mjVV6Bml2WAndTPK5eDxcewGAy/VTfNA6+kZ0XoxrX8vuaY3RXEy2NdYPCo1HOUQj5FIbVtJWbkIk/J8CFbLd+DJdp+Yp/R4vtEBlnGBIwd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jDFubcYM; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jDFubcYM" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3856d6fbcb3so4589736a91.2 for ; Fri, 17 Jul 2026 21:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784347998; x=1784952798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=awNCmiuzQvRjC+cVqe10JWSeLPQ45yHPdtX/Hktck9c=; b=jDFubcYMRwqp4s8UK2TiNLZgBwPPmrRSSd9mxERS/fSatDk0xcfpCuCgjQBstoMgaC PDnr0JPi8v/xhEnobiSoLnqCjjwXWE69890x7uzjW2GyMvshnDpyRDepC6aJgVL4/ec+ qekChn0d6nv+EBtN4XSW1RYUmjrPjRXu0TzqrIY4Glf8WviaeK7kFNMoqnsQ6EeoDdDi AjwgQHPiLTnhRUN7T62u9X0yXBHZ2UNx5+Y8Ws1ax4dYNMFXtTV81ZkK2o6zZlDeqRLY oXEhhZn2K/NzR+iLY+7aiQ0RzHXDHv/Ix+72DLY3bdjJ3a06enTIcqKxaZM4LXe6qQJ5 7ubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784347998; x=1784952798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=awNCmiuzQvRjC+cVqe10JWSeLPQ45yHPdtX/Hktck9c=; b=HW3mCEoE5vKvFNKnjVTpMUyFkt/eEhP6e38N06e1DNJkzGMqzr2PBw4+SfzDqVFI30 ZGNFPCLbhqhR1NgL1lGtaDAE/aMG/1NhbHbRgZ0x2KwdqdDe1wg7NMpRU739Qfe6mU+N b3o9yCzKtxepCi/ZtsW1733Yn2+8sY7Bi8mmKLIX7na+GQZdtvKFKUEnwua6cDjPFZxw mOI/WsEJFdterfzFiBfuNQhQE9+IIIcGH8VPfL0y8IL3Z7MYAfeC9IXgzWFJyuPO8B/b ziXP9e397v7EI45hJSYTySkV7RQy+k3CPB0CHqUVYiJj5rVzVCZbeQ43fFDsdVngf7+l 2ofw== X-Forwarded-Encrypted: i=1; AHgh+Rqz4ORFKAL5L6aZaKOCUxCs602LP0L4DKQ4Owq3mX/GEmphvdM+G1ul/FLFwKozJb6YB2D78CkPbOLSz5I=@vger.kernel.org X-Gm-Message-State: AOJu0YxRKaADhWlAOeRvtJGKzeYna34vmOMh4FcCvUyz7tXIxP4qr7RN jn2uKI4Y1QUX0phzUA73fMLg7eJmCS3Wc07gaX6QI3EQXLy9oVobfR3u X-Gm-Gg: AfdE7cnTZK16DWAejNCCXR2Mcv/me/B9o++VN2RPKXhU6Z9oGXFiIQmkS9/S6Y6dtWs vqXf5Sc2QIwk1oj0gSbjc17ljq3TtLExJkPwNaaQYR1hmiiLc/he6VqX32yGwNu1q2s3TE6rHWL g9Eemqhs0oS0F2UvocP7azOXW6FzlLq5YVqAE8u4cbjVxL4FZXkswZ6ntuTwEsw5R7jnBtxUjyC mEOvpFIbfkE7HXfbNLcGXPKBszUj41sTkI7+8PlYI9H5hWnoAUMQIRCaScsPn/4l4s0THueNpwL zcn4xIflyBM6Yq7+iKFKwD90C1/GSg9T9q0ukM2bZ0mNqR2c5P1R5IOcn4wyTOburGvSlQFXWpR K/0G6Au7sq/+1jILW90OXZLoVjUomDQEGJmkf45uQQvjL5Gnmpu74rIJUI7u6SvUaGeG1vpnNIW 5ZH3hsW/zSy8kGS44nI8QG5lmzJ38JEuGSHLR5zhNNB732CLRXXLZpLN4wPg3f3UhUuA== X-Received: by 2002:a17:90b:2f0d:b0:387:e0db:bc33 with SMTP id 98e67ed59e1d1-38e4b5726e0mr5931371a91.41.1784347998278; Fri, 17 Jul 2026 21:13:18 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7638:3cbc:f1c5:2eeb]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1bbaf6sm11052109eec.17.2026.07.17.21.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 21:13:17 -0700 (PDT) From: Dmitry Torokhov To: Bartosz Golaszewski , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] gpiolib: of: compile of_find_trigger_gpio() conditionally Date: Fri, 17 Jul 2026 21:13:06 -0700 Message-ID: <20260718041311.2605172-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260718041311.2605172-1-dmitry.torokhov@gmail.com> References: <20260718041311.2605172-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Compile of_find_trigger_gpio() and include its entry in the of_find_gpio_quirks table only when CONFIG_LEDS_TRIGGER_GPIO is enabled, and remove the redundant runtime check. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/gpio/gpiolib-of.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index fc77cf6b306a..f4ea7ca27296 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -651,6 +651,7 @@ static struct gpio_desc *of_find_mt2701_gpio(struct device_node *np, } #endif +#if IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO) /* * Trigger sources are special, they allow us to use any GPIO as a LED trigger * and have the name "trigger-sources" no matter which kind of phandle it is @@ -664,9 +665,6 @@ static struct gpio_desc *of_find_trigger_gpio(struct device_node *np, { struct gpio_desc *desc; - if (!IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO)) - return ERR_PTR(-ENOENT); - if (!con_id || strcmp(con_id, "trigger-sources")) return ERR_PTR(-ENOENT); @@ -676,6 +674,7 @@ static struct gpio_desc *of_find_trigger_gpio(struct device_node *np, return desc; } +#endif typedef struct gpio_desc *(*of_find_gpio_quirk)(struct device_node *np, @@ -687,7 +686,9 @@ static const of_find_gpio_quirk of_find_gpio_quirks[] = { #if IS_ENABLED(CONFIG_SND_SOC_MT2701_CS42448) of_find_mt2701_gpio, #endif +#if IS_ENABLED(CONFIG_LEDS_TRIGGER_GPIO) of_find_trigger_gpio, +#endif NULL }; -- 2.55.0.229.g6434b31f56-goog