From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A28B1386C9 for ; Sat, 18 Jul 2026 07:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784360727; cv=none; b=k1xwH3BaaaT03nTBhBt6Q4sooLQbtyfxbcWsjErHQscQ7FsKT/JkPYv/SNedPM25SMCVx1ktiQCGSU8S3bN1TMx/vH7+nNyNtR+3ylefLEqzE+8GdRzJV/IA4OmCXZ30hUTQwTWHODMMA/Svlkss7OUXgi08Eaxs85ehbLx3gRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784360727; c=relaxed/simple; bh=vLJMBFwSvHTV7ro0RMeZwMqseUJXnE7dHXV5exqOQi4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BfXtYtBzgGu/HuN3k4MzxyGQGkyM80PkCJ8+mrK4psc/rDIk6C79MhQlUTjJwA3HZLhIQfNaGuTEbm72A8Ai+JCol0vpcoaYrbYjAOH6cOTrt1JL+ZOnGn0G2cWwSULEOCJNUW6nmElUPOpBj/dX75267I8uJC4kUXJC+pe+mZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mEwBcpbH; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mEwBcpbH" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ccdb73f0e1so47119505ad.3 for ; Sat, 18 Jul 2026 00:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784360726; x=1784965526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OFyV2Rkgf5HtfQYv0w6PI4pQpZkaJeMYAvZn1zRWRf4=; b=mEwBcpbHzGJ0op6afW6hCsjqyO2emHJcv1Ou2P37Y9sDsZYa7on3Sm9w9ma/CsNmsP XK4UFaxyhNkcr7LySZTbOwJWdswS0nhliolv3Kq5itrskqI5fzcN6a1agAJISq8N6Vg7 8JfZS+G7tau+voHG0+o3vMdPxW9PHeoMFMI1yRngIfHVKz3yFJ3vy6wjhuAqrDmPWFYq YiDNxQ0l1nxgxYFIdUvuI75XyOsyDGv399G8MU1L/BMQG30qL+wgtwQeoXEKpIgnKOLD kEv+AIcaE+AQzs0bH8XSRltCw+1bByZf1HMarNY2qr0QUGw6w2rRrMvsewgYIErSk0fd F/mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784360726; x=1784965526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OFyV2Rkgf5HtfQYv0w6PI4pQpZkaJeMYAvZn1zRWRf4=; b=cRXhyRnGYLI//L0JWVpG8r2JdDPDbFBsy5ZZKOXFCQfBrV5SC7XuXD8HI7LH/zyuvR pqOck1Q+jVtgKntlruJXd3e6dqlGgVgqr7T5Ds1SXYoIz2KrRrgYtCOMShfTqKWFwHP7 xB/kryieRuEliLE6xFhw4rPIent5XMP3V+M5ZcQPs2JsC5GFq1qSBpgDw0h4vIStS5tP NROetSh3cip0DexThNV4z89pQq+3iQhkpusDR4zxgvxEfcBxqToJojq3w6tuHJzCT/jN FqXCV/sB2apQbRVRubkSsnJjCkzS3ZE713yVJioKC4wyxr8w84j2n30FFwd0wHHar9nF iWZw== X-Forwarded-Encrypted: i=1; AHgh+RqiSNwv8hi2OkkupGCtU9XxWQJKn6z3uWeDhQdPk4Gl+PBaq4DIlYbbmE+27Ml66WyD7ro2GwQTDoCzjoU=@vger.kernel.org X-Gm-Message-State: AOJu0YwPdNWUTxgdOXojkUCy1pVH7heHCwizEI3rKDNzifTQCACvEZdr tNvXL8TpO9CkdDqr+H4rmd34B2TzREd0Isz+Xahlac8512kRS+CWkYWR X-Gm-Gg: AfdE7ck6ugD+d822I2OR9kL39q71T2NuMemVrGf/haEe70IdUwHlDf0bZ+hcjqqXrG2 nG3qhR2bFqZ9JG8w3wxm7wXFz6nFTVkqrAiapbSX/gIulNrhKx/j1FHBMVqah0038fjyZffnkIV S4gIHxEp3JYV+jYYpzj8b+eCxdRb4hvOnWyajG5cF4X1vRRPL1Gjhoz/iLrLkMkLz6mFAbCz8kd ki0EBC0DSvnrDG7CWxUgMYpZBolSydzVpQcNDHxqZEtCL5hKq6fy7iveSE9RFyIPas8L9s/LYti srjA5IREFBKHYIm32FBuTEnIp7SY/tqYksnV00efV+eY0Or5/BtC2KIHWKWrutXMZVmCEs9xpgh Kv7Pf2CxnTVE5Cqe/qjlBY+jERPCNqAHmYTYbCfmvP9RNK4aupN3g2W+A3E1K8ptQDYE= X-Received: by 2002:a17:903:1aeb:b0:2c9:b8b7:5d1c with SMTP id d9443c01a7336-2cf3486ef6emr68540395ad.16.1784360725629; Sat, 18 Jul 2026 00:45:25 -0700 (PDT) Received: from lgs.. ([152.32.188.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf346da07csm23399685ad.52.2026.07.18.00.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 00:45:25 -0700 (PDT) From: Guangshuo Li To: Jeff Johnson , Pradeep Kumar Chitrapu , Vasanthakumar Thiagarajan , Sathishkumar Muruganandam , Anilkumar Kolli , Ganesh Sesetti , Baochen Qiang , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org Cc: Guangshuo Li Subject: [PATCH v3 1/2] wifi: ath11k: release QMI handle on late init failures Date: Sat, 18 Jul 2026 15:40:25 +0800 Message-ID: <20260718074026.3085688-2-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260718074026.3085688-1-lgs201920130244@gmail.com> References: <20260718074026.3085688-1-lgs201920130244@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ath11k_qmi_init_service() initializes the QMI handle before allocating the QMI event workqueue and registering the service lookup. If either of these later initialization steps fails, the function returns without releasing the initialized QMI handle, leaking its resources. Release the QMI handle on the late failure paths. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Guangshuo Li --- drivers/net/wireless/ath/ath11k/qmi.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c index 410a7ee076a0..6e3f82169d24 100644 --- a/drivers/net/wireless/ath/ath11k/qmi.c +++ b/drivers/net/wireless/ath/ath11k/qmi.c @@ -3329,7 +3329,8 @@ int ath11k_qmi_init_service(struct ath11k_base *ab) ab->qmi.event_wq = alloc_ordered_workqueue("ath11k_qmi_driver_event", 0); if (!ab->qmi.event_wq) { ath11k_err(ab, "failed to allocate workqueue\n"); - return -EFAULT; + ret = -EFAULT; + goto err_release_qmi_handle; } INIT_LIST_HEAD(&ab->qmi.event_list); @@ -3342,9 +3343,14 @@ int ath11k_qmi_init_service(struct ath11k_base *ab) if (ret < 0) { ath11k_warn(ab, "failed to add qmi lookup: %d\n", ret); destroy_workqueue(ab->qmi.event_wq); - return ret; + goto err_release_qmi_handle; } + return ret; + +err_release_qmi_handle: + qmi_handle_release(&ab->qmi.handle); + return ret; } -- 2.43.0