From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6225348C7D for ; Sat, 18 Jul 2026 09:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784366768; cv=none; b=D3v0vjcAwm0qM+D8S0XbORHLAwkB5Vp9hXPhOHStcdT1VcB3QLscmW9hj3/X8vZZ5N4B9x7NlCFUMaFI2j3B965A8pQCISNgKNKQoHWiCJYeGR+bdZFADMYCzfqEJpSMsxo8iquaPv7AavYGLf8xeZAnG6noFac5Qao0ZZQfDRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784366768; c=relaxed/simple; bh=U1dSyGmpO4jyK0gdMbi0zGrAKcDsiwvzn2p+5O8OCHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FZDrgxRjArYy+b5K7/WbgN1iAL2A9v5skOOmBM9BvdqgQAmAUpVHwf0AyYHhMl7uwWrAvV9/hhDxCEZEmAvwNTmk4TuXrgzm/GJK2CaQoPXP/J709+LYpqKq08MR1I6Ni4gABBlRAheLntFLVsDMbmmlD18cJvXN/rWrihP6ic0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LzpPje27; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzpPje27" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8487214ad2bso7345986b3a.1 for ; Sat, 18 Jul 2026 02:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784366767; x=1784971567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nz7xYB5+RsFyTrGLAYiyXPfONarJ2CKVSQ+VTT23UHc=; b=LzpPje27LWVOKeMzU8vFL2LtS3Y3KXz+NuaorAXsP0H72rTF47KfnuJ2gC2tde6Uql mYO63RRGtzR6a3Me+S32DNkl0EKIfoFeE0GsI/jLG0fAzvWVJ+qv9nGdA8AcV1dv2ivR JJvAHV3ysGx0QoG+SeOb/1B7bQgTy5tVUpk2Bn/leorF24Up5kLUCJZHJHoPqT4ZJUFU c6ZN1ftmoJZulY2QdZqr2MZzWxVJQjhj6KVwUYFlE1NdFMQ9oJ8rHELajQ6nJU7WIpPn wTjKt0RgmYpYxneBDtcn9s2YI1PuvE2Cp7VOfTr38pjSQ169GssyIPXvuPHSsVvE1wg9 ACSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784366767; x=1784971567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=nz7xYB5+RsFyTrGLAYiyXPfONarJ2CKVSQ+VTT23UHc=; b=JPMU5p2EnpUl2vZU6wM8WDcbeCMR+tUNQXKSqRJDFL7unUwqMrR5TG/6Ziy/vd3kxD c/w7MvNbSw4jJBAgAYVmgaS1GlviwhX5izjP9R8GAoggZiEqhxG+qwBgnjuGNvw9lrtF dgY4WshzS4azTtWzaI792h4boN/JIxyuzNBZa06n8OqhBH2clollZwF2Zl7D4xb8Voob UiosofJcqAfPX/6ZLxmvpfdTu4ZI6y6dxrhs9LseBJOyezVs0ytSR8ZP49Q+LadPQMsd HyZdmvJBSmRboWzD9t8HHtDm/JiVngabEGQ1FBVq0bvma9YW2St3HHhYVn1dCMPHbAYR fmPQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4l0spsdmNFnH9in1/G17ocUk3tWmjeTnOJZMoywyEngaxxw+f5V5BqEgWs+8+HVQCTUi5ONKF5wGm6pY=@vger.kernel.org X-Gm-Message-State: AOJu0YxdXHOFoEWmSowChR3Q/RPeb9bSwuDs7Dxvvb5+kr+8Fc8GJZ5U vaJxHAqHl7ATVJ8ZA38thPaFLJbkaTYjG8o5gv64k1pIdWA13PPfTN10j2Zm0EhcehkZRg== X-Gm-Gg: AfdE7cnbzh1t9RLdnapHEB9SD+Bzm322xCSnZJ2fSgzjME2pQ6MhpGQeSrMISrO41h2 bLt7LjZevRG2sf2eWadDqsPZBp8/F4/Ffi5DmF3yoaDBP3Gbr+TMQcS7mY24uXfH49E6peeG7Qt T7s9FGcKwBM2bkpBPlIvrXmLkLpX4eQrD8baBqJLFVpxpuT8GZfgLWLh8U/NRYTPGnzMkbT6V+L 4aqp9Sjexh0Puw1fIHULN2mmwccZ+Qc3Qu9ElWaITBbTLi/W8oXBBErHgTgZEos8iLmlsqs+WRi pGd8FvVNlRGR9y3jQcF/NRXZD8wI4ynnwIJ1eodryn/F9l02fOsvBX07KoNXrTRogLkZ240FPYB GzYaKPcjwS0oXcKJZIUgIvFu4bwM/hLrl8wWWc85zq6AKZv5B8iCiY0Kn7yNU1M/7YiszqwIfH4 9j+nX//JN6mi/eB/OBF7bfCEZIokxMk6H2habGLA== X-Received: by 2002:a05:6a00:451c:b0:842:6004:3fda with SMTP id d2e1a72fcca58-84c292e057dmr6396793b3a.25.1784366767174; Sat, 18 Jul 2026 02:26:07 -0700 (PDT) Received: from kimi-bug-hunter.. ([47.84.186.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c30fb62fesm1950464b3a.29.2026.07.18.02.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 02:26:06 -0700 (PDT) From: Weiming Shi To: Jon Maloy , Tung Nguyen , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Cc: Xiang Mei , Weiming Shi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net v8 3/3] tipc: fix node reference leak when defer work is already pending Date: Sat, 18 Jul 2026 17:25:43 +0800 Message-ID: <20260718092544.785289-4-bestswngs@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260718092544.785289-1-bestswngs@gmail.com> References: <20260718092544.785289-1-bestswngs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In tipc_node_write_unlock(), TIPC_NOTIFY_NODE_UP with an empty cluster_scope takes a node reference and schedules n->work. If the link flaps down and up while that work is still pending, the next NODE_UP takes another reference, but schedule_work() returns false and the extra reference is never dropped. The tipc_node structure leaks. Verified by flapping the bearer while the work is pending: one reference is leaked per repeated NODE_UP, while the work is put only once when it finally runs. Drop the reference when the work was already queued. Reported-by: Xiang Mei Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Weiming Shi --- net/tipc/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index f757722d15be..f826347b5870 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -447,7 +447,8 @@ static void tipc_node_write_unlock(struct tipc_node *n) /* Defer bulk distribution to work queue */ if (rc > 0) { tipc_node_get(n); - schedule_work(&n->work); + if (!schedule_work(&n->work)) + tipc_node_put(n); } else if (rc < 0) { /* Bring the link down to start over bulk distribution * when the link is up again. -- 2.43.0