From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD6737AA78 for ; Sat, 18 Jul 2026 13:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784380486; cv=none; b=SdqtMnKdUavC1wC0kDKwccHPRSRKOV5gCbPPl06jyaHiSAGmHNOB1+qdwDZTDoJ4OkwTwPqHTol+3/udPoLGWCHjbT/pL5f4mNe56Q/nP0emaN27P7FmYzRUX9R7wi+6gUdtbgX/TMvKYVxlXseKQFai9L9xA6UbZBrM+EGX5d0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784380486; c=relaxed/simple; bh=vMxi0GBCmk6kSxxY3msXn6b8DUdRebKtLoidNsiWryg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JGZR7UIWW0wF4YRtvr4BhmK0KtwfOs3lrAQDX5wtBxgbBINJNzxhyoKdR0PHgNeJ19XyBrwRdQbBhYSfR3Hi1vrhgQz0zXLQ+2qT8drGfGuQsQxHHA3eDKjbl1nFTa8eKvqr4B1mjPuX9iwfiKZ0Hn1vbcUxJ01Uk1oqdG55xg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38dc4553f62so7087502a91.0 for ; Sat, 18 Jul 2026 06:14:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784380485; x=1784985285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lgLs8NK0XHHTysnGduh8WTtXMi/Zls+hjiJh2kwYBOI=; b=EBeXlfz+QRW9uje/8AANpRoDtGfiGMUVPNc983uaGkT9IAkS13Ir72iH/hOewgVwMO 45pTrlQfJa9NVMt8QMDx/Epq/NWl8RTPUqObSOZag2rth9Eu55J88j6S8TOW6zQ7gBPB Bkv+6K6lu9tluwKK5QJpa7NQq6FNtQJksUPKqFK0tErFUIfybO49GEPly7CpOtzjVWXr vJIVkJR/NmFHLWz45G61xtKhPC6dNM7g+npNTZqNcCmB2fTposa62N1jQA+YK3mQfx/r PfFdukQW/hLx30zZKuIoSE+LnXVP1rE38yEpiBAcg4Mx5TORyFcEcyHHzxKzjSxcVv/k KXhw== X-Forwarded-Encrypted: i=1; AHgh+Rr6ru/2CVHeXUqz7V4eFphSvYbEvM9Lf9ry8oKJtj29diqFG0JyDr9UPKLMhYPAO3SDRcHPycmxN6Gg69s=@vger.kernel.org X-Gm-Message-State: AOJu0YxeLmwnPolx/eRpKieQ6ZoYvE2e3L8dTdG+j64j5XQEO5+T5qTR ViDIhyJYgemrPPJho+aFKpDdw19oTZSfr6/dVS5WxeLWpAuWBfzl5UNRMSmyYOCOYA== X-Gm-Gg: AfdE7cmHo4D/p2dQy0o5ezwoH0Oo0zaFNo+U2LqxwUWsT9/DE4cQB3mcwq86BndUKdh +v24gLCTm/s39eBXXxmflwvlGzqNgvlQybD6p1BMIwi5UmD76nVfQftry0B43xGrUqLq17EistK eH0Tjv+Z84mBx1zsa5ZTlLqnQf5Trygs/DTTqou0+4LsPhVfJljxccPGq+dgX7x2T0HO1k8iC/e jgZHcX9Mbcn7Q+f4APmU6B7F1Si41szhtbyaa2ctPUGyvv77j/2zz2GIP7+A+T/FvoJ+MZXcDcb l5rFUbobnkasqaDlTWdz7dSDuZ+sLkXYZ6j/aDyNHfYi56Sx3aUcMCv/fW9NBdSDEexB3x+1Bld DU74H/mVpj5NIvHDp8RhshvaDB4aA8VEwIP1xUqginq1+ZzfauB+sA+dHalkD/H2K32jHc7SZTz foArk/UBzkdkJCYh814Gm37fuXf8QSCu8x321PjwNQcfqoDIIWUS8cn+ZuCCRdvOd5F5qR2lQ0t 90j+k/XDTKFpRQ= X-Received: by 2002:a17:90b:2f85:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-38e4b3e1015mr6953701a91.1.1784380484477; Sat, 18 Jul 2026 06:14:44 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-48-72.dynamic-ip.hinet.net. [61.228.48.72]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e4b0e9bb5sm2706400a91.11.2026.07.18.06.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 06:14:43 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v10 1/3] spi: pxa2xx: disable DMA for Apple MacBook8,1 Date: Sat, 18 Jul 2026 21:14:29 +0800 Message-Id: <20260718131431.3393-2-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260718131431.3393-1-fourdollars@debian.org> References: <20260718131431.3393-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On MacBook8,1 (early 2015 12" MacBook), the LPSS SPI controller at 00:15.4 suffers from hardware DMA handshake failures and interrupt routing bugs, causing keyboard/touchpad transactions to fail when DMA is enabled. Move the forced PIO mode DMI quirk to spi-pxa2xx-pci.c (the LPSS host controller PCI glue driver) to avoid layering violations in client drivers (such as applespi). Add an explicit DMI match table for MacBook8,1 and a module parameter spi_pxa2xx_force_pio to allow forcing PIO mode on demand. Link: https://bugzilla.kernel.org/show_bug.cgi?id=108331 Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx-pci.c | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c index cae77ac18520..31bdaa096d9e 100644 --- a/drivers/spi/spi-pxa2xx-pci.c +++ b/drivers/spi/spi-pxa2xx-pci.c @@ -18,9 +18,14 @@ #include #include +#include #include "spi-pxa2xx.h" +static bool spi_pxa2xx_force_pio; +module_param_named(force_pio, spi_pxa2xx_force_pio, bool, 0444); +MODULE_PARM_DESC(force_pio, "Force PIO mode (disables DMA) for SPI transfers. ([0] = disabled, 1 = enabled)"); + #define PCI_DEVICE_ID_INTEL_QUARK_X1000 0x0935 #define PCI_DEVICE_ID_INTEL_BYT 0x0f0e #define PCI_DEVICE_ID_INTEL_MRFLD 0x1194 @@ -93,6 +98,32 @@ static void lpss_dma_put_device(void *dma_dev) pci_dev_put(dma_dev); } +static const struct dmi_system_id pxa2xx_spi_pci_dmi_table[] = { + { + .ident = "Apple MacBook8,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "MacBook8,1"), + }, + }, + { } +}; + +static bool pxa2xx_spi_pci_can_dma(struct pci_dev *dev) +{ + if (spi_pxa2xx_force_pio) { + pci_info(dev, "Forcing PIO mode (disabling DMA)\n"); + return false; + } + + if (dmi_check_system(pxa2xx_spi_pci_dmi_table)) { + pci_info(dev, "MacBook8,1 detected: disabling DMA to force PIO mode\n"); + return false; + } + + return true; +} + static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) { struct ssp_device *ssp = &c->ssp; @@ -166,7 +197,7 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) c->dma_filter = lpss_dma_filter; c->dma_burst_size = 1; - c->enable_dma = 1; + c->enable_dma = pxa2xx_spi_pci_can_dma(dev); return 0; } @@ -238,7 +269,7 @@ static int mrfld_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) c->dma_filter = lpss_dma_filter; c->dma_burst_size = 8; - c->enable_dma = 1; + c->enable_dma = pxa2xx_spi_pci_can_dma(dev); return 0; } -- 2.39.5