From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013001.outbound.protection.outlook.com [40.93.196.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0950C3E00BD for ; Sat, 18 Jul 2026 17:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.1 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394957; cv=fail; b=Y9w5DiuHyvSQEtq2vAlxGio95Ee7uEGyAaUeBuzwwiGraaOOAPVx013fBnP5zOOgDBxo8fWycfC32qAh1Q08+564obmvqk0x26zwItY4JFT86t28mM1+AYmnRg3Syf8itmGbe7/GTVQI5R3NDffSAO4Yv92VUoHuj+fpiCOO5cI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784394957; c=relaxed/simple; bh=0PcazMoXnEHj/tGBYZQSPqXcy5yvtsCRkmN8HQp+d2Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Y4EEbt5s4uJ2+V/GyXmx2/ByPu+ZanglVehra9X7VX2jERjMZpzO0wUdf4gefY9VrpLkiCBgfmD5G6aaYDpz4q7jVYHwTBuLPdqDaRPKwbSAIfLOMQnto9z7x44Ajx5f7kyCZ7wX6iIZebHN+lJdbyDVSYhnzzN+xgU4KAwgTQ0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=GqoNixGP; arc=fail smtp.client-ip=40.93.196.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="GqoNixGP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iEBq1uGWAG7rJCe/tRGDHWqiS3eerDBaNKMFKbIHBvzYTVeH6GFZlB8T/ime8dXYEZ5Mu+gEptDVmDcl6S9ajy9kK0wfxaiVBHidiul3jvbJP10cITLDgIlwu9CdhIni4sjO6AEini0SMMYKWpFdS43CazLJxj+8NhcQGgCK1rdqkmEnn0kgHe8/0Rm7w0OD20reDGupBP3rQ75TK5FwLxuPe42EiJQKvnEmQPakER1XvWvXXcnRwDX6pa/6bXO6fusA9BBsbv3rJ/WluYW+UY+kIHESTYsnCVloTl5AHLrXhRTcN48d1adzi/s026/nNNVsvnk5oSxK7mW/Re72Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98sTwwkCp7+UrCTR/JLHPF0xeptGngDtkDwrPHFpo2Q=; b=RfAhJWG6SunDCEEWX6vMnBGKfY0gyQTwrk54syiVgAhbQdUJRG4OIHdSS7W4Q607yqa7pTMl8ECiJ2rEUVIh43u57kSC2y4BB4hhFmyzko+qbg1TEX8kDmS2uJeYkmBn3FMUHy9Nh7iZO7ZtEIUP3MHXMZMIkAkkaCHCHGmVEZyl2be3tPQZF4/VZa9edbCGm+/CK7J74AleMbe6iSHt4LVBFeyCVrIjIKHK3PgNl/tRGGtwh4+A8wS4Bbbt9PGQ0JJq2lodp7ytL9HsoxJHzGpwWr4ZatbV1UwsIU/6etv2rYLSs42ezMm2prGizUjAF9X9tCxMp5aozWOzQl/+Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98sTwwkCp7+UrCTR/JLHPF0xeptGngDtkDwrPHFpo2Q=; b=GqoNixGPapwiIV3z9jcd9ZmSCdhvVQwJ9LBAEFErU4e03SXkJrJWEvQIASxINNbAbfqkLks+ta6bot0gGvxB2wchT7UBdLJRJBFTYR0/Ob+jtgtWGM710yA7x/nzMGkZszva7nButbOI6bUdVhtSwXb5XG2nmZbGPc1rpQS2UZUKgufNRW4ExJD3ac1rACOkHLRXOy9hZgtk0Dr04VmkgAXUSs/x8pxHLB1fbafL/gp5VMGXRuhm9Ak110JhZ1YwagZ8hETKsywU1zcJ2bbcSTl39rGCW6UJZGUKaoMwCqYFT6pj2DLJaXNez7LcnYMsLS+T6zXEztFiWD3p1njD3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) by SN7PR12MB7276.namprd12.prod.outlook.com (2603:10b6:806:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.13; Sat, 18 Jul 2026 17:15:52 +0000 Received: from DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33]) by DS0PR12MB6486.namprd12.prod.outlook.com ([fe80::88a9:f314:c95f:8b33%6]) with mapi id 15.21.0223.012; Sat, 18 Jul 2026 17:15:52 +0000 From: Joel Fernandes To: linux-kernel@vger.kernel.org, Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett Cc: Joel Fernandes Subject: [PATCH v1 4/6] torture: Don't leak shuffle_tmp_mask when shuffler kthread fails to start Date: Sat, 18 Jul 2026 13:15:35 -0400 Message-Id: <20260718171539.3781595-5-joelagnelf@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260718171539.3781595-1-joelagnelf@nvidia.com> References: <20260718171539.3781595-1-joelagnelf@nvidia.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BLAPR03CA0102.namprd03.prod.outlook.com (2603:10b6:208:32a::17) To DS0PR12MB6486.namprd12.prod.outlook.com (2603:10b6:8:c5::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6486:EE_|SN7PR12MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 448ff060-5e5b-46e6-5c25-08dee4f03884 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|10067099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: ueiUHp9Ffy+NPj3iqpbgTmxsErvbczr6szyiuv62dn7GV9NMPVHXGVfDKG0otue8HRAeTv0Uq3Qm8CIS20vuMGJdt0nwO214j7U9jgmc2LJjB2N0sKAEmgNtu8GGLJBEdoKmcbNaNxs746SUMNZmlNoxhXrcd6e1sPepc/SInjyGgD5m1iwEg3lsURIkPSUQW9GukT7gDw0cez13KVRhOb6uML+BIpKUrtrJDxS8uM803mn+9ptlbEpDUZmPhljxGZckXu8F2gNUO8sYAYkXu9CSjMZN8CNRbDrEQxFWtdQrdfewvIJ1oFb1OczGzimKaMtG9XfI0TO7pEB4roq+7Wb6WrLaVz/u7LZSKfHiAq3z76Hannw0O8WNrBllcJmGOpyrRD4V/8H5jDCRn6DvdcybQlT9OJruZJmJ0Sd83Aj6IbBNLOY8Y/svTeU/DzlIH85qvOWMX863362f8lNqS259ZoSDv0dz5hOsez0GofdTO5U6Knv3PZvmnGsMOO+nHyBbEjXKr72NVUilvJ9D+Sr7n1VU5CkdFrcqn24TcSGlr4Yfg4CqylN6otE41GyTur+YNcH/DR3E/+JyetqEhHFX4X/5uzT/1DXCpI7f5lUW3PJmQ5zzM2qaclsjPPjoGPVvFzp7Gd2rZrpewrvwV6T4GFg7vvzodP70nebzboU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6486.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(10067099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DPRbc/ENmMllqmTkAZGHFsXvhgrPxt2sesBdl0YeyZ9JiRmBqn0dQgCe4GsF?= =?us-ascii?Q?xEbRPuNvEC4KWQZg6WpbpkmasuylQYBZ8xCbLuIAZEftsQvP9PDVoTTv16b+?= =?us-ascii?Q?QbhXYnsZh7j6aW1Jef/P5SVjLN9KSvLwyKcxGyyDOuiAq6jBzmG0t4lsQxrO?= =?us-ascii?Q?w0hZ/vVTGYj6gbAVRg4eti2XTvhJjux+pKw99UJKGBDLSHXdQPJFVhO1PX52?= =?us-ascii?Q?fAjQK7TjNOByxQcx6sz+fWGPliBV92TUXbNZg338ga3GcQuovuMRmGXrEbSi?= =?us-ascii?Q?7Yb2QzRn+WCTD5o8sErpvhGOLmc+OJI/rPN985Pba7hmKmjlfybSArwiQYAm?= =?us-ascii?Q?6RZv1cNN0dlzgp9xaYcV/OoqybqPUTXCqv4WpkhS2T0/ATbnOSqqcCI9vMd+?= =?us-ascii?Q?VU2twXVqEcRGGCZfdUjzmrZqqkNE/Bv2EXVOFUAC6/6EHVLz6Wh8KBPrbxOm?= =?us-ascii?Q?KX/B0hvtatdfDeW8z3MTMP54XtvTkUGzbvF/E4+MxQ6sprSKWU+hzimkfqPu?= =?us-ascii?Q?WkSsvOdX7Z+dtHC91vwbL8FV1ni8UxM8P1pPkjhArOTby1ICOnR28GBBO3j7?= =?us-ascii?Q?ZEG6enJu0KxcPwmSADmA3u9Lua9ikweZGc8wQ5xMhqs+3zSm8CdgJTRzTXa5?= =?us-ascii?Q?hY6GTcR3SQ1YDcBrbasKfqb79nGSbBMVqV0JT8UvTyztNI5HWfNHa0ESaqdJ?= =?us-ascii?Q?rzudb5tRW4nkBOSPg46c6pjx9AhMUSbjeQut9AzhS1WVcw34ndLswUyWWUH9?= =?us-ascii?Q?GgA1p3HFrrHSGpXnIMbJEVqNuKLzeETX/tt22UvrEpR6bcIdjxXFA2OR8GBJ?= =?us-ascii?Q?P0uoeZO+60Tcz076P1e5jARps+nHKmVLC7sncadNtrTAWyOjTIQVvg1OxVmH?= =?us-ascii?Q?PDEzCKTIpDDCt+U1M87RCasqace8kv7rW/vXNqppKO2vqy5JBloNpNDAmVed?= =?us-ascii?Q?jPFA7bKRcWyk1dyuJGgbqGdIlpwa7U3n0JbYyqDvH5f0h5iDajFh802BeMZ+?= =?us-ascii?Q?lPCP22UZzJMe3NAsZNidkAFq011KvrLKKer8aALOpL0gS6qwEdPAlslLjyVw?= =?us-ascii?Q?1GAubskRIa4DHB59piZt/oC9WwpJcrqTB80phcFWXAnZii0nzKCwbi430KxE?= =?us-ascii?Q?29h1fLf6caI0R+FB8k99z/PUXah0nucnm5B5mU5814dGX2ai8sXai9ZobHj3?= =?us-ascii?Q?yx11JbSQrR7dfPYTUGRbYlNnZ0Y4bpBUs5mrn44z6ifrKb9tUCj62eDPpWzv?= =?us-ascii?Q?EVnNz7hS7w+jgecJ9DuE2Mkr8v3+kzpAG5BXyRTP3KHO7J6rtNYCGOW9PQBQ?= =?us-ascii?Q?C0pkRDVyeojxHKEguURGN8fcVJFHCGkp31/1DYaySSb9ceI3U8A5uOau113e?= =?us-ascii?Q?IurOH3GN7tT1gU4c1xfkilNMJRzJEc+Pu9X9cjKv9xADRd4iwH//+W7pd5fh?= =?us-ascii?Q?WsuZMhZyajPfw9vH73D69a1AO7mu3DVFjvQdDQLWyzYHrMGAZmo5rJnjKRjC?= =?us-ascii?Q?WtoeYYJIJM8CTp7y8ftJ8cxCAxQ0HemrJEiP/Cdfh/diYt1fcp8MAhr7lQBn?= =?us-ascii?Q?bC+95mcZpNjuRFzHs714oXoogSBtmf9FM8S46aXvYW6Z9VgH6XVBm/A12Qci?= =?us-ascii?Q?FBGwiCi4K8jQRXiiXpCm6ZwlsUnJxgvfzRRMe6wqnIAfEFa6v5c4uRAFlQ2A?= =?us-ascii?Q?/hxaJ2RW1HJnsxChjSIlWtL/ZXuXwNZlkTZhbBG0ERDgv7H8LoNy67K781Cz?= =?us-ascii?Q?HNOp+A1UnA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 448ff060-5e5b-46e6-5c25-08dee4f03884 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6486.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2026 17:15:52.5400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IvNQOrFDLVj2uWR052AlpUEXCqJSmMZBllCCmzL7WjEB/CrLiuUlMoi5RpISYF7nj4cSPi/PBVVAIwKqCF2jrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7276 If torture_shuffle_init() successfully allocates shuffle_tmp_mask but then fails to create the torture_shuffle kthread, the cpumask is never freed. Free the cpumask directly on the kthread-creation error path. Signed-off-by: Joel Fernandes --- kernel/torture.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/torture.c b/kernel/torture.c index 77cb3589b19f..8c4e6b2fe8ba 100644 --- a/kernel/torture.c +++ b/kernel/torture.c @@ -577,6 +577,8 @@ static int torture_shuffle(void *arg) */ int torture_shuffle_init(long shuffint) { + int ret; + shuffle_interval = shuffint; shuffle_idle_cpu = -1; @@ -587,7 +589,10 @@ int torture_shuffle_init(long shuffint) } /* Create the shuffler thread */ - return torture_create_kthread(torture_shuffle, NULL, shuffler_task); + ret = torture_create_kthread(torture_shuffle, NULL, shuffler_task); + if (ret) + free_cpumask_var(shuffle_tmp_mask); + return ret; } EXPORT_SYMBOL_GPL(torture_shuffle_init); -- 2.34.1