From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE01D33DEFE for ; Sat, 18 Jul 2026 22:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784414858; cv=none; b=cBenQsyYUgli96Vrp/mth1hyIlNB5HiUsEOU8SnDhPOXgsFd0wo8zBngb7RVGF7tPAAsZFetgDa8hEQRq0hRcDg1fTK9Bsf7GUH6OiSpqCUrVn3ljda3bq4YblHHGQN4/OIJnRSMTmNnyDgK8O2DA+9F8o03bE9ZuH1J5q3RlFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784414858; c=relaxed/simple; bh=pckjIq8Ttd0rTEfVDBMjJ/G2Kb71+I0Uz2D4Kjr9KYU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b/u9s7NAfDqYHU1i6PA8aoTR5Qq1BwKkaIEAbQZtPobhIz14TgQH2atOlwr6DOYUiC8VskG1vWksZwXxewlJVpof8CVCkbbMdot7yrTPJGeVGrOjT6lMeyBHSI9Trz9AdFBTdDQytmM2TcVK7Na3JTjI8CXIZDCuq6mpVGKgZX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j2bSubJd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ThdP1cjD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j2bSubJd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ThdP1cjD" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66IJpxUj1518618 for ; Sat, 18 Jul 2026 22:47:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KUxBuVxWLmE5joEMYT6ask8WyypP7efysolvlE+mCGE=; b=j2bSubJdrdVuJWnx 7iFhwM1TgJySrjUC6XlcCHA/KLtJqlS0NBlPL4nDazA2X+kRCfZOWHWv1CR9VZ7w R9iA+r3lZf5Ft+Qh2SViWq4POfs2gNjOoC5S0CNWHR9m6Kdctn1XsWNmYIhYJ/nk +zPgDCy5j6OVaHKNd//RdZmYEgyLzzA9eUzDsP8uuYMZ2+jA/C8FRoQ0WVhVa+cg Rwl3FFuavwY2U+sW3qgexVvlmeo+2wXPiwmpZwEEuxJbVTxvQlljkBu3xSYzbN8O iwYytFmGm9ODgsewKsHrovQBIpxl8YFyhIkLX1V31EkzbUMqceVGHYDbKANU4ICI 0dgwyQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2bnhp79-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Jul 2026 22:47:35 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-848544a8496so6619498b3a.0 for ; Sat, 18 Jul 2026 15:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784414855; x=1785019655; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KUxBuVxWLmE5joEMYT6ask8WyypP7efysolvlE+mCGE=; b=ThdP1cjDtabkg6vvyRcZSOKgBLQzGJs+NmVBiM7vV3HawwgN9Eitr8KDOKR1vTkkkf fFYzAzN2YL/VfHoziwtMXxQ8Wn0vKpFuIZX7M/JRfnFtzOBta9in9s4eazkXXUKBoRm6 nJnqiHasTSe5eTn9APfgsdgorTV4g1/ItQ7uloxC4qCnsM0Bq6HyVo83Z2BSiMrgYOft pUhPlrhG1e76z2hYHEU2ti8WWLMqiOQZPDGKqG8A38LWwiIcmg7Lgp3c6UHGK4JptLzC vYsgsKlGP56LC4m82lUNUg6MNWOv5HEaCTKAaVqTd5LUSskoP/wHDTgcGTyUCpd0pO4d LGzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784414855; x=1785019655; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KUxBuVxWLmE5joEMYT6ask8WyypP7efysolvlE+mCGE=; b=hwhTfZqdLEGl6fJBm2tIQiPtaxDD5bE+iZiyjdrmNtXu6nngkM6TTshsInKWiNR6Dr R6IuYJQJCfDd8/KMkhyVdSTapOXuSECb7OxeaI93lkvK2U9AIvPetThl2bKor6E/dc8h jmLnISRdpIikOa3TSePLOyPIH1MbcYIsX5znazUQ3cHZXLaAZaR7AmnrK6qEvsLVQ0Xf gMKBp+HicsumgNuCwyg981ikso8427i08kco6sUVUE1ZVEUj41ow7EStDLV04sjD5D2K hZApsDgUuz0KsisX4+EBUYRo8pPqp6wPYD5Xlbc87k6nb1t5djVbr3YqMa2poEccZTqT b+Zw== X-Forwarded-Encrypted: i=1; AHgh+RopMEGRpb9HWkn09cz/4i9+t9y6soXc6GGGk6YEoSFttKvtRDR7+3Zd/uWzQXi8D63dcGoydl+V0wL57R4=@vger.kernel.org X-Gm-Message-State: AOJu0YxIUU6dlDBNoLwghAiNKMINtEKa2Pehv/mvZpgDq11HIQnbjaRb aqkGibkpg/JcTCg54CT+aGG/G4OfAk7iypzycbR4kdx7Hj8OrjNSJGBe/9MWPihlcJr8+eh9eqQ w8TnBmgwaqbIXs0hj0sitTgYbqjMoID4TBDINOMrQqsJuEyyMFDaSRsA6BCMhPrlOBTA= X-Gm-Gg: AfdE7clZaQp00sJB0FtcdU36UBghqfG9NUbAwzBV15x7wy2jcumOZO6c2dRkDviCXC2 6ywxHmg2sEjkFS12eQ60g3FRMprs0uMhUoTBrO+iWLhK1FBkI/XvK/8I4x3cqZylIcCeFv3K+1v LSogLQvcRObeM4/llr+fKQGzHL5PxsX3E1wYG8MqC7Ju5qezhhP5eZn9frF5eeqFuR9Q1Dx0KyM 2tHSUt+RbVTJQz5RFSHluXf1BvTeSU4WIdiH49EGsWfHTc3iigFyCLP+eZGDjY1qsWaa+AdMf7b 8GMVDPopihtI+Bv6dHNaYTRkqM2bPOd8GOl/+FmHXQgQSSqlm8WJhbN9mRgm0yzcm4wskdQOdJA 8NWEky6QHhl8zkvrP X-Received: by 2002:a05:6a00:1945:b0:847:7a61:e68e with SMTP id d2e1a72fcca58-84c292d2621mr7965887b3a.31.1784414854653; Sat, 18 Jul 2026 15:47:34 -0700 (PDT) X-Received: by 2002:a05:6a00:1945:b0:847:7a61:e68e with SMTP id d2e1a72fcca58-84c292d2621mr7965874b3a.31.1784414854197; Sat, 18 Jul 2026 15:47:34 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb517f8ffcbsm2526094a12.12.2026.07.18.15.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 15:47:33 -0700 (PDT) Date: Sat, 18 Jul 2026 23:47:28 +0100 From: Jonathan Cameron To: =?UTF-8?B?UGF3ZcWCIFdpxZtuaWV3c2tp?= Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, ak@it-klinger.de, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] iio: proximity: srf04: Add Cytron HC-SR04 support Message-ID: <20260718234717.6f361fb9@jic23-huawei> In-Reply-To: <3fedc827a2581d61bef9ea639ed77cf90e80047a.1784221074.git.pawel.wis.me@gmail.com> References: <3fedc827a2581d61bef9ea639ed77cf90e80047a.1784221074.git.pawel.wis.me@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: C5dIDc8krepeR5c4CLXoerTfGAWXbvuu X-Proofpoint-ORIG-GUID: C5dIDc8krepeR5c4CLXoerTfGAWXbvuu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE4MDIzOSBTYWx0ZWRfX8pshtnqvBySe ffpCninJw1kDrfmvbevJ+6ylE15VIccSzQw/6aAAn/XBt97f98JyLT6OKD9koUUXez4YurTCDp6 1+nnVdTBL9SEO/GvEl1sBcoXJMQUOpoFx6GJVnImdQFAZKdnizMNaiQruASbYy4mQJ8HPLVM1Yy uEuPoo68nxtEDd1qYbnc6QgPdsfQwI+ixXIYcOmrgprUZw7HF0uNZMy5VX+Gt3TQ8pxjOPIwFud D4CgwFX1UqG7VRS2q+0Vsy2DvNHwvXUrzxdkS3pLsWeXKeg/Byy0RS8wBSsJWk5cZ9HxN/qphun CV8MQcOO0q3umAc9JCPylnSwEz8yrbLSqoz0L5z1qdWcWh5HPqSz+qCOHN8060UGUXeWxPAyKPA XhfU+JHo+phEJqr0vALYbumA8/wJl8Tr89iS7gEfHIcwE8Yio+hH1Iz7VS1vt5BEtOqmr7mNe+P i96ebf7W5Vzh6h12fPg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE4MDIzOSBTYWx0ZWRfX3ZqIjlkGj7+j luJ3T63KBdU4IaONkboPksy/w6dL9YgSimyD4UguYhvQWStphAn63G4ckPBbyB9yF45UTWinq5l wFPn5eKgL/GhHkEPsDxyzVUXeoV5stk= X-Authority-Analysis: v=2.4 cv=YsQ/gYYX c=1 sm=1 tr=0 ts=6a5c0287 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=u0yN2JLCdhNhSCvD-MMA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-18_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607180239 On Thu, 16 Jul 2026 19:35:56 +0200 Pawe=C5=82 Wi=C5=9Bniewski wrote: > Tested on a Raspberry Pi 3 Model B+ running > 6.18.34+rpt-rpi-v8. The sensor was instantiated using only the > cytron,hc-sr04 compatible, with trigger connected to GPIO17 and echo > connected to GPIO27 through a 5 V to 3.3 V resistor divider. The > driver bound to the device, registered an IIO device, and returned > changing distance readings through in_distance_raw. >=20 > Assisted-by: ChatGPT:GPT-5.6 Thinking > Signed-off-by: Pawe=C5=82 Wi=C5=9Bniewski This suggests that it is very much suited to a fallback compatible to the Devantech SRF04 (see comment I made on the binding). With that in place, we probably don't need a driver change. Thanks, Jonathan > --- > drivers/iio/proximity/Kconfig | 1 + > drivers/iio/proximity/srf04.c | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig > index bb77fad2a1b3..89e9d57ceba6 100644 > --- a/drivers/iio/proximity/Kconfig > +++ b/drivers/iio/proximity/Kconfig > @@ -139,6 +139,7 @@ config SRF04 > ranger sensor. This driver can be used to measure the distance > of objects. It is using two GPIOs. > Actually Supported types are: > + - Cytron HC-SR04 > - Devantech SRF04 > - Maxbotix mb1000 > - Maxbotix mb1010 > diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c > index 7be50bdebfcb..f5ee7d6572b5 100644 > --- a/drivers/iio/proximity/srf04.c > +++ b/drivers/iio/proximity/srf04.c > @@ -231,6 +231,7 @@ static const struct iio_chan_spec srf04_chan_spec[] = =3D { > }; > =20 > static const struct of_device_id of_srf04_match[] =3D { > + { .compatible =3D "cytron,hc-sr04", .data =3D &srf04_cfg }, > { .compatible =3D "devantech,srf04", .data =3D &srf04_cfg }, > { .compatible =3D "maxbotix,mb1000", .data =3D &mb_lv_cfg }, > { .compatible =3D "maxbotix,mb1010", .data =3D &mb_lv_cfg },