From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1D92475E3 for ; Sat, 18 Jul 2026 22:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784415044; cv=none; b=l9dj5++zttbp0s/jedW4INUORbV2Ghmb/I/TfFgoZLoaKtOBadcgekcP9qDt1sYQ8TcVxVfwNtw5TdUv9sbCVKdxA2h6F7I6DRC94t3TXQs+MHttqaz7HZWKU4JVctf3UHeI7no2/P6TU9VnyT4JmktM0j9E5La0nZNucCELAc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784415044; c=relaxed/simple; bh=obJQuYiFerRlAZsJd5YSFky/LorP6Nw6+tKO6ZSHaU0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZevN2PU7gSC+WAxjcPcwl2yjc4Aj3uNl7XO6QX3miwtbXdko6FeYc/CXZS1JjqL62NbE3HQlNMFe90U8G2qW9Lc0MUYOLsvnnWQ7XXN1kPrKhotKq7fZCtiWV8xJJEqsu7C8SzVXeWMQD7SPF7a0a8Swq/Ty/SU1wx7c8hescZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+x/8SfU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C6z6ZA/c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+x/8SfU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C6z6ZA/c" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66IJpp3Q1687037 for ; Sat, 18 Jul 2026 22:50:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= obJQuYiFerRlAZsJd5YSFky/LorP6Nw6+tKO6ZSHaU0=; b=d+x/8SfUXQ949Mie 5p+Km5Odggi+9kR7qHfYVDZyyO4O31GXNCQLKLtqFjhBhwFyILz8gBaVX01rdHub x4Z8C7OcY0kFwpxuBMRdK6W7DcXsLBd36L+7mTSj+IC5R8JKXLTAX+TyFkeHCX1D VNkAzHpjPsDG5I2jB3y3FFKyu5Dh0k81/XJBrcyod1ShmE46yQ8KzFiIUyEsd2zF PLkyx0l7eKQPhsLBU6Von7Fj+P2y4UJV8Yg3VWtSDz/ZcGk/5h9tOmah/ZTOi7pr KG7zSblYswtXpHhjR/UDSnZBrJ7OwapZZYrdVRmlTiHgSc8rhzEG0fgEOa0iVyan F7NtOg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2c69qnk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Jul 2026 22:50:41 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-388b404eaa4so11832330a91.0 for ; Sat, 18 Jul 2026 15:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784415041; x=1785019841; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=obJQuYiFerRlAZsJd5YSFky/LorP6Nw6+tKO6ZSHaU0=; b=C6z6ZA/cr1Y6MsiHRwhWuXBC00n6WAE38BxDhpuonewP27md0VxdpDvg5sc4r6lPmG E7UxEmeeRsdxVaQKsmbcUyC384W8usHYWALuPL33DCKlX8kgip0x6uEIJc5yzOMDCF6j t2TI/95TVKmPU1MzqnbLYosOxbOK9LmqTF03dSd37g868L2sJSerzTvTyCkfHhe4tRWE Y66vmGuTwGxwc5++0unLO4w1U+H/suA5WXA6+Gav52kXAPWLuJNYjcqDvfAnBemDxUKi DEDiuX4M9hKbqha9j8JU8Ir4mgI+XJP4wdncjgewFtcLf8qsLAGUDhtLj5R9S+geBXIn 5P7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784415041; x=1785019841; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=obJQuYiFerRlAZsJd5YSFky/LorP6Nw6+tKO6ZSHaU0=; b=rLj9kovZ5Ex1S660wFtjPn+Zxz4+Bmqi7ogEP4ZYWdJIgG4teTJs05XgztBG02ldD4 TGS7durcyRSg+hRbhqiGjiI006JRJd9/uA1R4HSIz6ZdVudkMdbiQTgkln77/4+XvhRT SCTTQVArXEgDlUw/+nzL8l5FgLLL8umXsrOlzKbtavX+hrNf1eKyoFCb97DENuE5xqAJ pgXuf3dn5FtWdr5j1Hy190R45vdpofQ9Cs9wvX3NrEmh2z8wh6098P7Hn0sfMQY8SyK9 MZ6BjePcw4i3DroLHUyl05sLqj3i6N19gzpNzjb72SSZO481DSA7AGFk2Tdr1/MvJ5Ul hfhw== X-Forwarded-Encrypted: i=1; AHgh+Rrn6yhQz6bb2JnZIRdaFZCLU9himf1htsxO1FZmG02I1BftxozJN5/09o/VidKOiLS11yQNlIa7BYG4PPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/dmAZcEzfLe9Zo4r3XmJ8CDvFNUlD/+2SjDa8p14LGvDkN7wz O65BwUb4rxHVW7rJF1S1h6VtLCftV8kqtjHVPAqJ53DzYOCQ912eGIfJq0RyyQ1Xj6uwB99Y6es dlfq3JQX1Oi12dmHLzpnnfV/MJP3CIcU68r73H8kM1SseUVtDcSlCExJtrqmVcm6z52w= X-Gm-Gg: AfdE7cm0HtONarAvP1N5HhE4UeiJtVQ2yD0sbEpwE3Dbw8tOt6vVFKFp7yz8jEMnAgk dG30zpS192YNJzzn5e7vA6jbwW21X7ZF4QKAauoRl5im/tV/hfThbWdMlAn16eHY7H6q6ECyppu A02YNsC0glCGhKUWwwoIBkOHj6ZPkBnFMcE71O4YMKpylbItFHzCIzepLBa5EUFDWLQMVyrUGnH BJA/4bPmJIHJIQy0rac17rf+z0LeikBbsRz9noTxyMqxuhzP3yckWTgLkwifIYFlm270a61iO5F CLQCzHsigAcPthJUECXbTykYVsXFOW4KoBzyFkfnqUkV5uYdPcdzFdqN1MMpcIBAKuoYeNJDeIr INFtwPo6YjhAHl++8 X-Received: by 2002:a17:90b:57c5:b0:38e:2860:253f with SMTP id 98e67ed59e1d1-38e4b447cd5mr8914174a91.12.1784415040876; Sat, 18 Jul 2026 15:50:40 -0700 (PDT) X-Received: by 2002:a17:90b:57c5:b0:38e:2860:253f with SMTP id 98e67ed59e1d1-38e4b447cd5mr8914153a91.12.1784415040356; Sat, 18 Jul 2026 15:50:40 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e3a0d82d1sm5074615a91.10.2026.07.18.15.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 15:50:39 -0700 (PDT) Date: Sat, 18 Jul 2026 23:50:36 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: =?UTF-8?B?Vm9qdMSbY2ggS3LDoXRrw70=?= , nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, andy@kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: resolver: ad2s1200: use dev_err_probe() Message-ID: <20260718235036.6b71a337@jic23-huawei> In-Reply-To: References: <20260716170306.166804-1-vo.kratky@seznam.cz> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 7atcDcioM8jvvCXE0LT9FYe_5AiqUVux X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE4MDIzOSBTYWx0ZWRfX4Apk4xQNM1iE HVexJAg+cCguxOjKgq4zgua/MGDeonv1pivuHKE3YBaE+QhJTAkhBhJ1z3k6f/oSTrdvgQ5JBtY EjlFzIBGqXwptGXco1cRASElzBhnD5wxjpmHw5DfhUQCmwlkknvMWk43j44Z6Ayd7NgqpCI6Seo CtkSisXELxT/lJic0LKWrmNtjEqTESnTwse+amEpn7KJ5AB9y7dy/d1XhnJT+7nYVm5JZ+FXcNH v9w1RY4Yn79m/hwqsoz64aHnBiUwmlg+ZqZ9s2fI09FCiezNycmLPyo+7burNdAgCXNlEbxj35b gkMuY7d2Ye9AjOXj1D+VbG7u7xokEyH195jUiBo5g+24XOkknZyLePtXZzInA+2KyxZRJ3n4EpB lOfwbSQPc8A11AEupX76Txq7ZZznPpr+Rpyz+edUBJz4K1sN3Y6BeFKER/apOt7eP/fYme3g0KR LPi7UAFZUrC/2WpFkZg== X-Proofpoint-ORIG-GUID: 7atcDcioM8jvvCXE0LT9FYe_5AiqUVux X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE4MDIzOSBTYWx0ZWRfX5zRJPV6X95LM mgQ8rwW8XwUMZvAm7wa5X09NyDqERcJvmks5bheNdqwFH9WiiQpZvUm8k597XQtyaES5144Arl/ WbEg6U4hcccj8tpUvFW+3btxOYZ0w+c= X-Authority-Analysis: v=2.4 cv=CJQamxrD c=1 sm=1 tr=0 ts=6a5c0341 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=QyXUC8HyAAAA:8 a=Wm_U45AI3mUzE4zcbAQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-18_06,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607180239 On Thu, 16 Jul 2026 21:20:23 +0300 Andy Shevchenko wrote: > On Thu, Jul 16, 2026 at 07:03:06PM +0200, Vojt=C4=9Bch Kr=C3=A1tk=C3=BD w= rote: > > Use dev_err_probe() instead of dev_err() to simplify the error path > > and cleanly handle deferred probing. =20 >=20 > Wait at least 24h before sending a new version. Please, read the comments > I gave against v1. >=20 > ... >=20 > No need to send a v3, now it's a good time to read comments, discuss, take > other opinions. For example, if Jonathan is okay with v2, it maybe good to > go. I think Andy's suggestion was a good one, but given it would involve a coup= le of patches to add it and convert other places it can be used, probably foll= owed by an update of this patch, I'm going to take this now and suggest anyone w= ho is interested can revisit Andy's comments. >=20