From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F20F23392B for ; Sun, 19 Jul 2026 01:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784425928; cv=none; b=D8CIe9WcJ1F8kyc1iYCvHkZ+UzrCYEO6IpxLIJbscT+TiWQzZukWWXJk3FF2OVNAdjjxMAtjbNPnacDCz2h2tDZSBqE/BuLTsAXqHf2/YC6wqmzMmlx6zG6xtNsRjrutEXdn1TeCcnEExRi0zHxm9cy/VxWTpACApKycXjPuyCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784425928; c=relaxed/simple; bh=nQ0dx7z7VhqUX/xVZcJ7Oi8onwuylpkvTqsDeOO4N6w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a2/QADq2RkzAHoAVfu8W3yLZRaWQZVqFVUPrb4IYm/iVrD78BbYvA0BJ2tH8ApaAHVcgXlUp1P8RRAXNFsDo6z/og28BH9Ai2+ud0Ip3kK2vdgTvr6DmevKsOxQ7nmNI8hTaBdaoquEgZxUwCN7m3IU8AVlh9MRA8yeSbvwVsaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dwVJvnaJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kZBG3u1W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dwVJvnaJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kZBG3u1W" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66IN2G022050536 for ; Sun, 19 Jul 2026 01:52:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m2ykhDO9D2xyYesZwOG2ikM2DWqpI4oz9KN9zr7iQ/k=; b=dwVJvnaJi4OO7626 2dYrzPGBK7itoc6C+wAYB24hxf3vT7T6971WKpFKZJP8112gqrPxvmZp8k56qIpb ZNKURJ5uE2HdUBj6bFNnXd0vALGw3Xz+JVkVHL6236pNPhjSTBMeYusTDSZdOKVH vEgoyM+CUXT4JW/ZeyoYYOblx0YgyFsRe0dsNT/FHVHVI1vcoj2dWqxJEJa0CDev mLAPd43RANQ/LxWHFEYOBMW83q4zNG9KRCtgAkaMEZis/ujeldvcO49ljbyO6jUj WOBzaa7Q9hWnF+naUeHDQyhLi9oZvobOuhOnakzhOtj93PeU3F3K9HIrazKDY0x8 6y2lUA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2af1wbe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 19 Jul 2026 01:52:05 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c856470fe9fso4808449a12.2 for ; Sat, 18 Jul 2026 18:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784425925; x=1785030725; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=m2ykhDO9D2xyYesZwOG2ikM2DWqpI4oz9KN9zr7iQ/k=; b=kZBG3u1WEbrE9AvIPgfCoVCBTPq208bxe7EiemxsNvPwStfnwvjjAwmxihFvxaMxlx /rpH7ibM95z/c0lq7389HA2mpFehhQEkiciM3cSMalhSnZ8tcub+l3QLtd1llNgXGs/E AozTO4/n/lt4zozvm4xC3Jv99kbNk9ps1TwaZCrs0AydsvxTWeV8/6uJri4eoIfz8nrP SXYzs9w9CP4iuTEhvaXy3lMcS8+49gTbm7p8WQ5WbjlH8WQLTtdpYyB6bshIJ/VUc52M 8vK16j3zCvQB085dk2Ro4/GW2PVnHj3kt+Mw4l6A+dx1vSZwSWLgHESoBzwnGrhVVraN laZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784425925; x=1785030725; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m2ykhDO9D2xyYesZwOG2ikM2DWqpI4oz9KN9zr7iQ/k=; b=RvpHVmaYJVrrN/0+9ubon0oMrB/fOoGt3urGSTSnXs/QMgcG4/FXE+Fg3Js2BR1Rie dBLvG3UyZuyUWhDC84GzRQYGTdnfOs7XLn62ccyyIoLbmwcHtslmk1lzxLK97ubPCLbz j2BqnAXQTaXwPT02enA818wkpRLAGMKuKH0OF2LwduAwbNSnQZdfhswvChOMsB/aPs1M U8uG6KpcofNv+Y6H6pUenSKbFeO+SGSe8ts3HdsxLQGRBKO/6Hya/qroJBC09ABwcLoa rZgExBbyklV87ni3awhOr8qSv2+nZqV3vIcjacWFiQFtWrDg/sn2z53x245ud9A584HQ g28A== X-Forwarded-Encrypted: i=1; AHgh+RoE8jydSmpW/z8ZUnnkRXgZd/qSYo4GIFFsfGC8Byap53P+AXzeNBe2u+G+oIxkOdVUeELSN0W+7ibLJIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzLGjSgevtx2W8NucqBmjpUgT3/hjQtM8gWzvhAawEdGcbJdvW6 1fBrqSyeXgWEKJT3kHXZ7YeklK/3CFjwdtWx0RnkMgG3YoN5nGErhcI8XkonLvAu2/IEBb6wp+4 hpMIyK0c+A6B1LkdIinL4UXzNhK+CASXU/HcYe3lqTB/xrvAa2SqLQq/ODiBzozVb1tA= X-Gm-Gg: AfdE7cmhYQxHqfwFe7EHU0V5CQPpcUvcmCm2DClKgGmn1Dy91yOC056zz5deP/QzLbP Ma7VA7PHeJu+fGEOan2QzkVfp4LJzN2fu4VLnuD+FpxWgG8xs5MtoD+nHvaptEZc1WUJkH9qC3C JLUdCm87XfivE2HPdaOvYwU8mWNW77p5tBN6vAyCEGqZjMQ0I7YqyMfkNw9HFwKp/LcL9LuGe9n aR1665JNeVYBOzEuYryulqtozaC6OioOqeEDPUal9pDc00xkGGn6UzZK2XIIptj3Li5/A7sL4A9 v02r1if0xcgrXw1UzQfjwQIFzGT9HzQuMb8og9Q77zghvfitsjlJUuCuwM66FUukppCA0SCCnSR ZjRTI5JGXeH1n/Jc4 X-Received: by 2002:a17:90b:17cf:b0:38e:5c6:4db9 with SMTP id 98e67ed59e1d1-38e4b4113d6mr8983427a91.11.1784425924604; Sat, 18 Jul 2026 18:52:04 -0700 (PDT) X-Received: by 2002:a17:90b:17cf:b0:38e:5c6:4db9 with SMTP id 98e67ed59e1d1-38e4b4113d6mr8983409a91.11.1784425924150; Sat, 18 Jul 2026 18:52:04 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e3a119c56sm5544147a91.16.2026.07.18.18.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 18:52:03 -0700 (PDT) Date: Sun, 19 Jul 2026 02:51:58 +0100 From: Jonathan Cameron To: Esben Haabendal Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nikita Travkin , Maslov Dmitry , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] iio: light: ltr501: Power down chip if request irq fails Message-ID: <20260719025158.1e4246c6@jic23-huawei> In-Reply-To: <20260715-liteon-ltr329-v2-4-d18af55edab5@geanix.com> References: <20260715-liteon-ltr329-v2-0-d18af55edab5@geanix.com> <20260715-liteon-ltr329-v2-4-d18af55edab5@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE5MDAxNiBTYWx0ZWRfX1mtJ0Ji4eT0l PxO2YWmTvWcpj6zSuU1UIiy1I5iKiD5SjHlM326Ik8HClQDJvFnYkwHr3xIcgjuffGAZI6/9TEH qS5SAvY6RFscf0fVZynBkgVzAet532A= X-Proofpoint-GUID: o_lahbZTxvMfDZRFPZGcXx6IpkAUpDXX X-Proofpoint-ORIG-GUID: o_lahbZTxvMfDZRFPZGcXx6IpkAUpDXX X-Authority-Analysis: v=2.4 cv=a+sAM0SF c=1 sm=1 tr=0 ts=6a5c2dc5 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=ilKATfAMAAAA:8 a=K3nnHmk2jewTcsKXIS4A:9 a=CjuIK1q_8ugA:10 a=bFCP_H2QrGi7Okbo017w:22 a=73awMTU50e6eLoBjGbzZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE5MDAxNiBTYWx0ZWRfX94UA6foWQgV3 c63z3H2nft46prkJKlkeLBWn1LtCfR7f9vCIPwtWAbZlpcfsQNli8xJuK7IcQzB+qHxcC7BrhYX P5g6eOPf982Ydo1LN8JeY0HZTwPqgmC/Oh6hlgemWBXSZQVku0L/qTcU3a52Rw7bK7iZ7zFZLMb IQX4CBm3IOD5uwjoz9znp5Slvqq+JmsRS1Pac9SHVgxyzlU5zQjUjRn5oAd6qhy+RPxbkPOk5J0 B0RAzkFolrkh1uvjdjDdtLIlilHS6BO4ddce45mmC5BqIQMZfX+lJb2e/iBtA1NjUiuY1qLH4/t PwrUVo/vclCD4f9QXZSoCOEAXthX8rXwbqGtk5QZuUex3+vr7x5/nLiYSKj+z985Aj3T97RPBVR 9ZUZhE/uklumvFeVnTe0oz304cmX0Zv8L/ce82pBCUFMLHY47jSEJbpl+C6fNDIwxzYwnK5s8Ol MkALEOXEhMIx4CvovLQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-18_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607190016 On Wed, 15 Jul 2026 14:27:26 +0200 Esben Haabendal wrote: > In case request irq failed, we were leaving the chip powered instead of > powering it down again. > > Signed-off-by: Esben Haabendal > --- > drivers/iio/light/ltr501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index 379e57ac5f5b..9d4de798e5ab 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -1571,7 +1571,7 @@ static int ltr501_probe(struct i2c_client *client) > if (ret) { > dev_err(&client->dev, "request irq (%d) failed\n", > client->irq); > - return ret; > + goto powerdown_on_error; A goto after a devm call rings ordering alarm bells. The two calls will be reverse of expected order (error handling generally reverse order of setup). Instead of doing this, register an extra callback with devm_add_action_or_reset() for the power down. That will do for the fix, then if you have time convert remaining two calls to devm as well in a follow up patch. Jonathan > } > } else { > indio_dev->info = data->chip_info->info_no_irq; >