From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972512B9B7 for ; Sun, 19 Jul 2026 22:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784499440; cv=none; b=m+/MEc2W7YzkeQVrRbFBXnqKDVaXEpCNkiff6bG9ToCAGxtFfpqNiCLdthdjNwzCHVCbAhP8UXo7NveW7szs92MlnMAxL51kB7JXomdntPJXOot3SAtcO2PbZFC6Skeiw8RWftS+TosorkL2/Ef3+7c+JvhOtvORtew2EDOxY8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784499440; c=relaxed/simple; bh=WWKK2Y6/JJVXdjmuDmCoTcUjwUOPvrqBtb0/JcU1OPc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fc/ODTTfsnRCQ5YrN+KNaP8DAvgxIAj5oQrVMXjiyYnuqtgrojUBfI2lirGpfRLoaO3rMpBX+D4llfrUuRhb8TOvJkVqQYTfFnn+6LkbtM+DGsDND9XXNB7RBWNzlOyL4h0CHXb2/+pskaO44JU1a4TGAHV0FwR03VI0wS51bzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MH1KFPMy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fr0oxc16; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MH1KFPMy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fr0oxc16" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JKRDeJ4185059 for ; Sun, 19 Jul 2026 22:17:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nYxQso/u0z9R8HjD1SW36yatESiP4fHZO8aWX+nFPXw=; b=MH1KFPMyjqLBWVNw v4ZfEetkG/NMq6eREP3DreSr0zhYrrTgud/Q4TxFnY/KGHISZJG54hTf3o1Ah00l Ggn4OCbkOfmGa4/+uSuyq6peB8AXQYlcgNli/Q+tbOqJio8jC+PmqXW5sWH6/zKN WdA2tze6dlRWvI4EFskBcE6WxH1o0Kqg2zLJohqFFHhu1bwUJaFQpi+NOEXoN0Co 8W7o6+Tdhs85VCVkVurO/sm6gHvgnh4CjpaHCga2XCaI3k2pd7l51sJ7i1ptCilO qFDerXDC7f+sewBbcDn1EQXB7bQGIkhMf/Erb5H54Ogjp/Lnw/wGfadeclL5JrL5 tg19Ew== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2nhkj4m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 19 Jul 2026 22:17:17 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb5cc1e13f8so2250770a12.3 for ; Sun, 19 Jul 2026 15:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784499437; x=1785104237; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nYxQso/u0z9R8HjD1SW36yatESiP4fHZO8aWX+nFPXw=; b=fr0oxc16niLoyrCzpCqD5dCOKyzO/Bt1McxEAPGRb+G+mXQlnXVEjEdmxjlY30KS+0 BH9YV/zS0W2DoENsytupTaEbdXiInBh+Q0AVV2/1zFIa6WzK6+dbSUOe31hPS+WRQZp7 4zm+1b9KAVvhX7ti30/hPQkILb1P4wu2mzcLwoUz4THVfoNrC4GZKjKOYjmoINrOq16L shJ8XRDceCV0SpVdVKL/vL6A2GOlKMyfTllpkK5xhyCbj2RN9Yq/1uDObbqLvL7jbX8B qdlRzu4AB+ECcXvVKFE0drsquJiSKVaKCad8dNyKOQxT5pkxd9ulzCRVf0S4EokTrMzt taIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784499437; x=1785104237; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nYxQso/u0z9R8HjD1SW36yatESiP4fHZO8aWX+nFPXw=; b=GYZ/sLgBqHlgXQghXBfgF9bIFPC/vGPbiS0BcaU+tTyGNuWROWZxWtuI28z+w+HLxa L9UjUWjHCE9gQoKlyXLKQQp+AloPs8L/lE7iJES6Nxwe9lpfxCXpvEi7dAvvZiIwPyFB Z4KjqiXH+cIIE0KKPkIaMW5LtfzWBNFMgKImj06xh3me09DBIvypQCs9OIZwf6LkaKqG 8FUF+V8mfEmC9r0l+g0FUw6IVECuMBPMohDtgg7tiUbpfqiHXD/Vdhc5XgusHckcwdAh n2IM+A4W58gb1mQRrXcOUEqNjIx1nqMkQLOpVOjIeEB/T40tVMgosrkVhZaOHPQb8eHs nENg== X-Forwarded-Encrypted: i=1; AHgh+RpLpPVgqpNQHryUENDVUDo40PdJT577Ry29sfL29CnzWMaU1ipVmtOCpgBe4P7e8QHbjBkNdjTVRZmJseo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3W1/xdC49ywFQQcdEfPHnL++ikTGxIe+FSBIAqbb4p69hcu7n xqeA29jufgLbTYP/j4vjfrtiYl8ZcHQE3JK210Z+E3JTtNehJd9hVRO52KsXcz+00qcbhADw/C9 xIvMxh5S1hzj1zl9KEAWnkGW0vEjyl3l7XFCBlRWdIRiNoT3xgPvWcxEQ1HL0rcCQzLI= X-Gm-Gg: AfdE7cmKd6XrvWrgK1zIA5Z4fq1b2/BwjkrexQfpbpgvrZoqa3DRxHhuRdKlwDKbBil zwaKvHoRDhX+0sk21LuGPOX6VEgPzUtTIJAci9KyhNUSOAbNKsAzRT6czSW+zW05YMAXIUs5PgC rWiHuQlL/z4qcyH1zUmJuo9hn5OgeCCREVZHaOQP4LikcoIxHn8AlF+ITZRQfwL1MCO2NV64Al1 R9AtJpmDRQs4OTH9lZ4izJxn6ABy+FeMemaOliffzQB2lr9e19Oxmbr07GokkrP6N1Y/xK1QU0a 0ubNehhqWnk/4hto0+9PrAjCJ2DaCTTdjoLRidZBzJngd1elPBfTuHZbz4DpTAGbxtsm23/Y9Wn lJMfVOPoN8GIjpHyQ X-Received: by 2002:a05:6a21:4591:b0:3b4:7eb0:47a1 with SMTP id adf61e73a8af0-3c3ad62ac62mr12187789637.19.1784499437238; Sun, 19 Jul 2026 15:17:17 -0700 (PDT) X-Received: by 2002:a05:6a21:4591:b0:3b4:7eb0:47a1 with SMTP id adf61e73a8af0-3c3ad62ac62mr12187755637.19.1784499436736; Sun, 19 Jul 2026 15:17:16 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519aeb676sm3625211a12.19.2026.07.19.15.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 15:17:15 -0700 (PDT) Date: Sun, 19 Jul 2026 23:17:10 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" , sashiko-bot@kernel.org Subject: Re: [PATCH v8 2/8] iio: dac: ad5686: missing NULL check on match data Message-ID: <20260719231710.14a669ad@jic23-huawei> In-Reply-To: References: <20260716-ad5686-new-features-v8-0-ebb0051af5e5@analog.com> <20260716-ad5686-new-features-v8-2-ebb0051af5e5@analog.com> <20260719005533.41520a27@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Le0MLDfi c=1 sm=1 tr=0 ts=6a5d4ced cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=QyXUC8HyAAAA:8 a=MxYe75D9c33W5Oe7pOYA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: 55YT8aCefOm6OSjyI1nsvwt5SDXXEEMS X-Proofpoint-ORIG-GUID: 55YT8aCefOm6OSjyI1nsvwt5SDXXEEMS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE5MDI1MCBTYWx0ZWRfX/t0crGz26lzD iFby+dLLa4n0mrUrhM0Pnnb454m76O0CFHsrZ+ewhjj3boqaAV0ZoAxD2U8l0M58bZ1k0znx1wM thWzN/WZTnfBZ8zdpYs/E5Qz8zFCkCnICAwlC6TN06ZUfFSlCRoTljbzw7nrEcKwO0305uft5/F E6WWGSXdGoq8RXnQmbZX8OC5RHR41tI0VvcXQz0H9HBIvDFtQ1yBE1lfDEWGd36oQDJ1xStn06+ jRY2/6BWp9jygtYvC2EuDkVVRp3s/5w69+47gwbZibUam4T8HG9xYRwZyIy34ll6rbvrN2o0Oak lj5+kgshxGZVGbf1tKTQ0AXamQfmLx1fBcYyLtSeZNdQ/I90Gukd8BUySm1fAOJWTz7pU35UJUa XXgR1dWWtNuGJY+hzold9JKSPj0xTZjevVz14orU8KTBMGgqsrwYzjyL2t40dlvlVxqE5cGThnj gUF2Fm8I52IUyT+v31A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE5MDI1MCBTYWx0ZWRfX1JdezVD0FNlF zN85G2zJKfX/OEeGegP5w5FV7V1RYVkBC3PZ6h3ffa4cJTMJKjFBYhaFLDDRkmx9ervTgKaTbr4 5Ik+2lod5Z73tc19kWfSTHvtcU/mByk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607190250 On Sun, 19 Jul 2026 11:50:56 +0300 Andy Shevchenko wrote: > On Sun, Jul 19, 2026 at 12:55:44AM +0100, Jonathan Cameron wrote: > > On Fri, 17 Jul 2026 13:28:52 +0300 > > Andy Shevchenko wrote: > > ... > > > I applied the following rather than going for a v9 for just this: > > Thanks! > > > Shout if I messed it up. > > ... > > > + if (!chip_info) > > + return -ENODEV; > > Perhaps stick with -ENODATA? (Maybe in a separate change, dunno...) > oops. I lost track on where we were with that. Updated.