From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EE523A542B for ; Mon, 20 Jul 2026 06:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784527935; cv=none; b=aQioGcAWox+hYHjhuRxYkYaW7Ix7QXqDm6xz5GAI++lsfET4Nyb9LYkpytehS9v/Ds89OQgYhg6xHNmaaHC237Er9MEXUOS7LWoOjWzR9+ul0330RBl8xylgl8YsNpW7rdt5w7fiag606xwVKs2eoB9EptVaMKVcdipoeOFA9+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784527935; c=relaxed/simple; bh=5rx35bWSep3xN4RUyD5mNpeVVVjnUrXou8AE1KSwoCE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YFkru89L+0isnOFvV2vN4p4AX/PXkJfovRqBoZfTtOvN4T10RLJn+sh66It7yKjNHIrhepaCrBDHJQnjecNTKN99ur7a180VbFsCqxoEsdRTJke+n526F6cC3N4KVWO5rFCgR9Vz/lSr1fkdy+SapL+P1MA9060arz6RN9B5PiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AcE2U1Yl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ExJoaQCi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AcE2U1Yl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ExJoaQCi" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNsEuu1019437 for ; Mon, 20 Jul 2026 06:12:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s8YKg6IaKC7m0qneFSX4THum9YhnLsBA1sZ5MrH5/YI=; b=AcE2U1Yl6RWq5HE+ OA3auvOJAR12m2YxiGcGzeHD7HZh4oeUTPJ8cXHS0bVNuAdNqWm6VVwUrlR5DOrX kJsISXg+VrpySxShB1exTvk/zG9yD1HsjAWU4abFu3avN7L7nYyV2+V/rPY7coA4 zaqSGv4H0ztrsYDSRdwVy6F25zH2iRgflEGzK2bnAt4wUUaKnDr34PaIvcF9YdXo rGfqcHppUt0HSwYv6mvrjFSzKzu2ldfzPg+nzJMLt+h2Tgd1GP17OXsfozq82SoZ nQwd3tzsVMNv2UwoUbGzq6+vJkCj8hWbe4FqaLPggKsFGipxdWSj/4yEsGY0EbQ3 2L/Gkw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2d94mvy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 06:12:00 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8f1e4e0eac1so166071216d6.1 for ; Sun, 19 Jul 2026 23:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784527920; x=1785132720; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s8YKg6IaKC7m0qneFSX4THum9YhnLsBA1sZ5MrH5/YI=; b=ExJoaQCikwX/QOQLn6Gdd6Xqi7TEPRgFdwWl+s2F0syogJ90NSCBi+ARyciGtT8lHI BoOP6RTLLEh0rQrHTtlgh5vCA1C31e/cEPvFb/MB64MB/5vYKqRamxsNd77IdcljsRA7 ZaWzaHaE3cU2OjGLrsGd+QNALaOdJ5k73B9NutNbItQbGeAHyFU0Ayj+Zgb+thJ3fWZr MXGm/mM0XYX8BcAzsE1lQaS3Gl8iUrxA0K2MVXylB+nX7bpQ7BEiTr/vqts3ixvEkL9G eWpZd4qY5Zw3QsViVtBY1cQsgFRQyKwXdp2EZgx+SKCEg0PF8BroQLGNgA9JfsipyPug X0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784527920; x=1785132720; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s8YKg6IaKC7m0qneFSX4THum9YhnLsBA1sZ5MrH5/YI=; b=SmlfdaYFb8ht2YEKs4Q13Ovzq/VZpsEVUdGxs1yt2DW52+ZC9T4rDptTIiWv5UKQFG u/VqZVclL60hHk8QxBP58MbopRM3LVWGSl8taGh2bF5Pm5xpbWtzjWMykTDkp0gqRYp8 KUs1snJoQ/Xg9Cex4aZ7h2PsVPOapV+AAHlbId2uUAEfvBLl436iVaYxYWaOZCB0WdIP yHRzQA13UpUfsvalpcpJFc8ZrFtsR8AYtqiOEZGBS5L5ApogE7vxiDEva4oTebMuQ1Rx GFA+xHzFuPLtlCHmXVeCzEvaU/3ph6su4PpeDlfeAgxUwqobdifJ22QjAiaMTg+tJowt XB4g== X-Forwarded-Encrypted: i=1; AHgh+RoK8OZ1/oQpv03jhYwU5b+IOUgXMj5upoj1upL2o76cn2f2dJDvbZMzpCaU4O844l/2ROxW4izV67d3liY=@vger.kernel.org X-Gm-Message-State: AOJu0YxsoMoYtMaBheHg77ajz47++59/BmioL0Qw3+3JBSxDK/jYYUCl FsSwD9SF3dji+Q6NP1cLQ9s3qj2a+rlPIVFqXokkEnikE775z4oaNN0b9r5tawnWlJLG3VqELW7 Cd4UGYs/o/+imIuZTJwnKZyLTYfwM0WjQ/HnhON59KxIbY6aD5ZSyZga9YyiUb/StRRY= X-Gm-Gg: AfdE7cm/zaIDbffPMV4fnskm6a0g9vyF9KcbRK8k/wUG5L4B/mKHAf16CjK5yr4gq8b 5MptkkgNwhy3FkrtakjrBTjiFrXQObb0Y0oG7QrYAg4CznyP1oomNsHiCjOQEp/ifRLSlgjbrzX jnNW1lm/7kwHRTiRbjQiJexTD7ESvWrLlU60QexShmZ5+dE4UwPLQhlpxCIbx4P0NTAmtJv63i4 GltUywR0GRi+PD+h8KS4y7oUBzlBXSul69KJp/yIqKkF5GrybiiY07GCyjop8cztIuGY5dl0W8o 0b2LfIodQve4ZUvEmcRsdULUkHBr98W75lfQRG14ylmjk/myqCYHzhloeLjxPiFJRDTnAH8OeuV jGJBZQCN+lR9VBoc1RydZg+VtlUqv6ryoEf5hykONvx4HQvvu8wmvBZijExE5AZk= X-Received: by 2002:a05:6214:c87:b0:8ee:efa3:4466 with SMTP id 6a1803df08f44-907783761bamr126610526d6.28.1784527919811; Sun, 19 Jul 2026 23:11:59 -0700 (PDT) X-Received: by 2002:a05:6214:c87:b0:8ee:efa3:4466 with SMTP id 6a1803df08f44-907783761bamr126610376d6.28.1784527919447; Sun, 19 Jul 2026 23:11:59 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90778588a39sm84793216d6.20.2026.07.19.23.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 23:11:59 -0700 (PDT) From: Yongxing Mou Date: Mon, 20 Jul 2026 14:08:22 +0800 Subject: [PATCH v8 15/15] drm/msm/dp: pass panel to display enable/disable helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-dp_mstclean-v8-15-bea261bf4e7d@oss.qualcomm.com> References: <20260720-dp_mstclean-v8-0-bea261bf4e7d@oss.qualcomm.com> In-Reply-To: <20260720-dp_mstclean-v8-0-bea261bf4e7d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784527840; l=3650; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=5rx35bWSep3xN4RUyD5mNpeVVVjnUrXou8AE1KSwoCE=; b=9efT/qG81EEi+uKNli7LulrsXg3ziNpwjh3xhB+lKuMhE88HpsM9E2ogd6lKku6bcEOAuDMmN JoGJ0qHa069B9hoplrk7MPRQCRJ27x7b94BUElUR1otrMC4OpZZKFm/ X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=HpxG3UTS c=1 sm=1 tr=0 ts=6a5dbc30 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=7Bdkmk_NF71dONvui9QA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: dTYNRgXW_sMlAJeYFhiINlTGArFY1mwo X-Proofpoint-ORIG-GUID: dTYNRgXW_sMlAJeYFhiINlTGArFY1mwo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDA2NyBTYWx0ZWRfX5rabrQVZqr/+ YoEKxiAru2l77YMUnr1F73/aNRjJ3//dlHVm15x8EQUAxObFVwGI/nmaqlD1YIcUMrMwJCmGhu/ Xn9/wEXBTansASEhtUB1efGkToWpE3awVazrMx/T8M3UrhWeTdKo373TOaIlLVMX9InuaWj3X2B oqOKjDyNgOv1o/T7gN/6x8VNSNJhIlM+UK42vB9Tez4Wyuv59sVqkCR7nBt/Dq+7O2dN0E8mYnr kQ2DnLzW0mshFcZiDxVAMjn71OEHZUd/MXo20yi43+FHzWscV8WZulMJj616/P+GaUR1f3gJ9Yy eGxdiM7BZkcAbK0bhQgx/Gx2NrBGyS2c8MyWUiZ/1JKeapsEWS59h2sZ0hFB/K0TgUjzYSUKeN6 Nwknt4Rre/WzUeKX5R2diMk/CcHYY8cMvCy6OtGg5hAc6rxmHXKWRrXHgEfMxia6J7ZRoOoguo5 gW/4B1MT5bdArzqaT0A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDA2NyBTYWx0ZWRfX5G7ygSLRvKtt BB2An4P1sgKNmdz8IhioLymri4S7tkJGTfpUzVxBt36aj39TRxdFTj2mbeapVou6gDEWPRa7yM/ AolHsYxgjj6Bq6IMC36YMl2WzURMdyM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200067 Pass struct msm_dp_panel to the display enable/disable helpers to make them easier to reuse for MST stream handling. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 74d885e38b8c..c31d155715a1 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -652,7 +652,8 @@ static int msm_dp_display_prepare_link(struct msm_dp_display_private *dp) return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, force_link_train); } -static int msm_dp_display_enable(struct msm_dp_display_private *dp) +static int msm_dp_display_enable(struct msm_dp_display_private *dp, + struct msm_dp_panel *msm_dp_panel) { int rc = 0; struct msm_dp *msm_dp_display = &dp->msm_dp_display; @@ -663,7 +664,7 @@ static int msm_dp_display_enable(struct msm_dp_display_private *dp) return 0; } - rc = msm_dp_ctrl_on_stream(dp->ctrl, dp->panel); + rc = msm_dp_ctrl_on_stream(dp->ctrl, msm_dp_panel); if (!rc) msm_dp_display->power_on = true; @@ -709,22 +710,23 @@ static void msm_dp_display_audio_notify_disable(struct msm_dp_display_private *d msm_dp_display->audio_enabled = false; } -static int msm_dp_display_disable(struct msm_dp_display_private *dp) +static int msm_dp_display_disable(struct msm_dp_display_private *dp, + struct msm_dp_panel *msm_dp_panel) { struct msm_dp *msm_dp_display = &dp->msm_dp_display; if (!msm_dp_display->power_on) return 0; - msm_dp_panel_disable_vsc_sdp(dp->panel); + msm_dp_panel_disable_vsc_sdp(msm_dp_panel); msm_dp_ctrl_off_pixel_clk(dp->ctrl); /* dongle is still connected but sinks are disconnected */ if (dp->link->sink_count == 0) - msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); + msm_dp_link_psm_config(dp->link, &msm_dp_panel->link_info, true); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + msm_dp_ctrl_off_link(dp->ctrl, msm_dp_panel); if (dp->link->sink_count == 0) /* re-init the PHY so that we can listen to Dongle disconnect */ @@ -739,7 +741,7 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) } /** - * msm_dp_bridge_mode_valid - callback to determine if specified mode is valid + * msm_dp_display_mode_valid - callback to determine if specified mode is valid * @dp: Pointer to dp display structure * @info: display info * @mode: Pointer to drm mode structure @@ -1439,14 +1441,14 @@ void msm_dp_display_atomic_enable(struct msm_dp *msm_dp_display) dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - rc = msm_dp_display_enable(dp); + rc = msm_dp_display_enable(dp, dp->panel); if (rc) DRM_ERROR("DP display enable failed, rc=%d\n", rc); rc = msm_dp_display_post_enable(msm_dp_display); if (rc) { DRM_ERROR("DP display post enable failed, rc=%d\n", rc); - msm_dp_display_disable(dp); + msm_dp_display_disable(dp, dp->panel); } drm_dbg_dp(msm_dp_display->drm_dev, "type=%d Done\n", msm_dp_display->connector_type); @@ -1481,7 +1483,7 @@ void msm_dp_display_atomic_post_disable(struct msm_dp *dp) msm_dp_display_audio_notify_disable(msm_dp_display); - msm_dp_display_disable(msm_dp_display); + msm_dp_display_disable(msm_dp_display, msm_dp_display->panel); msm_dp_display_unprepare(msm_dp_display); } -- 2.43.0