From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DDC31531E8 for ; Mon, 20 Jul 2026 06:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784527885; cv=none; b=Gc5B/xncJXUTrHQJQJzX7m40rLCpsXY+0yWo6VHC9p9YRiw17gpWwwfMY8YC9g8REFMdMs8HXKwis5FXjqBgFWHszK6mjEvv3mnx4z1n1juiZXqHgGRYGuqrESKk22Ft1IfhIEpKlRTDqqR5FbKdycpsxW/ZtlU1n9HyE625OAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784527885; c=relaxed/simple; bh=m7a3fzYm8nfwxq2seY3v0u+Fo5r/mlnnqjBe8DmQUGM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PVOOEKjMb19fvdsoFWADD4HPMO45fBzKsskU5N+xaBU9YbI4gbJLcIN12ghqwPR3VZYMVxeqckXrOwVvNwOrL/Q0xMtiSxFMk7XDp+izbEwRWLfLrdkKpGXCTYELU5PZmjASrILmHnKTF1AwwOwDnY4RievmI45AnBKU/ZS/lyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hxzOkCCv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BdVPn9wt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hxzOkCCv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BdVPn9wt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNtJuh566306 for ; Mon, 20 Jul 2026 06:11:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AeQrXGNfB+XoNNbsXI6SD4zb0QBkoDAOP9R0ui3Y6iw=; b=hxzOkCCvUH8nJgan mDLIODhEqR4RNCAFqHPk0Ldo0jDF2fJ16AcLVAb6MwN4kLXZTR538QfS0w87RNK9 oQjrh4MYPtJqGPnpi2naYpQyzQl1+ejj9LPbJZBTmhT2/cJISXHRDzew6RWQf1kx h1xt6BUvZKrXAiiLfF4ki5L9VFNqh9s9ZN+MQEr4vbn6UxrGnLFKn/yIHmBlUyV3 Mut5sRajfqQJWAKxw6lklIcx/XixJ+UcO4KZ4RCc5Tk5L0RNAYq59oTTA8Pg37uC ycoHvczWGcu4V4DkpztqP25ObDuJrh9hRQXtbsXj/x1+J3kjFbWteD3dXN8I44Vg XsEv9A== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2s7vk58-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 06:11:15 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8f0c46bfb6dso249780006d6.1 for ; Sun, 19 Jul 2026 23:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784527875; x=1785132675; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AeQrXGNfB+XoNNbsXI6SD4zb0QBkoDAOP9R0ui3Y6iw=; b=BdVPn9wt4Umin3OkAdq7TaUn6D+ldMCPM+7RiRzNvi7/EDl8yD9fUPV1dAoqQb5jwu zxL/7Sq0cd0M6p7++JMs88oaDU44Qq3B/d7JrELAfRhzRO3aAgwP4TL/oRR0FcXSxHLK V6MHBTcxDFkmHkmkVm02IsBkm082AeiyYnw6HxEOrpm4yTPxKgfscZgs5bMPJneYNbdT T/QnX349x7Qn5ZZystdy+tDbUJq52xsDmVBeSwx4GiNt3ZVr99UJTRzuqBh5Y1t4e1sa lQdV7MbUAYkpq0F2MEvjqmwDwa1TXxDQ2kCrnll3QzV5pOtddlJ8pa+6Qolb9v/czRUK XHnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784527875; x=1785132675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AeQrXGNfB+XoNNbsXI6SD4zb0QBkoDAOP9R0ui3Y6iw=; b=hklTLE1DBJfypbIWxEXSLlPJYxBroHR3pKJxYnh8MQ1XFC7/PQt5DThho33nMLB3bJ Ux04AwzmfvNgFEhSGXrhCq48apVMvExAzF0pf4Y3z/lFERRu07dyyWxHMFbNN88EVDec sruCGu7RSTWopXfmuITXqju7EJ+PqMMn+Wu3XqVDTKWumJgQb+lNvul/DmZ7PTJvD3gk iX256cz0vm33BU7bzAePgIB23pd/1s3Sry+8yXcJPNWXLS4sGl5w1qqA+FISg+hnV3Ps Vzwaaqxm8uvu0l3STWmXYYobocLpbbwWliRFNTmoHkwoVNMaDHBcjXH/kY1SKoJ7BpLe tCMw== X-Forwarded-Encrypted: i=1; AHgh+RpTzqt7IBG/YA3kEhMO6pniQGG/Dt/1LnWEIl4qxiosB8t0zsqQRSBryDfCnMP0W1BCF+K/m1nNpByMDA4=@vger.kernel.org X-Gm-Message-State: AOJu0YykQjQCzPVgS4NYSi2YjY5h/1sVrTYDsmFUzoCIQOzjpqoLkiQ8 Kfbs7NLkRDrnw0xJd3GpH9Vh7cXDFfetPHhtYQ/VvV6u4XgtmaLx5Z7p3pWsFhmDMP9rFXBu1NY MiD0NAZB0e1HfkB6GxxbwhT3PgQEZaFoKTDwEyLyBGGOljxHxXOX21+crPJ7/WYpxxO0= X-Gm-Gg: AfdE7cmjlbl9tp3JZR8BAx9Yr6wniLzWpcAzpe7pnMeK7+KX+SgN6TgKNIVxnOPurXx VPWKikv8os2fZM+sbeCFtvmyWS1xgxrdf50qnzaxeua5ElMbmi+XDUQFkk/OF8gBdVcClsN7Fnb El1U7astSemnEp99UosAQxJUW2LzETSAJNydAJD4MRmwlH/rY94/7bU4KFg9Unply3tHdZmL793 /D9qNlpRSshmSymaHiIOPLIpJaJgnvHOVb/5Sz2IQt9Mh13Ti2pTP4oNBqT/aJ21vSTetFmLSCi 6dML2T2FWT8c2+uYZI7/XYGgOEMM/XUDdfUiIobP4ehlqjxt59/wmGjaZUYA/IgpE0ZCPedrUTy jlkOYzNm2KWHCRBBZhkeAE5CiRzlJGB9BotWPsrfn1p2bqMosTUjXgVWWN/8Etww= X-Received: by 2002:a05:6214:500f:b0:8fd:6e32:2bff with SMTP id 6a1803df08f44-90778509f1dmr133304566d6.64.1784527874703; Sun, 19 Jul 2026 23:11:14 -0700 (PDT) X-Received: by 2002:a05:6214:500f:b0:8fd:6e32:2bff with SMTP id 6a1803df08f44-90778509f1dmr133304326d6.64.1784527874341; Sun, 19 Jul 2026 23:11:14 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90778588a39sm84793216d6.20.2026.07.19.23.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 23:11:14 -0700 (PDT) From: Yongxing Mou Date: Mon, 20 Jul 2026 14:08:13 +0800 Subject: [PATCH v8 06/15] drm/msm/dp: split link setup from source params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-dp_mstclean-v8-6-bea261bf4e7d@oss.qualcomm.com> References: <20260720-dp_mstclean-v8-0-bea261bf4e7d@oss.qualcomm.com> In-Reply-To: <20260720-dp_mstclean-v8-0-bea261bf4e7d@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784527840; l=1402; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=m7a3fzYm8nfwxq2seY3v0u+Fo5r/mlnnqjBe8DmQUGM=; b=chonLmhqOwTIGtD1JV5pLq0RH7vxKrwc6AaLVvZN9VAm0hBQzkHmET72yQfwCT/8o1QrgVGOW KA495hrb99MDlXUktgehooV/JA99dRBLpSk0Yl8rCaSBTzna5tPBaQc X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDA2NiBTYWx0ZWRfXw0eLfulSQiNb v+xnW+K8k3xLMBjBiHQ7izLSImDyRuoLU4Xqz2M4JuQ2BKlkpTPHq62HfqjKHLL22O25CyFMvrs qPYF0GGnlxI3hko6glb74EKIpqK321kwzFnHiqgGWq22b8Cnez/TYnUtiFkbz9Pcj+yDawoZ6b0 raVcpKhuTvIehzLqagurAU0IhuLd89RFdenFjLsMLqr9K2fdgWxPbwNiCHjQCoQUdZMG2YWrszQ mT1K8aRaBs12FfSXJ0Sk7bX6Ypum8v4iEVuv6OgHC2KgUzrBpwaNEK9zJk3ObV5LXXfRFJ15XMG FCv/jmiNZEjspYH5SeEe+ld+iozy3s8WmZ/wKs7A7fFc1tZFCG9zRhh92BoFW3HdwcTrFIweu6C 1yvMKe4v+Qb7EAd5ZcF/rWyAkKoic6+mg170BcuKCd6mnslFMrpsDRHv4L6bshTeMtECWj7bMbz nNnrv9arQdmudOkbbqQ== X-Authority-Analysis: v=2.4 cv=eKsjSnp1 c=1 sm=1 tr=0 ts=6a5dbc03 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=saXSvH3Ee-fMY4W8qR0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: qESAm83B9q5EtC9Ca7vuXD4qkcj60O0b X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDA2NiBTYWx0ZWRfX3sYu4nw3z9q1 56NMpYxyeEIS052xqh5X+c3rf5v4GRz7aFptPyEJvs+RIfLGcRbsKFFE59xecOlO4xAiBvvvnfH ziJmv94rYPvGFIdDn+itffKD1Pclx5E= X-Proofpoint-GUID: qESAm83B9q5EtC9Ca7vuXD4qkcj60O0b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200066 msm_dp_ctrl_configure_source_params() should only handle stream-related configuration. Move the link setup out of it so MST can program link and stream settings separately. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index ac24c958852b..711579de899d 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -482,10 +482,6 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) { - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); @@ -2552,6 +2548,10 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train */ reinit_completion(&ctrl->video_comp); + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_configure_source_params(ctrl); msm_dp_ctrl_config_msa(ctrl, -- 2.43.0