From: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>,
Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Subject: [PATCH 2/3] drm/msm/mdss: Enable INT2_GDSC alongside CORE_GDSC
Date: Mon, 20 Jul 2026 16:43:54 +0800 [thread overview]
Message-ID: <20260720-msm_gdsc2-v1-2-4687866d6cb0@oss.qualcomm.com> (raw)
In-Reply-To: <20260720-msm_gdsc2-v1-0-4687866d6cb0@oss.qualcomm.com>
Kaanapali (SM8750) and Glymur use two display power domains.
CORE_GDSC powers the main display hardware while INT2_GDSC powers
a subset of SSPP blocks (VIG2/VIG3/DMA5/DMA6).
The MDSS driver currently relies on the default runtime PM handling
and does not enable the secondary INT2_GDSC. As a result, display
pipes backed by INT2_GDSC remain inaccessible.
Attach and manage both power domains explicitly and enable them
during MDSS runtime PM activation.
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
---
drivers/gpu/drm/msm/msm_mdss.c | 53 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 9087c4b290db..63ece55c4f2e 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -13,6 +13,7 @@
#include <linux/irqchip/chained_irq.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
+#include <linux/pm_domain.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
@@ -44,6 +45,7 @@ struct msm_mdss {
struct icc_path *mdp_path[2];
u32 num_mdp_paths;
struct icc_path *reg_bus_path;
+ struct dev_pm_domain_list *pd_list;
};
static int msm_mdss_parse_data_bus_icc_path(struct device *dev,
@@ -233,6 +235,21 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss)
int ret, i;
u32 hw_rev;
+ /*
+ * Platforms with two power domains (e.g. Kaanapali, Glymur) need both
+ * GDSCs enabled explicitly; the core framework only auto-attaches a
+ * single power domain.
+ */
+ if (msm_mdss->pd_list) {
+ ret = pm_runtime_resume_and_get(msm_mdss->pd_list->pd_devs[0]);
+ if (ret < 0)
+ return ret;
+
+ ret = pm_runtime_resume_and_get(msm_mdss->pd_list->pd_devs[1]);
+ if (ret < 0)
+ goto err_put_core;
+ }
+
/*
* Several components have AXI clocks that can only be turned on if
* the interconnect is enabled (non-zero bandwidth). Let's make sure
@@ -255,7 +272,7 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss)
ret = clk_bulk_prepare_enable(msm_mdss->num_clocks, msm_mdss->clocks);
if (ret) {
dev_err(msm_mdss->dev, "clock enable failed, ret:%d\n", ret);
- return ret;
+ goto err_put_int2;
}
/*
@@ -276,6 +293,14 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss)
/* else UBWC 1.0 or none, no params to program */
return ret;
+
+err_put_int2:
+ if (msm_mdss->pd_list)
+ pm_runtime_put_sync(msm_mdss->pd_list->pd_devs[1]);
+err_put_core:
+ if (msm_mdss->pd_list)
+ pm_runtime_put_sync(msm_mdss->pd_list->pd_devs[0]);
+ return ret;
}
static int msm_mdss_disable(struct msm_mdss *msm_mdss)
@@ -290,6 +315,11 @@ static int msm_mdss_disable(struct msm_mdss *msm_mdss)
if (msm_mdss->reg_bus_path)
icc_set_bw(msm_mdss->reg_bus_path, 0, 0);
+ if (msm_mdss->pd_list) {
+ pm_runtime_put_sync(msm_mdss->pd_list->pd_devs[1]);
+ pm_runtime_put_sync(msm_mdss->pd_list->pd_devs[0]);
+ }
+
return 0;
}
@@ -421,6 +451,27 @@ static struct msm_mdss *msm_mdss_init(struct platform_device *pdev, bool is_mdp5
irq_set_chained_handler_and_data(irq, msm_mdss_irq,
msm_mdss);
+ /*
+ * When two power domains are listed in DT, the core framework does not
+ * auto-attach either of them. Attach and manage both explicitly so
+ * that INT2_GDSC (needed for VIG2/VIG3) is enabled alongside the main
+ * CORE_GDSC. Single-domain platforms are unaffected.
+ */
+ if (of_count_phandle_with_args(pdev->dev.of_node, "power-domains",
+ "#power-domain-cells") > 1) {
+ static const char * const mdss_pd_names[] = { "core", "int2" };
+ static const struct dev_pm_domain_attach_data pd_data = {
+ .pd_names = mdss_pd_names,
+ .num_pd_names = ARRAY_SIZE(mdss_pd_names),
+ .pd_flags = PD_FLAG_NO_DEV_LINK,
+ };
+
+ ret = devm_pm_domain_attach_list(&pdev->dev, &pd_data,
+ &msm_mdss->pd_list);
+ if (ret < 0)
+ return ERR_PTR(ret);
+ }
+
pm_runtime_enable(&pdev->dev);
return msm_mdss;
--
2.43.0
next prev parent reply other threads:[~2026-07-20 8:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 8:43 [PATCH 0/3] drm/msm: Enable dual MDSS power domains Yongxing Mou
2026-07-20 8:43 ` [PATCH 1/3] dt-bindings: display: msm: Allow two " Yongxing Mou
2026-07-20 8:49 ` Konrad Dybcio
2026-08-13 7:44 ` Yongxing Mou
2026-08-17 14:12 ` Konrad Dybcio
2026-08-18 3:32 ` Dmitry Baryshkov
2026-08-17 14:13 ` Konrad Dybcio
2026-08-17 14:14 ` Konrad Dybcio
2026-08-19 3:27 ` Yongxing Mou
2026-08-25 6:28 ` Yongxing Mou
2026-08-25 8:30 ` Konrad Dybcio
2026-08-26 2:53 ` Yongxing Mou
2026-08-26 13:19 ` Konrad Dybcio
2026-08-19 3:23 ` Yongxing Mou
2026-08-18 3:31 ` Dmitry Baryshkov
2026-08-19 5:50 ` Yongxing Mou
2026-07-21 18:18 ` Dmitry Baryshkov
2026-08-13 7:45 ` Yongxing Mou
2026-07-21 18:20 ` Dmitry Baryshkov
2026-08-13 8:06 ` Yongxing Mou
2026-07-24 9:36 ` Krzysztof Kozlowski
2026-08-13 7:45 ` Yongxing Mou
2026-08-18 3:29 ` Dmitry Baryshkov
2026-07-20 8:43 ` Yongxing Mou [this message]
2026-07-21 18:40 ` [PATCH 2/3] drm/msm/mdss: Enable INT2_GDSC alongside CORE_GDSC Dmitry Baryshkov
2026-08-13 7:45 ` Yongxing Mou
2026-07-20 8:43 ` [PATCH 3/3] arm64: dts: qcom: Add INT2_GDSC to MDSS on Kaanapali and Glymur Yongxing Mou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720-msm_gdsc2-v1-2-4687866d6cb0@oss.qualcomm.com \
--to=yongxing.mou@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_mkrishn@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®