From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4B6432BD8 for ; Mon, 20 Jul 2026 14:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784559220; cv=none; b=S0Ge0I0fXm+fbI64DllqUNLz923OGjM0floJgUkVlc/75+hAz9Ru+S5ThLH0n2a5dZY1T71GeOG9aU/4zHj6rk3gF5N7ba2w90gNrai9kNiWOLqA8wDbz/rxw9j3UyotVCWbE8aLkVNDbePvuMQmKsWqJdExMsgkqvz2Ex+H8/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784559220; c=relaxed/simple; bh=0fg/0n8jqlk1rTqLof5aMrLhYmwz4Lkt27r4G+FR9W8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JyIQiuyoFb5efuuEBSVSWLPyF65HFM9yXR1aLs7AaPV0njWvTRkH5zlI9WrTapGecRndFKVF3FeN5dDls9ApVIvtzrG8w2K7rUkD1n6fBBenwp5KD/Ahr65+sR1RO4kLAyYZQuJ/+Cz2HpZsOJJSQgIYmjHisWpvLu4J3wbYq7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GSCuJsAV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JIPVw22r; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GSCuJsAV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JIPVw22r" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDrMk72841191 for ; Mon, 20 Jul 2026 14:53:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0C9IgCI2fyKGPwADUG81tMOL7Xd+RLAneLurfpmZbVM=; b=GSCuJsAVYE1K8vDn OVNGFExSsfoLCrFtgzJFwhMMtO6HkPpbSJu1PoiI+pDpyAyFCakj+X4esPeSB0uZ L/UKIB4GrJiwZrFmSpv6+WPxp2AwGE6vvKHI+7xowzNP7nSnZPP+Dq6sgvDHiSOz gOFaaNKFRw/KBqO/xwEC6C/05pggELsSB6IXh4WUT03NnS9CyIOuww6729SXe3HL GL3y6e8ynO3JKpa+ca0FTAG7+tRp1P5UB4gFMUc0A6X3b/3GFdrP+FIq4lvXVqcM YguHeeLu1GMhfP57sRDzGudRrf+CDYJISz3xSRzaQZ4Wwl130LGL4oiZOQeqbNlM Q54hkA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfvxhsms-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:53:36 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1c7f135bso142102331cf.0 for ; Mon, 20 Jul 2026 07:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784559216; x=1785164016; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0C9IgCI2fyKGPwADUG81tMOL7Xd+RLAneLurfpmZbVM=; b=JIPVw22r8JSuq43WIrveNv+PHhQi2MQ3HPSrEgGhX7tLhjCQrSjszKCW1Sgo0sJoB/ 4Z+akTMRHSYyt0QnKYoHTBprAVgBMDSkEpN6xT0nzGEaStf1fllv013lnLxhXkHEsO9L 4fjrzxpGLxTQZMCQmhfSYUkphMJx0GKFjnSaO6+dOKjEJLbapjlWI8IsfeRn1CAHpvzM O4JcYlEGzx9eqqLsB9TdRC2ULp8Wl7+Eh5QHuG29KXNIYQQk4xR413kDNcqeiZSKBdr2 buU7M5Sh8ScXxxcQ6wBZBhpA0IL6pKIasBa+36LEhGi8kP3iGZYePfbw7TRfUzP/FrL5 bhpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784559216; x=1785164016; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0C9IgCI2fyKGPwADUG81tMOL7Xd+RLAneLurfpmZbVM=; b=Owu5DHRFlXJbY/fPDBVjIFK/25vUsP8wQn9ABNJer0E8o1RpjfDz4zWY3B5Qv0W90Q X0e1BgGRiqZBZNn/C8piA7d17fVUHbTHuh5uBrbsVvQWkVerB8qQOF/h39S3b1ANo9DG j9wEV/sezZAnol10zD7Z+4x3cLroO1z+UwoBDja/3fUotl5lrX09HdDerg9uRb2Tq7b5 QDHmygW702Kruacgz7gQ4qfqzjL5PYGiuGPvaiVc6iJmhW/P+FjHtVamwmsSpqQ7LOc9 KXvfEVCvu8KS2n3clzeXZfyqC9LMoe/o4gA8Ms4yfIDEW+ko347Q75x/6a4AJJT/BI57 4hcg== X-Forwarded-Encrypted: i=1; AHgh+Ro33tR+/yqUqoTE3sarsPUnhUsdjQc2kx5IjkTwLKwNxzqnU2dVhoxRSD6JymDkmWB/6zyyoNwSEbsRhY8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUPuquxow3fY1HXYUl3ipk99fQEq3X9D8zDpoJTofdqkneNkJj ggcbVcVpG7p/qYtOuTZzc5woxXMux5xQU3aferEgfpvF86eyw+N3kvPOq98QoLwtpM2tqJyG++/ ZuSeElALDOz5i/AdbFAJDF2oSaxND7VfSKkR0jgIJNHSuUqQyPPukUQ1loDSx+gbKOXo= X-Gm-Gg: AfdE7cnS0bjF8YWlBs5H2g0mRqacqwkxJuJLTjpupgcXaXf6S1prL58eK0e82FauiMX 98QGXFJMWtixdntBNC/CQa+VQD3XVBs5u3057wbwNcMLl4MEfyUQFV48TSVbf29JUEQY58LIip3 E9Nbhwo8rjOuHe5aKc1SWIPl4SzatEHRTqtZGeqjghe6cuyfN0xXWFK7XRpRfR6mAJdJAKRdxxM LuBHpq3uEHDkKF22CVL3XLBb9k48QYLpXAxpJibA3KWc7h/cyctAWKtMErOu7M/yFQHqYxASID+ gT4eI+b2YxSaTUFfNAaGiNwA7mXGK5b83KaHJQD5OCCUToGkmBt+17q0OjR19/cPmZF2MRq6lyj CTsAxNHliFwv3rN607YCpFb+3uyVCOiU4BqZX/BqRvAgC5+cLRSg5fyGEJkwPwPax97l3xTV7A7 XfZ0024JcwCW/6CjPEUIt8npSnUITdiOBXzYrA9ti9H58u0fnoj5w= X-Received: by 2002:a05:622a:4110:b0:51a:8b64:69e0 with SMTP id d75a77b69052e-5213d2b7109mr134941901cf.11.1784559215693; Mon, 20 Jul 2026 07:53:35 -0700 (PDT) X-Received: by 2002:a05:622a:4110:b0:51a:8b64:69e0 with SMTP id d75a77b69052e-5213d2b7109mr134941511cf.11.1784559215166; Mon, 20 Jul 2026 07:53:35 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:751c:d61c:c91:60dd]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69e7000c3e2sm4800215a12.30.2026.07.20.07.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:53:33 -0700 (PDT) From: Loic Poulain Date: Mon, 20 Jul 2026 16:53:30 +0200 Subject: [PATCH v4 1/4] phy: qcom: qmp-combo: Prevent unnecessary PM runtime suspend at boot Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-qcom-usb-phy-fix-null-v4-1-4d2a0f06d53a@oss.qualcomm.com> References: <20260720-qcom-usb-phy-fix-null-v4-0-4d2a0f06d53a@oss.qualcomm.com> In-Reply-To: <20260720-qcom-usb-phy-fix-null-v4-0-4d2a0f06d53a@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Dmitry Baryshkov , Wesley Cheng Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Abel Vesa , Konrad Dybcio , Loic Poulain X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=HKLz0Itv c=1 sm=1 tr=0 ts=6a5e3670 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=PcYcMbZi39MCwOMHHM8A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2NSBTYWx0ZWRfX5iT9uHI0Dfgv OkVVu73PL5xWa7ziCOb6oKNKWy1gL7tBYT+wd7lfOXUqMhitkNKWNddll7EjaoDDg5Ywzav+E83 L98t1qlCw2k2q1YTJbTQjFKqT09flJ0= X-Proofpoint-GUID: qJYK86CRp6q874uQmMSDiHu7reGd04Dj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2NSBTYWx0ZWRfXzksoEpGkPnY/ 76StYtrj8FKmC+9J2FVHCYFtCnKz/vJ0lPRxfusK9+Gd/97zG5TKt6xM+ng0v3s6jSYvS1vObTn ARvJY9FQtpxM7wFiUYacuXgXIw+iDEsia54laOBa8yf81vikzU6VJpB8bXGX75VN8vLNGcPmH2e beC/m5ss4Fo+fw79OamV15zrkNYq5c47jz1eMII07rHP1VVSR4CHcQn9dxFCbbjfz0BMF+IbFMV udOUnVzyzCKEI9gVJgi1XGWK7VyMxG8KJh9LNt59Mp1d3nGjf3DGvdz39PBWrDS3EvxJDlVvXPt pNGxBgE31ccfUMUUag5YIRQgRYXJV1pk2Wyps/+aF5xYRPiVmZo3soy3O52Cz4gqMbSwc0g0IqS pAXHADbIyTZaDGALg5Y+Lv80C9tXUqkPp81zjDztQKQGNmRQ0UjnD+CUDxmzzFVEaSj1WGjgP/t kVSBk6n0vPBdyYZAT3w== X-Proofpoint-ORIG-GUID: qJYK86CRp6q874uQmMSDiHu7reGd04Dj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200165 Runtime PM has to be enabled before creating the PHYs, since phy_create() only enables runtime PM on the PHY devices if it is already enabled on this parent device. This opens a small window where the device can be runtime suspended after pm_runtime_enable() and before the later pm_runtime_forbid(), causing an unnecessary suspend/resume cycle while the PHYs are not yet registered. Take a runtime PM usage reference with pm_runtime_get_noresume() before enabling runtime PM and release it once the PHYs have been created to prevent the device from being runtime suspended during that window. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio Signed-off-by: Loic Poulain --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index cdcfad2e86b1d37650c4d7b0433319837ee9c9d4..affc8e040bb968a5b9d0b6f6fc2694c471368729 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -4934,10 +4934,16 @@ static int qmp_combo_probe(struct platform_device *pdev) if (ret) goto err_node_put; + /* + * Enable runtime PM before creating the PHYs, phy_create() only enables + * it on the PHY devices if already enabled on the parent. Hold a usage + * reference so callbacks cannot run until the PHY is ready. + */ + pm_runtime_get_noresume(dev); pm_runtime_set_active(dev); ret = devm_pm_runtime_enable(dev); if (ret) - goto err_node_put; + goto err_pm_put; /* * Prevent runtime pm from being ON by default. Users can enable * it using power/control in sysfs. @@ -4946,14 +4952,13 @@ static int qmp_combo_probe(struct platform_device *pdev) ret = qmp_combo_register_clocks(qmp, usb_np, dp_np); if (ret) - goto err_node_put; - + goto err_pm_put; qmp->usb_phy = devm_phy_create(dev, usb_np, &qmp_combo_usb_phy_ops); if (IS_ERR(qmp->usb_phy)) { ret = PTR_ERR(qmp->usb_phy); dev_err(dev, "failed to create USB PHY: %d\n", ret); - goto err_node_put; + goto err_pm_put; } phy_set_drvdata(qmp->usb_phy, qmp); @@ -4962,11 +4967,13 @@ static int qmp_combo_probe(struct platform_device *pdev) if (IS_ERR(qmp->dp_phy)) { ret = PTR_ERR(qmp->dp_phy); dev_err(dev, "failed to create DP PHY: %d\n", ret); - goto err_node_put; + goto err_pm_put; } phy_set_drvdata(qmp->dp_phy, qmp); + pm_runtime_put(dev); + if (usb_np == dev->of_node) phy_provider = devm_of_phy_provider_register(dev, qmp_combo_phy_xlate); else @@ -4977,6 +4984,8 @@ static int qmp_combo_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); +err_pm_put: + pm_runtime_put_noidle(dev); err_node_put: of_node_put(usb_np); of_node_put(dp_np); -- 2.34.1