From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D8E3FFFB8 for ; Tue, 21 Jul 2026 02:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784601203; cv=none; b=CuHwOMcwA48Hs+/0iosvY30CyfjrKPy8ZrkJyoaVQRGBmwTSYj24P37x59ez8eIE4G73NPy9WR/vJY5eKA+aqX4lfdE3G9VnySRfFmt1sOyCNhVSrlHxu9mim6wL8romUfJg7Tk6LTA4+t1nacz3Ch1igfr2E1UPsP3IYKM0Pl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784601203; c=relaxed/simple; bh=51n49MP98ZOaaSWmGsFPZOcNFmgPzKd2Atz2Upix5g0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CgAM1jQdI8jTff1aF3P4618oiOzegoDExRSZfmjkY1C8ArV59JTSpO2yFGu1UwcjhhEx/27xP0d2Ht7MlPBt9wnhZNOoyBkB7V5mFm7aybo/BlgCxDgulMhN7h5FutI208tFvIlVPiBHE8UAJ7GuEmJvBFlVhfvLQejcCerp6n4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UgTzkTOK; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UgTzkTOK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784601202; x=1816137202; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=51n49MP98ZOaaSWmGsFPZOcNFmgPzKd2Atz2Upix5g0=; b=UgTzkTOKfxGDzy1V5Cf9C/2xtGy4nXz+5SZ7qHvkDYQMkdBmjJYdMVMl xO1SDPd1GtVTazQ2vxCm+Ki9ep1zja+fJ/whaQJsIf8/nnnctMJC/iewL 8uvMTY0ehRY2GW7Is1pkCryxfPQG9DH904FpFL4J+I2L4xF816chJJqcS cqJMo1/R1ILe4b1wijoz0pUHGELJGNTJkwHrH8nLWCkmMyMQMu8usugL/ oKugG8mjJACJ4dlXQV10neUKB7uOfxSE4Vkbp9TwYga610+3NS9LBJNNd hilqIar207u+WSPNnIBYHiD9EuUaF+C0frdWAcRK+o7XwIXnE12iORqEF g==; X-CSE-ConnectionGUID: 9MNbMmy3Stm+9U8JfJU96Q== X-CSE-MsgGUID: KCDHhiA5SRO8WmSztuEu+A== X-IronPort-AV: E=McAfee;i="6800,10657,11852"; a="95785695" X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="95785695" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 19:33:18 -0700 X-CSE-ConnectionGUID: RN4qq8A1Qa6PcF/6IkjYGQ== X-CSE-MsgGUID: ShJANbSNRd+fuZLNCsyGnw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,175,1779174000"; d="scan'208";a="257682260" Received: from unknown (HELO [172.25.112.21]) ([172.25.112.21]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2026 19:33:18 -0700 From: Ricardo Neri Date: Mon, 20 Jul 2026 19:43:18 -0700 Subject: [PATCH v6 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-rneri-fix-cas-clusters-v6-2-bb500bf4afd4@linux.intel.com> References: <20260720-rneri-fix-cas-clusters-v6-0-bb500bf4afd4@linux.intel.com> In-Reply-To: <20260720-rneri-fix-cas-clusters-v6-0-bb500bf4afd4@linux.intel.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tim C Chen , Chen Yu , Christian Loehle , K Prateek Nayak , Andrea Righi , Barry Song Cc: "Rafael J. Wysocki" , Len Brown , ricardo.neri@intel.com, linux-kernel@vger.kernel.org, Ricardo Neri X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784601848; l=1742; i=ricardo.neri-calderon@linux.intel.com; s=20250602; h=from:subject:message-id; bh=51n49MP98ZOaaSWmGsFPZOcNFmgPzKd2Atz2Upix5g0=; b=ciY1hIrcx02oE6WWUbhc+/Ggp4k6wQzgIfb96jMHg5LMfA1pOFb8fsde7AHDaf9hC184ONdgD uk5UDoQW7CiBJMTVb993mfRORVrl8CB7WgS71+aa9M5SFLUtjo7pmy7 X-Developer-Key: i=ricardo.neri-calderon@linux.intel.com; a=ed25519; pk=NfZw5SyQ2lxVfmNMaMR6KUj3+0OhcwDPyRzFDH9gY2w= The argument sg_overloaded of update_sg_lb_stats() is only consumed when balancing at the root domain. It only makes sense to update it in such a case. Commit 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") updated the logic accordingly but missed the case in which the root domain has the SD_ASYM_CPUCAPACITY flag. Fix this. Fixes: 3229adbe7875 ("sched/fair: Do not compute overloaded status unnecessarily during lb") Reported-by: Chen Yu Tested-by: Christian Loehle Reviewed-by: Vincent Guittot Tested-by: Andrea Righi Signed-off-by: Ricardo Neri --- Changes in v6: * Added Reviewed-by tag from Vincent. Thanks! * Added Tested-by tag from Andrea. Thanks! Changes in v5: * Added Tested-by tag from Christian. Thanks! Changes in v4: * Introduced this patch. Changes in v3: * N/A Changes in v2: * N/A --- kernel/sched/fair.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 15a0e1ce90b7..4e82bc9963e6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11975,7 +11975,9 @@ static inline void update_sg_lb_stats(struct lb_env *env, /* Check for a misfit task on the cpu */ if (sgs->group_misfit_task_load < rq->misfit_task_load) { sgs->group_misfit_task_load = rq->misfit_task_load; - *sg_overloaded = 1; + + if (balancing_at_rd) + *sg_overloaded = 1; } } else if (env->idle && sched_reduced_capacity(rq, env->sd)) { /* Check for a task running on a CPU with reduced capacity */ -- 2.43.0