From: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com,
tony.truong@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com,
Chunkai Deng <chunkai.deng@oss.qualcomm.com>,
stable@vger.kernel.org
Subject: [PATCH v3 0/2] rpmsg: glink: smem: robustness and debuggability fixes
Date: Mon, 20 Jul 2026 21:25:51 +0800 [thread overview]
Message-ID: <20260720-rpmsg-improvements-v3-0-e7b6070186bd@oss.qualcomm.com> (raw)
This series makes two small improvements to the SMEM GLINK transport:
1. Validate the raw FIFO head/tail indices (and caller-supplied
offset/count) against the FIFO length in the read/write helpers,
so a broken index is rejected before it turns into an
out-of-bounds access into the FIFO.
2. Pass dev_name(&smem->dev) as the IRQ name instead of the static
string "glink-smem". On platforms with multiple remoteprocs each
SMEM GLINK instance registers its own IRQ, and the unique device
name makes each entry in /proc/interrupts identifiable without
adding a new struct field.
Signed-off-by: Chunkai Deng <chunkai.deng@oss.qualcomm.com>
---
Changes in v3:
- Rework the FIFO-index patch per review: validate the raw head/tail
values (not a derived length or post-normalized index), use
dev_warn_ratelimited() for remote-written indices and WARN_ON_ONCE()
for local ones, and bounds-check offset/count and hlen/dlen.
Retitled to "rpmsg: glink: smem: Validate FIFO indices before use".
- No changes to the IRQ-name patch; carrying Dmitry's Reviewed-by.
- Link to v2: https://patch.msgid.link/20260617-rpmsg-improvements-v2-0-477d4eb569dc@oss.qualcomm.com
Changes in v2:
- Drop the modulo patch ("rpmsg: glink: smem: Use modulo for FIFO
tail wrap-around in rx_advance"); per review, it papers over an
unreachable scenario without restoring a valid protocol state.
Proper RX-side validation of chunk_size against rx_pipe->length
will be sent as a separate patch.
- "rpmsg: glink: smem: Add WARN_ON_ONCE for FIFO index invariants":
- Drop the trailing comma after "skipped" in the commit message
body (per review).
- Add Fixes: caf989c350e8 ("rpmsg: glink: Introduce glink smem
based transport") and Cc: stable@vger.kernel.org (per review).
- Carry Dmitry's Reviewed-by on "rpmsg: glink: smem: Use device
name as IRQ name" (no code changes since v1).
- Link to v1: https://patch.msgid.link/20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com
---
Chunkai Deng (2):
rpmsg: glink: smem: Use device name as IRQ name
rpmsg: glink: smem: Validate FIFO indices before use
drivers/rpmsg/qcom_glink_smem.c | 41 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 40 insertions(+), 1 deletion(-)
---
base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
change-id: 20260601-rpmsg-improvements-643a6e133f66
Best regards,
--
Chunkai Deng <chunkai.deng@oss.qualcomm.com>
next reply other threads:[~2026-07-20 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:25 Chunkai Deng [this message]
2026-07-20 13:25 ` [PATCH v3 1/2] rpmsg: glink: smem: Use device name as IRQ name Chunkai Deng
2026-07-20 14:00 ` Konrad Dybcio
2026-07-20 13:25 ` [PATCH v3 2/2] rpmsg: glink: smem: Validate FIFO indices before use Chunkai Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720-rpmsg-improvements-v3-0-e7b6070186bd@oss.qualcomm.com \
--to=chunkai.deng@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=chris.lew@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tony.truong@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®