From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E05370D7B for ; Sun, 19 Jul 2026 23:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784503109; cv=none; b=CqQX/UNZ1HUBhCZvYES3mwdeSiOFAL/CB4zs1nR+ETMZ1kJ/pA+HWAGPYRdpWDlhla5hood8dzTE5BRunqnBiwjLIRb2+N5hNpwfPnsPqjTMAx1kBUtjyut/TkG/kK5R2F99zyEazrNlOBmD6D5JWY1I8NYNR7kinus0IaoCGps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784503109; c=relaxed/simple; bh=jlZxa9vZboy0BksuXXTUMp6z/9XDE8IsRqB0EXK49kY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IOc0uTs1A+yLQWj7stgwBJY8grv0pjPW0GkagllKxGripzFkxwujWKOStc8qKNLJGQ9E62/qFkT9VODjTcIZISprO8Jyjgw+IUiRk7FTek1cND0ooZnMvX/PaTSDtV2jmpMbNdhKRPyi7nwjnM0CXmJ3QBFsoeSvKfiCCHg3J9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KgolratY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P7tKP5RO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KgolratY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P7tKP5RO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JKQtrx422178 for ; Sun, 19 Jul 2026 23:18:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QgeRlMIF4PNYTV0QauQI/hB2VqHL/8Zkn/RtkXBaTMg=; b=KgolratYUAK77z96 n5xkG1LD+sx9M/Zvq/tQ/vBSEdK7DouV3O5Qdx9p/TcYcbCL3XkOkjXhX2Zi5bdk sBtTC/EqpBPF52YXaGfGxV/fRFDWeZsVltexUcszFKATp1HGJ7Hrhgo/glXU+pwh eChgy41J/GwxawyCXyHUaMREE5TDx70XxPMwDrWH7g66qg3GxrCwi6gLOP6QLNrq D1A2KkqcdOhZ5np75TokYY1gM+p0x2qWP8agpIxwoR4PJoa9i0PzeEFXnyPGf2Od F7dSpujuPsiRUHL5s/WeOhpzpy5JwGfolXYx2o9TNb3Iq40OkSPwjGb4w+24bWCT m98Zkg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2dc3p9c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 19 Jul 2026 23:18:27 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8423f1fe39eso11879385b3a.1 for ; Sun, 19 Jul 2026 16:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784503106; x=1785107906; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QgeRlMIF4PNYTV0QauQI/hB2VqHL/8Zkn/RtkXBaTMg=; b=P7tKP5ROBzVk0lcdHTo9OjK/yAF0IppABWuGLLw7uDvBctUqHVzfRcwaxiwFYq8zlU YMg6L4ER/5dDQ7O5ZYFGshOCvpO81/7D54O5RrjN66jBpUqTsfpx8Qk9GD/qqi5n8Deg B/yoYIxu8sfYPgyN3+7EHxbaSeFNQHBD/5DR15GNGNdL2AlOaaRogE/y8Ku21Kp87NHG h338hOjXKmT8qiC+dshqMG6dhjIh8LgB6p8sxoyP3jts72CgtjsP2JHsVqariLFS2WVK tJG9gEessXopenAFjcy01hbCxDue3Con2lvjHprxNpnN0OUTOaMnMu+ozzlUbORxNT9z AGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784503106; x=1785107906; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QgeRlMIF4PNYTV0QauQI/hB2VqHL/8Zkn/RtkXBaTMg=; b=qWBA70LkIckh5kj3pJaB0ErUDJ2QDr1i+8L4TUADG11zHURr4WiO/gq8pP763FIaHP VmgQ1zQgmldFB5H8mCSPfp8xVOpduoACYO6TY+y/JGFzDHpkVCl8YSt1vdxlkcMbHVdY abXnzZ8eXblPSfEmhKilNbaBEx+rhCW16CyGIFKpRnz/MAXU6FWNFwOtzxya+NTXppTD eCzaPtslKG6SRve6qgR/O7Ou+eYnAUy/YUrqpDrRpIoif9wF6UiKNZcH8Epg1KtVH0Qn 4wlT5d4cpOqRQsIP1edB0HsYzgnDdMaqFZHaU0cL0ga+GXkTsH6Q+vP5SVRs/inA7HYS U2fg== X-Forwarded-Encrypted: i=1; AHgh+RoFR9mPaAN0HYtwOQO04bQkEkUp81Ikc7Lq3Uf0Y+y8DrlhzMDO34ibgzG7NxbvdCqhpucav1AgVJjYSuY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9F3TidTB/TlomAmC+jdWoFkJRXeCfg2tmIQBVBx+WiuDfkQlZ sa0MgDs/I6ywazn1RYKRyXdVCkiIgtLYQF+ARtS8/Rfspjx3EIkyETQKYdV7CBRrKjUuNQeAqoP iK/Q2V4qDs9yB40DodO0IssGWwhQEMZe/HJuFOViwr0JK1fvD200K79szKSout6pFu2Q= X-Gm-Gg: AfdE7cnj6IdfjfsAl1ni6IPJojUZ0epW2uvCCWnWKadbJZAxfkbog917isiygBOKCNa fpGa5avGLyWly0GcPC6KLgTim8kIXy2chcmwe72rdQd8fcyDxZk9hZCFga4SWwlashwmHWSHkqk 2YpDbo3jM6cptzAhE4da72G8VanLdYQWO6iPQeXRDaGWh7hm1vymPRbOKKP5NBdTR5NURdjDi4/ Dr/VRoTkZEp/waJ54qioNQVwk2WuhNC4GMXxD+tkFOVkeF+qmLicELGFHRcleTef8nKxS77eYfG OvFMeGq385JHUgRh0Jx5xWtJQA+7U3kgSDZgQsYpbkX+DB3kro5fH9pchXs9jgZJoA1gMP7t+Ai x3GejNbEd8WqQIbD3 X-Received: by 2002:a05:6a00:228b:b0:848:4424:2b8e with SMTP id d2e1a72fcca58-84c29272e4amr12634561b3a.3.1784503106320; Sun, 19 Jul 2026 16:18:26 -0700 (PDT) X-Received: by 2002:a05:6a00:228b:b0:848:4424:2b8e with SMTP id d2e1a72fcca58-84c29272e4amr12634541b3a.3.1784503105842; Sun, 19 Jul 2026 16:18:25 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cb519ae8684sm3634095a12.17.2026.07.19.16.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 16:18:25 -0700 (PDT) Date: Mon, 20 Jul 2026 00:18:20 +0100 From: Jonathan Cameron To: "David Lechner (TI)" Cc: Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Hall , Patrick Edwards , Kurt Borja , Nguyen Minh Tien , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 8/8] iio: adc: ti-ads112c14: add measurement channel support Message-ID: <20260720001808.63d576af@jic23-huawei> In-Reply-To: <20260714-iio-adc-ti-ads122c14-v4-8-25f8e3084485@baylibre.com> References: <20260714-iio-adc-ti-ads122c14-v4-0-25f8e3084485@baylibre.com> <20260714-iio-adc-ti-ads122c14-v4-8-25f8e3084485@baylibre.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE5MDI2MSBTYWx0ZWRfX0SHIPv8kRAfk 3vAHKUQnNfGydoJaq9BIVzQSJCTRSVFmmTMPnZEQXXTBfUdJNdl/0FpkuqJhYK7yjfIWndMx0nw PPvPk3Y+lw6Qe4DnLMWwdxZfam2hB6c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE5MDI2MSBTYWx0ZWRfX+kC2uRi0t5ZZ oyhMVWHjiJV72BhDCV4q7mRxBn8SovhsSuGlCng/TMn7t9wEwezNqjHjtrb0iPLdXNiqjcjPIt8 kbOcR14o5mxv+Si4qAsGzcjajJ6IPGVTLZzzDc1bO343BEwi2ct5OkI40TjtF8bUWWsE6nO9W7U DsmXsRTfo+etaMXEIFY+Gw1Fdyf5gtHgKGqy5mi6624sPuPTt9Da/wJ5GH9K7MGxmRdlR7GNGjY wm3OgSmKY8b43GIiLQNuzDmu4ZpdcE5O7GnmqnRtkvawgwnO5H5WLpx4MkpeTcsz8FDdvFIlcZF +YfONlV1oCRi5Fth/y3FTlA8NR7782uvd84MqmJmpw9XrwGOOeZx5AFHQFAm7lbYkvAY9ucwEvt LlsmOa22IS2BF9eVRGYShY98BLa0yA1F0X7xx2VGLuvwuu6CB+qfcpEhRTF13ckO1nN0s7Wy1Cu 3Gplw375ZY7Lb4XoTAA== X-Proofpoint-ORIG-GUID: r3LoyDrN0sJnZCHguJ_lY2bIh5UkTZMY X-Proofpoint-GUID: r3LoyDrN0sJnZCHguJ_lY2bIh5UkTZMY X-Authority-Analysis: v=2.4 cv=FOQrAeos c=1 sm=1 tr=0 ts=6a5d5b43 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=c92rfblmAAAA:8 a=IpJZQVW2AAAA:8 a=KzLlk2TKFSg7Zc6CKOQA:9 a=CjuIK1q_8ugA:10 a=ZXulRonScM0A:10 a=OpyuDcXvxspvyRM73sMx:22 a=GvGzcOZaWPEFPQC_NcjD:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607190261 On Tue, 14 Jul 2026 18:21:30 -0500 "David Lechner (TI)" wrote: > Add support for parsing devicetree properties for measurement channels > and doing direct reads on these. > > There are quite a lot of conditions that have to be met for each > measurement to be made, so quite a bit of state and algorithms are > required to handle it. > > Channels are created dynamically since the number of possibilities is > unreasonably large. > > Signed-off-by: David Lechner (TI) Huh. Sashiko had a field day on this one. Other than the earlier mentioned 'maybe' case of the i2c_smbus stuff returning short, I'm not seeing any of the ones I looked at being true. I particular enjoyed the hold statement that something didn't fit in a 3 bit field. True, but the field is 4 bits and there it does fit. https://sashiko.dev/#/patchset/20260714-iio-adc-ti-ads122c14-v4-0-25f8e3084485%40baylibre.com To me this all looks good. Thanks Jonathan