From: Nikhil Gurudasani <nikhilgurudasani314@gmail.com>
To: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mchehab@kernel.org,
hverkuil+cisco@kernel.org, crope@iki.fi,
u.kleine-koenig@baylibre.com, kees@kernel.org
Subject: [PATCH 1/2] media: dvb-frontends: a8293: validate platform data
Date: Mon, 20 Jul 2026 06:37:44 +0530 [thread overview]
Message-ID: <20260720010745.11275-1-nikhilgurudasani314@gmail.com> (raw)
a8293_probe() dereferences platform data before checking it. An I2C
device instantiated without the expected platform data therefore causes
a NULL pointer dereference during probe.
Reject devices that do not provide both the platform data and DVB
frontend.
Fixes: b561baec11a4 ("[media] a8293: implement I2C client bindings")
Signed-off-by: Nikhil Gurudasani <nikhilgurudasani314@gmail.com>
---
drivers/media/dvb-frontends/a8293.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/a8293.c b/drivers/media/dvb-frontends/a8293.c
index 52e3dc928327..14e7f6bda10c 100644
--- a/drivers/media/dvb-frontends/a8293.c
+++ b/drivers/media/dvb-frontends/a8293.c
@@ -213,11 +213,16 @@ static int a8293_set_voltage(struct dvb_frontend *fe,
static int a8293_probe(struct i2c_client *client)
{
struct a8293_dev *dev;
- struct a8293_platform_data *pdata = client->dev.platform_data;
- struct dvb_frontend *fe = pdata->dvb_frontend;
+ struct a8293_platform_data *pdata = dev_get_platdata(&client->dev);
+ struct dvb_frontend *fe;
int ret;
u8 buf[2];
+ if (!pdata || !pdata->dvb_frontend)
+ return -EINVAL;
+
+ fe = pdata->dvb_frontend;
+
dev = kzalloc_obj(*dev);
if (!dev) {
ret = -ENOMEM;
base-commit: a52e6f7923c17a672135b485ffd96fbd72f46267
--
2.43.0
next reply other threads:[~2026-07-20 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 1:07 Nikhil Gurudasani [this message]
2026-07-20 1:07 ` [PATCH 2/2] media: dvb-frontends: a8293: reject short probe reads Nikhil Gurudasani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720010745.11275-1-nikhilgurudasani314@gmail.com \
--to=nikhilgurudasani314@gmail.com \
--cc=crope@iki.fi \
--cc=hverkuil+cisco@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®