From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: "David Lechner (TI)" <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Nguyen Minh Tien" <zizuzacker@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: ti-ads112c14: add debugfs register access
Date: Mon, 20 Jul 2026 01:24:46 +0100 [thread overview]
Message-ID: <20260720012446.27f0411b@jic23-huawei> (raw)
In-Reply-To: <20260714-iio-adc-ti-ads112c14-buffered-read-v1-1-fe6e1c971288@baylibre.com>
On Tue, 14 Jul 2026 19:19:30 -0500
"David Lechner (TI)" <dlechner@baylibre.com> wrote:
> Add debugfs register access to the ads112c14 driver. This is a complex
> chip and being able to poke registers is useful for debugging and
> diagnostic/calibration purposes.
>
> Signed-off-by: David Lechner (TI) <dlechner@baylibre.com>
Given this one is trivial, applied.
Jonathan
> ---
> drivers/iio/adc/ti-ads112c14.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/iio/adc/ti-ads112c14.c b/drivers/iio/adc/ti-ads112c14.c
> index fef3a9c37ced..28824c81908e 100644
> --- a/drivers/iio/adc/ti-ads112c14.c
> +++ b/drivers/iio/adc/ti-ads112c14.c
> @@ -690,6 +690,19 @@ static int ads112c14_write_raw_get_fmt(struct iio_dev *indio_dev,
> }
> }
>
> +static int ads112c14_debugfs_reg_access(struct iio_dev *indio_dev,
> + unsigned int reg,
> + unsigned int writeval,
> + unsigned int *readval)
> +{
> + struct ads112c14_data *data = iio_priv(indio_dev);
> +
> + if (readval)
> + return regmap_read(data->regmap, reg, readval);
> +
> + return regmap_write(data->regmap, reg, writeval);
> +}
> +
> static int ads112c14_read_label(struct iio_dev *indio_dev,
> struct iio_chan_spec const *chan, char *label)
> {
> @@ -736,6 +749,7 @@ static const struct iio_info ads112c14_info = {
> .read_avail = ads112c14_read_avail,
> .write_raw = ads112c14_write_raw,
> .write_raw_get_fmt = ads112c14_write_raw_get_fmt,
> + .debugfs_reg_access = ads112c14_debugfs_reg_access,
> .read_label = ads112c14_read_label,
> };
>
>
next prev parent reply other threads:[~2026-07-20 0:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 0:19 [PATCH 0/3] iio: adc: ti-ads112c14: buffered read support David Lechner (TI)
2026-07-15 0:19 ` [PATCH 1/3] iio: adc: ti-ads112c14: add debugfs register access David Lechner (TI)
2026-07-20 0:24 ` Jonathan Cameron [this message]
2026-07-22 22:52 ` David Lechner
2026-07-23 23:18 ` Jonathan Cameron
2026-07-15 0:19 ` [PATCH 2/3] iio: adc: ti-ads112c14: add support for I2C CRC8 David Lechner (TI)
2026-07-20 0:35 ` Jonathan Cameron
2026-07-15 0:19 ` [PATCH 3/3] iio: adc: ti-ads112c14: add support for buffered read David Lechner (TI)
2026-07-20 0:55 ` Jonathan Cameron
2026-07-21 23:23 ` David Lechner
2026-07-23 23:25 ` Jonathan Cameron
2026-07-24 14:47 ` David Lechner
2026-07-24 21:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720012446.27f0411b@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®