mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: longlong yan <yanlonglong@kylinos.cn>
To: skhan@linuxfoundation.org
Cc: jkacur@redhat.com, jwyatt@redhat.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	sageofredondo@gmail.com, shuah@kernel.org, trenn@suse.com,
	yanlonglong@kylinos.cn
Subject: [PATCH v3] cpupower/debug/i386: check mmap return value in main
Date: Mon, 20 Jul 2026 09:34:37 +0800	[thread overview]
Message-ID: <20260720013437.428-1-yanlonglong@kylinos.cn> (raw)
In-Reply-To: <7f6a28eb-ea4d-4c9e-9aed-ed184b5d22e4@linuxfoundation.org>

The return value of mmap() is not checked. On failure mmap() returns
MAP_FAILED, not NULL. If mmap() fails, the subsequent for-loop
dereferences the invalid pointer (MAP_FAILED), causing a segfault.

Add a check for MAP_FAILED after mmap(), consistent with the existing
error handling style for open() in the same function.

Fixes: 7fe2f6399a84 ("cpupowerutils - cpufrequtils extended with quite some features")
Signed-off-by: longlong yan <yanlonglong@kylinos.cn>

Changes in v2:
- Remove trailing whitespace and blank row

Changes in v3:
- Format Adjustment
---
 tools/power/cpupower/debug/i386/dump_psb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/power/cpupower/debug/i386/dump_psb.c b/tools/power/cpupower/debug/i386/dump_psb.c
index 6fb81b42ea61..fcbb73b48acb 100644
--- a/tools/power/cpupower/debug/i386/dump_psb.c
+++ b/tools/power/cpupower/debug/i386/dump_psb.c
@@ -182,6 +182,11 @@ main(int argc, char *argv[])
 	mem = mmap(mem, 0x100000 - 0xc0000, PROT_READ, MAP_SHARED, fd, 0xc0000);
 	close(fd);
 
+	if (mem == MAP_FAILED) {
+		printf("Couldn't mmap /dev/mem\n");
+		exit(1);
+	}
+
 	for (p = mem; p - mem < LEN; p+=16) {
 		if (memcmp(p, "AMDK7PNOW!", 10) == 0) {
 			decode_psb(p, numpst);
-- 
2.43.0


  reply	other threads:[~2026-07-20  1:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  3:11 [PATCH] " longlong yan
2026-07-16 23:26 ` Shuah
2026-07-17  1:31   ` [PATCH v2] " longlong yan
2026-07-17 20:01     ` Shuah Khan
2026-07-20  1:34       ` longlong yan [this message]
2026-07-20 23:16         ` [PATCH v3] " Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720013437.428-1-yanlonglong@kylinos.cn \
    --to=yanlonglong@kylinos.cn \
    --cc=jkacur@redhat.com \
    --cc=jwyatt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sageofredondo@gmail.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®