From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B642222D0 for ; Mon, 20 Jul 2026 01:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784511450; cv=none; b=f8WEbEHxXCnhFRfm8JPoe3L3nZBExpo3xuNVnjoKOrSMuhVyeQ2Q9PzHzQZa4vlWjL3P/Q72rzF48T1YcmUsGMHbrDlFK+gwezjDVw7v2rfhPOitVhtpPzxUZaG9iarZ1oam3qCqT59/dWuQ+acDIk/FYS2gTktzgVi9A5fN4AI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784511450; c=relaxed/simple; bh=jT2MzAmCzn9SGfCL9Em1UkvNQY0fr8z8N8BHnBa+Rcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IK+uCRjt+tb+fcCUyYc0Gpgh+ibCMwKtlWA2nzyVpTphJcnzpw2Om1ISgaOYNFnCAJtdVAzMJSAeLRa6u03iomZTVW4Uk5QQFh3FutiNnicp/1zUfRlF6TKtPHYqzvLzXexy8feLXvuQUkBqSPw8IQZhzcqPbnzRjCt/7uo15Fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iL1j0ImQ; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iL1j0ImQ" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784511445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmN0ofH4ZHkH9tClQTnobusWgTdM/e/XDkNzSWtRzUw=; b=iL1j0ImQxCKKUBJ/pJYTMCodAq+j4pf3xsj7zSfb2cubQR64zHi/qq77hKrPR/FZkO/uEr e3bDAEu+JRfa3isMG4VRtdCof2JfJvSLyAmfn9RoCGN7hPAErR06M6E+gSyTaplBPr0RGr Bu8fmqMrEs0lQ8ot/OeBtYVZx5xrmhw= From: Hongfu Li To: willy@infradead.org Cc: akpm@linux-foundation.org, david@kernel.org, hongfu.li@linux.dev, liam@infradead.org, lihongfu@kylinos.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Date: Mon, 20 Jul 2026 09:37:03 +0800 Message-ID: <20260720013703.4257-1-hongfu.li@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT > > From: Hongfu Li > > > > unlock_page(), end_page_writeback() and wait_on_page_writeback() > > are void wrappers forwarding to folio-based functions which also > > return void. Explicit return statements here are syntactically valid > > but unnecessary, and inconsistent with other nearby compat helpers > > such as mark_page_accessed() and set_page_writeback(). > > > > Drop all these superfluous return keywords. > > why bother? this file is temporary scaffolding. if they offend you so > much, work on removing the need for them. Thanks a lot for your comments. I fully agree with your point. You've already made great progress cleaning up this temporary scaffolding. I will follow your lead and keep working on reducing usages of these helper functions. Best regards, Hongfu